You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by idanz <gi...@git.apache.org> on 2018/11/17 05:11:48 UTC
[GitHub] spark pull request #23067: [SPARK-26097][Web UI] Add the new partitioning de...
GitHub user idanz opened a pull request:
https://github.com/apache/spark/pull/23067
[SPARK-26097][Web UI] Add the new partitioning description to the exchange node name
## What changes were proposed in this pull request?
small change in the node name of the Exchange node to add in the string representation of the partitioning, this is just to have this information propagate to the DAG UI and help with join skew investigation for example.
## How was this patch tested?
tested manually to see the UI impact and regression to see nothing is broken
Please review http://spark.apache.org/contributing.html before opening a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/idanz/spark patch-3
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/23067.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #23067
----
commit 74898fda77f255a13981907aa5b9b6b78406aa1d
Author: Idan Zalzberg <id...@...>
Date: 2018-11-17T05:05:03Z
Add the new partitioning description to the exchange node name
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23067: [SPARK-26097][Web UI] Add the new partitioning descripti...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23067
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23067: [SPARK-26097][Web UI] Add the new partitioning descripti...
Posted by idanz <gi...@git.apache.org>.
Github user idanz commented on the issue:
https://github.com/apache/spark/pull/23067
it will be shown even if not hovering, you can see it highlighted in the image
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23067: [SPARK-26097][Web UI] Add the new partitioning descripti...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23067
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23067: [SPARK-26097][Web UI] Add the new partitioning descripti...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23067
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23067: [SPARK-26097][Web UI] Add the new partitioning descripti...
Posted by gengliangwang <gi...@git.apache.org>.
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/23067
+1.
We can also try overriding `toString` for better output.
@vanzin
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org