You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2016/04/25 07:43:32 UTC
Review Request 46620: Refactored Flags to store name in `Name` struct
instead of string.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46620/
-----------------------------------------------------------
Review request for mesos and Ben Mahler.
Bugs: MESOS-5271
https://issues.apache.org/jira/browse/MESOS-5271
Repository: mesos
Description
-------
This sets up the stage to add metadata to the name (e.g., deprecated).
This will be used to add deprecation support subsequently.
Diffs
-----
3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp 2502d9e8a515b9adc1b3aa2f719e5710a0e7ef29
3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp c3cbcdb781e1c282d381de1ad2bf4f386ee1db21
Diff: https://reviews.apache.org/r/46620/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 46620: Refactored Flags to store name in `Name`
struct instead of string.
Posted by Vinod Kone <vi...@gmail.com>.
> On April 25, 2016, 2:48 p.m., Benjamin Bannier wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp, line 45
> > <https://reviews.apache.org/r/46620/diff/1/?file=1358748#file1358748line45>
> >
> > If this was `const` it would be much easier to reason how this works with all the usage sites.
const makes it harder to use the Flag (which contains the Name) in a map; because the assignment operator is deleted.
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46620/#review130422
-----------------------------------------------------------
On April 25, 2016, 5:43 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46620/
> -----------------------------------------------------------
>
> (Updated April 25, 2016, 5:43 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-5271
> https://issues.apache.org/jira/browse/MESOS-5271
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This sets up the stage to add metadata to the name (e.g., deprecated).
> This will be used to add deprecation support subsequently.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp 2502d9e8a515b9adc1b3aa2f719e5710a0e7ef29
> 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp c3cbcdb781e1c282d381de1ad2bf4f386ee1db21
>
> Diff: https://reviews.apache.org/r/46620/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 46620: Refactored Flags to store name in `Name`
struct instead of string.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46620/#review130422
-----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp (line 45)
<https://reviews.apache.org/r/46620/#comment194169>
If this was `const` it would be much easier to reason how this works with all the usage sites.
3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp (line 379)
<https://reviews.apache.org/r/46620/#comment194171>
Here and at similar call sites: since you provide an `operator<<` directly using `stringify(name)` here and elsewhere seems more consistent to me.
- Benjamin Bannier
On April 25, 2016, 7:43 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46620/
> -----------------------------------------------------------
>
> (Updated April 25, 2016, 7:43 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-5271
> https://issues.apache.org/jira/browse/MESOS-5271
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This sets up the stage to add metadata to the name (e.g., deprecated).
> This will be used to add deprecation support subsequently.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp 2502d9e8a515b9adc1b3aa2f719e5710a0e7ef29
> 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp c3cbcdb781e1c282d381de1ad2bf4f386ee1db21
>
> Diff: https://reviews.apache.org/r/46620/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 46620: Refactored Flags to store name in `Name`
struct instead of string.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46620/
-----------------------------------------------------------
(Updated April 29, 2016, 3:24 a.m.)
Review request for mesos and Ben Mahler.
Changes
-------
Moved the additon of "<" operator into the review where it is needed.
Bugs: MESOS-5271
https://issues.apache.org/jira/browse/MESOS-5271
Repository: mesos
Description
-------
This sets up the stage to add metadata to the name (e.g., deprecated).
This will be used to add deprecation support subsequently.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp 2502d9e8a515b9adc1b3aa2f719e5710a0e7ef29
3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp c3cbcdb781e1c282d381de1ad2bf4f386ee1db21
Diff: https://reviews.apache.org/r/46620/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 46620: Refactored Flags to store name in `Name`
struct instead of string.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46620/
-----------------------------------------------------------
(Updated April 26, 2016, 12:54 a.m.)
Review request for mesos and Ben Mahler.
Changes
-------
Used stringify(name) instead of name.value in string concatenations.
Bugs: MESOS-5271
https://issues.apache.org/jira/browse/MESOS-5271
Repository: mesos
Description
-------
This sets up the stage to add metadata to the name (e.g., deprecated).
This will be used to add deprecation support subsequently.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp 2502d9e8a515b9adc1b3aa2f719e5710a0e7ef29
3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp c3cbcdb781e1c282d381de1ad2bf4f386ee1db21
Diff: https://reviews.apache.org/r/46620/diff/
Testing
-------
make check
Thanks,
Vinod Kone