You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by GitBox <gi...@apache.org> on 2018/11/29 20:58:42 UTC

[GitHub] rdelval opened a new pull request #50: Set IsProd in Scheduler

rdelval opened a new pull request #50: Set IsProd in Scheduler
URL: https://github.com/apache/aurora/pull/50
 
 
   ### Description:
   isProd is a field inside the Job Configuration that was deprecated a long time ago (Aurora 0.14.0) when tiers were introduced. However, it's usage in the code base remains until [today](https://github.com/apache/aurora/blob/master/src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java#L81)
   
   Previously we relied on backfill to find a tier similar to the job's specifications (looked for a match in preemption and recovable).
   
   This patch seeks to explicitly set default tier (specified in the `tiers.json` file) and add an `isProduction()` method to the `TierInfo`. The `isProduction()` field returns true only if the tier is non-revocable and not preemtable.
   
   The patch also removes the backfill code which should not be necessary at this point.
   
   ### Testing Done:
   End to end
   Integration tests
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services