You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2018/09/06 06:48:05 UTC

[GitHub] JaroslavTulach commented on a change in pull request #844: Enforce public packages and friends for dependencies on bootstrap mod…

JaroslavTulach commented on a change in pull request #844: Enforce public packages and friends for dependencies on bootstrap mod…
URL: https://github.com/apache/incubator-netbeans/pull/844#discussion_r215510202
 
 

 ##########
 File path: platform/core.startup/src/org/netbeans/core/startup/ModuleSystem.java
 ##########
 @@ -176,54 +176,69 @@ public void loadBootModules() {
         ev.log(Events.START_LOAD_BOOT_MODULES);
         try {
             bootModules = new HashSet<Module>(10);
-            ClassLoader loader = ModuleSystem.class.getClassLoader();
+            ClassLoader upperLoader = ModuleSystem.class.getClassLoader();
+            // wrap alien loader, so it can be used among parent loaders of module (instanceof ProxyClassLoader)
+            ClassLoader loader = new JarClassLoader(Collections.<File>emptyList(), new ClassLoader[] { Lookup.class.getClassLoader() });
 
 Review comment:
   Maybe we could stick to module system classes and use `Module.class.getClassLoader()` - the result should be the same as both `boot.jar` and `org-openide-util-lookup.jar` are in the `platform/lib` - however the `Module` and `ModuleSystem` are more "co-located" than `Lookup`.
   
   Just a stylistic change, however.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists