You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by ky...@apache.org on 2018/06/07 02:55:50 UTC

incubator-weex git commit: * [android] Removed unit test task from weex_sdk travis build.

Repository: incubator-weex
Updated Branches:
  refs/heads/master 4a394a253 -> 981158f90


* [android] Removed unit test task from weex_sdk travis build.

As unit test codes for Weex sdk android stays unmaintained for long,
which breaks unit tests constantly, and need to rewrite. So we decided
to change the behavior of the travis build, we will only verify
Weex sdk build instead of running the unit test cases, until the unit
test codes get rewrite. Also changed the corresponding text output.

I'm sure this patch will make travis happy.


Project: http://git-wip-us.apache.org/repos/asf/incubator-weex/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-weex/commit/981158f9
Tree: http://git-wip-us.apache.org/repos/asf/incubator-weex/tree/981158f9
Diff: http://git-wip-us.apache.org/repos/asf/incubator-weex/diff/981158f9

Branch: refs/heads/master
Commit: 981158f90ae5ca6541b5025e41d79df263badb6c
Parents: 4a394a2
Author: Jonathan Dong <jo...@outlook.com>
Authored: Wed May 23 22:06:16 2018 +0800
Committer: YorkShen <sh...@gmail.com>
Committed: Thu Jun 7 10:55:43 2018 +0800

----------------------------------------------------------------------
 dangerfile-android.js | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-weex/blob/981158f9/dangerfile-android.js
----------------------------------------------------------------------
diff --git a/dangerfile-android.js b/dangerfile-android.js
index 01161a7..ef2a29b 100644
--- a/dangerfile-android.js
+++ b/dangerfile-android.js
@@ -90,18 +90,18 @@ if (!hasAndroidFile && danger.git.deleted_files) {
 }
 console.log('-----------------------------hasAndroidFile-----------------------------:'+hasAndroidFile);
 if(hasAndroidFile){
-  var runTestCmd='source ~/.bash_profile; '
+  var runTryBuildCmd='source ~/.bash_profile; '
     +'cd android; '
-    +'./gradlew clean assembleDebug :weex_sdk:testDebugUnitTest --info -PdisableCov=true '
+    +'./gradlew clean assembleDebug --info -PdisableCov=true '
     +'-Dorg.gradle.daemon=true -Dorg.gradle.parallel=true -Dorg.gradle.jvmargs="-Xmx512m '
     +'-XX:+HeapDumpOnOutOfMemoryError" -Dfile.encoding=UTF-8 '
-  var runSuccess = shell.exec(runTestCmd,{ async: false, timeout: 8 * 60 * 1000, maxBuffer: 200 * 1024 * 1024 }).code == 0;
+  var runSuccess = shell.exec(runTryBuildCmd,{ async: false, timeout: 8 * 60 * 1000, maxBuffer: 200 * 1024 * 1024 }).code == 0;
   if(!runSuccess){
-    fail("android platform run unit test failed!");
+    fail("Failed to run assembleDebug task for android.");
   }
 }else{
-  console.log('has no android file changed.');
-  message('has no android file changed.')
+  console.log('No android file has been changed.');
+  message('No android file has been changed.')
 }
 
-message('android test finished.')
+message('android build verification finished.')