[GitHub] [drill] vvysotskyi commented on a change in pull request #1782: DRILL-7237: Fix single_value aggregate function for variable length types

[GitBox <gi...@apache.org>]

vvysotskyi commented on a change in pull request #1782: DRILL-7237: Fix single_value aggregate function for variable length types
URL: https://github.com/apache/drill/pull/1782#discussion_r281585849
 
 

 ##########
 File path: exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestAggregateFunctions.java
 ##########
 @@ -640,11 +644,107 @@ public void testSingleValueFunction() throws Exception {
   }
 
   @Test
-  public void testSingleValueWithMultipleValuesInput() throws Exception {
+  public void testHashAggSingleValueFunction() throws Exception {
+    List<String> tableNames = Arrays.asList(
+        "cp.`parquet/alltypes_required.parquet`",
+        "cp.`parquet/alltypes_optional.parquet`");
+    for (String tableName : tableNames) {
+      QueryDataBatch result =
 
 Review comment:
   Agree, moved the logic for constructing baseline values into a separate method, but left code with a query in the test method for better readability.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services