You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2022/06/07 09:28:30 UTC
[GitHub] [dubbo-go] zgs225 opened a new pull request, #1924: fix: typo correction
zgs225 opened a new pull request, #1924:
URL: https://github.com/apache/dubbo-go/pull/1924
<!-- Thanks for sending a pull request!
Read https://github.com/apache/dubbo-go/blob/master/CONTRIBUTING.md before commit pull request.
-->
**What this PR does**:
**Which issue(s) this PR fixes**:
Fixes #
**You should pay attention to items below to ensure your pr passes our ci test**
We do not merge pr with ci tests failed
- [ ] All ut passed (run 'go test ./...' in project root)
- [ ] After go-fmt ed , run 'go fmt project' using goland.
- [ ] Golangci-lint passed, run 'sudo golangci-lint run' in project root.
- [ ] After import formatted, (using [imports-formatter](https://github.com/dubbogo/tools#5-how-to-get-imports-formatter) to run 'imports-formatter .' in project root, to format your import blocks, mentioned in [CONTRIBUTING.md](https://github.com/apache/dubbo-go/blob/master/CONTRIBUTING.md) above)
- [ ] Your new-created file needs to have [apache license](https://raw.githubusercontent.com/dubbogo/resources/master/tools/license/license.txt) at the top, like other existed file does.
- [ ] All integration test passed. You can run integration test locally (with docker env). Clone our [dubbo-go-samples](https://github.com/apache/dubbo-go-samples) project and replace the go.mod to your dubbo-go, and run 'sudo sh start_integration_test.sh' at root of samples project root. (M1 Slice is not Support)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on pull request #1924: fix: typo correction
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on PR #1924:
URL: https://github.com/apache/dubbo-go/pull/1924#issuecomment-1150670838
@zgs225 the github apollo config unit test case failed, pls fix it.
```bash
ok dubbo.apache.org/dubbo-go/v3/config_center 0.006s coverage: 9.1% of statements
2022-06-08T11:23:11.802Z INFO apollo/impl.go:70 [Apollo ConfigCenter] New Apollo ConfigCenter with Configuration: &{AppID:testApplication_yang Cluster:dev NamespaceName:mockDubbogo.yaml IP:http://127.0.0.1:37699/ NextTryConnTime:0 IsBackupConfig:true BackupConfigPath: Secret:}, url = apollo://127.0.0.1:37699?config-center.appId=testApplication_yang&config-center.cluster=dev&config-center.group=&config-center.namespace=mockDubbogo.yaml&config-center.timeout=&remote-client-name=dubbo.config-center-apollo-106.12.25.204%3A8080
2022-06-08T11:23:11.803Z INFO apollo/impl.go:70 [Apollo ConfigCenter] New Apollo ConfigCenter with Configuration: &{AppID:testApplication_yang Cluster:dev NamespaceName:mockDubbogo.yaml IP:http://127.0.0.1:37193/ NextTryConnTime:0 IsBackupConfig:true BackupConfigPath: Secret:}, url = apollo://127.0.0.1:37193?config-center.appId=testApplication_yang&config-center.cluster=dev&config-center.group=&config-center.namespace=mockDubbogo.yaml&config-center.timeout=&remote-client-name=dubbo.config-center-apollo-106.12.25.204%3A8080
2022-06-08T11:23:11.804Z INFO apollo/impl.go:70 [Apollo ConfigCenter] New Apollo ConfigCenter with Configuration: &{AppID:testApplication_yang Cluster:dev NamespaceName:mockDubbogo.yaml IP:http://127.0.0.1:37649/ NextTryConnTime:0 IsBackupConfig:true BackupConfigPath: Secret:}, url = apollo://127.0.0.1:37649?config-center.appId=testApplication_yang&config-center.cluster=dev&config-center.group=&config-center.namespace=mockDubbogo.yaml&config-center.timeout=&remote-client-name=dubbo.config-center-apollo-106.12.25.204%3A8080
panic: sync: negative WaitGroup counter
goroutine 131 [running]:
sync.(*WaitGroup).Add(0xc0002891d0, 0xffffffffffffffff)
/opt/hostedtoolcache/go/1.15.15/x64/src/sync/waitgroup.go:74 +0x147
sync.(*WaitGroup).Done(...)
/opt/hostedtoolcache/go/1.15.15/x64/src/sync/waitgroup.go:99
dubbo.apache.org/dubbo-go/v3/config_center/apollo.(*apolloDataListener).Process(0xc0002891d0, 0xc0005d2c00)
/home/runner/work/dubbo-go/dubbo-go/config_center/apollo/impl_test.go:213 +0x45
dubbo.apache.org/dubbo-go/v3/config_center/apollo.(*apolloListener).OnNewestChange(0xc000010300, 0xc00011dac0)
/home/runner/work/dubbo-go/dubbo-go/config_center/apollo/listener.go:58 +0x12d
created by github.com/zouyx/agollo/v3/storage.pushNewestChanges.func1
/home/runner/go/pkg/mod/github.com/zouyx/agollo/v3@v3.4.5/storage/change_event.go:112 +0x4c
FAIL dubbo.apache.org/dubbo-go/v3/config_center/apollo 2.025s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks merged pull request #1924: fix: typo correction
Posted by GitBox <gi...@apache.org>.
AlexStocks merged PR #1924:
URL: https://github.com/apache/dubbo-go/pull/1924
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter commented on pull request #1924: fix: typo correction
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #1924:
URL: https://github.com/apache/dubbo-go/pull/1924#issuecomment-1151057606
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1924?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1924](https://codecov.io/gh/apache/dubbo-go/pull/1924?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6c4d14b) into [3.0](https://codecov.io/gh/apache/dubbo-go/commit/07defad2eeb6befc24a3c75d8b8afb28dd4b1ed2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (07defad) will **decrease** coverage by `0.09%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## 3.0 #1924 +/- ##
==========================================
- Coverage 45.02% 44.92% -0.10%
==========================================
Files 287 287
Lines 17135 17135
==========================================
- Hits 7715 7698 -17
- Misses 8606 8623 +17
Partials 814 814
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1924?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1924/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `31.97% <0.00%> (ø)` | |
| [filter/metrics/filter.go](https://codecov.io/gh/apache/dubbo-go/pull/1924/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL21ldHJpY3MvZmlsdGVyLmdv) | `85.00% <0.00%> (-15.00%)` | :arrow_down: |
| [metadata/report/delegate/delegate\_report.go](https://codecov.io/gh/apache/dubbo-go/pull/1924/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWV0YWRhdGEvcmVwb3J0L2RlbGVnYXRlL2RlbGVnYXRlX3JlcG9ydC5nbw==) | `26.49% <0.00%> (-7.95%)` | :arrow_down: |
| [...tocol/rest/server/server\_impl/go\_restful\_server.go](https://codecov.io/gh/apache/dubbo-go/pull/1924/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdG9jb2wvcmVzdC9zZXJ2ZXIvc2VydmVyX2ltcGwvZ29fcmVzdGZ1bF9zZXJ2ZXIuZ28=) | `41.37% <0.00%> (-3.45%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1924?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1924?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [07defad...6c4d14b](https://codecov.io/gh/apache/dubbo-go/pull/1924?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] zgs225 commented on pull request #1924: fix: typo correction
Posted by GitBox <gi...@apache.org>.
zgs225 commented on PR #1924:
URL: https://github.com/apache/dubbo-go/pull/1924#issuecomment-1150760742
>
It seems like internal error which occurs randomly. Could you help to re-run the action?
> @zgs225 the github apollo config unit test case failed, pls fix it.
>
> ```shell
> ok dubbo.apache.org/dubbo-go/v3/config_center 0.006s coverage: 9.1% of statements
> 2022-06-08T11:23:11.802Z INFO apollo/impl.go:70 [Apollo ConfigCenter] New Apollo ConfigCenter with Configuration: &{AppID:testApplication_yang Cluster:dev NamespaceName:mockDubbogo.yaml IP:http://127.0.0.1:37699/ NextTryConnTime:0 IsBackupConfig:true BackupConfigPath: Secret:}, url = apollo://127.0.0.1:37699?config-center.appId=testApplication_yang&config-center.cluster=dev&config-center.group=&config-center.namespace=mockDubbogo.yaml&config-center.timeout=&remote-client-name=dubbo.config-center-apollo-106.12.25.204%3A8080
> 2022-06-08T11:23:11.803Z INFO apollo/impl.go:70 [Apollo ConfigCenter] New Apollo ConfigCenter with Configuration: &{AppID:testApplication_yang Cluster:dev NamespaceName:mockDubbogo.yaml IP:http://127.0.0.1:37193/ NextTryConnTime:0 IsBackupConfig:true BackupConfigPath: Secret:}, url = apollo://127.0.0.1:37193?config-center.appId=testApplication_yang&config-center.cluster=dev&config-center.group=&config-center.namespace=mockDubbogo.yaml&config-center.timeout=&remote-client-name=dubbo.config-center-apollo-106.12.25.204%3A8080
> 2022-06-08T11:23:11.804Z INFO apollo/impl.go:70 [Apollo ConfigCenter] New Apollo ConfigCenter with Configuration: &{AppID:testApplication_yang Cluster:dev NamespaceName:mockDubbogo.yaml IP:http://127.0.0.1:37649/ NextTryConnTime:0 IsBackupConfig:true BackupConfigPath: Secret:}, url = apollo://127.0.0.1:37649?config-center.appId=testApplication_yang&config-center.cluster=dev&config-center.group=&config-center.namespace=mockDubbogo.yaml&config-center.timeout=&remote-client-name=dubbo.config-center-apollo-106.12.25.204%3A8080
> panic: sync: negative WaitGroup counter
> goroutine 131 [running]:
> sync.(*WaitGroup).Add(0xc0002891d0, 0xffffffffffffffff)
> /opt/hostedtoolcache/go/1.15.15/x64/src/sync/waitgroup.go:74 +0x147
> sync.(*WaitGroup).Done(...)
> /opt/hostedtoolcache/go/1.15.15/x64/src/sync/waitgroup.go:99
> dubbo.apache.org/dubbo-go/v3/config_center/apollo.(*apolloDataListener).Process(0xc0002891d0, 0xc0005d2c00)
> /home/runner/work/dubbo-go/dubbo-go/config_center/apollo/impl_test.go:213 +0x45
> dubbo.apache.org/dubbo-go/v3/config_center/apollo.(*apolloListener).OnNewestChange(0xc000010300, 0xc00011dac0)
> /home/runner/work/dubbo-go/dubbo-go/config_center/apollo/listener.go:58 +0x12d
> created by github.com/zouyx/agollo/v3/storage.pushNewestChanges.func1
> /home/runner/go/pkg/mod/github.com/zouyx/agollo/v3@v3.4.5/storage/change_event.go:112 +0x4c
> FAIL dubbo.apache.org/dubbo-go/v3/config_center/apollo 2.025s
> ```
It seems like internal error which occurs randomly. Could you help to re-run the action?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org