You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2013/05/21 17:55:56 UTC
Review Request: Fixed output bug with CHECK_SOME.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11310/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Description
-------
See summary.
Diffs
-----
src/logging/check_some.hpp 8c8e136f49803c8e49d12cbdb10033d98bf27279
Diff: https://reviews.apache.org/r/11310/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request: Fixed output bug with CHECK_SOME.
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On May 21, 2013, 10:25 p.m., Vinod Kone wrote:
> > src/logging/check_some.hpp, line 86
> > <https://reviews.apache.org/r/11310/diff/1/?file=295247#file295247line86>
> >
> > How about "Failed CHECK_SOME(......"?
Ben Mahler modeled this after CHECK.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11310/#review20871
-----------------------------------------------------------
On May 21, 2013, 3:55 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11310/
> -----------------------------------------------------------
>
> (Updated May 21, 2013, 3:55 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/logging/check_some.hpp 8c8e136f49803c8e49d12cbdb10033d98bf27279
>
> Diff: https://reviews.apache.org/r/11310/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request: Fixed output bug with CHECK_SOME.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11310/#review20871
-----------------------------------------------------------
Ship it!
src/logging/check_some.hpp
<https://reviews.apache.org/r/11310/#comment42975>
How about "Failed CHECK_SOME(......"?
- Vinod Kone
On May 21, 2013, 3:55 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11310/
> -----------------------------------------------------------
>
> (Updated May 21, 2013, 3:55 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/logging/check_some.hpp 8c8e136f49803c8e49d12cbdb10033d98bf27279
>
> Diff: https://reviews.apache.org/r/11310/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request: Fixed output bug with CHECK_SOME.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11310/#review21340
-----------------------------------------------------------
My bad, thanks!
- Ben Mahler
On May 21, 2013, 3:55 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11310/
> -----------------------------------------------------------
>
> (Updated May 21, 2013, 3:55 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/logging/check_some.hpp 8c8e136f49803c8e49d12cbdb10033d98bf27279
>
> Diff: https://reviews.apache.org/r/11310/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>