You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@giraph.apache.org by "Jakob Homan (JIRA)" <ji...@apache.org> on 2011/08/23 23:33:29 UTC
[jira] [Created] (GIRAPH-3) Vertex:sentMsgToAllEdges should be
sendMsg
Vertex:sentMsgToAllEdges should be sendMsg
------------------------------------------
Key: GIRAPH-3
URL: https://issues.apache.org/jira/browse/GIRAPH-3
Project: Giraph
Issue Type: Bug
Reporter: Jakob Homan
Assignee: Jakob Homan
The method Vertex.java:sentMsgToAllEdges() should be sendMsgToAllEdges()
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-3) Vertex:sentMsgToAllEdges should be
sendMsg
Posted by "Avery Ching (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-3?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13089828#comment-13089828 ]
Avery Ching commented on GIRAPH-3:
----------------------------------
Duh. I guess we should wait until the svn import is finished before doing this...
> Vertex:sentMsgToAllEdges should be sendMsg
> ------------------------------------------
>
> Key: GIRAPH-3
> URL: https://issues.apache.org/jira/browse/GIRAPH-3
> Project: Giraph
> Issue Type: Bug
> Reporter: Jakob Homan
> Assignee: Jakob Homan
>
> The method Vertex.java:sentMsgToAllEdges() should be sendMsgToAllEdges()
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GIRAPH-3) Vertex:sentMsgToAllEdges should be
sendMsg
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-3?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jakob Homan updated GIRAPH-3:
-----------------------------
Attachment: GIRAPH-3.patch
Patch to do the refactor. I have no opinion on Msg/Message, but that style change would be large than the bugfix, so if we want to do so, let's do it in another JIRA. Now that the svndump has been completed, it's safe for me to commit the patch, post-review.
> Vertex:sentMsgToAllEdges should be sendMsg
> ------------------------------------------
>
> Key: GIRAPH-3
> URL: https://issues.apache.org/jira/browse/GIRAPH-3
> Project: Giraph
> Issue Type: Bug
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Attachments: GIRAPH-3.patch
>
>
> The method Vertex.java:sentMsgToAllEdges() should be sendMsgToAllEdges()
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-3) Vertex:sentMsgToAllEdges should be
sendMsg
Posted by "Avery Ching (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-3?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13091486#comment-13091486 ]
Avery Ching commented on GIRAPH-3:
----------------------------------
I've +1'd it too. We can address the naming conventions in another issue.
> Vertex:sentMsgToAllEdges should be sendMsg
> ------------------------------------------
>
> Key: GIRAPH-3
> URL: https://issues.apache.org/jira/browse/GIRAPH-3
> Project: Giraph
> Issue Type: Bug
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Attachments: GIRAPH-3.patch
>
>
> The method Vertex.java:sentMsgToAllEdges() should be sendMsgToAllEdges()
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-3) Vertex:sentMsgToAllEdges should be
sendMsg
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-3?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13089859#comment-13089859 ]
Jakob Homan commented on GIRAPH-3:
----------------------------------
yeah, I'll generate a patch, but it's not necessary to apply it until after the import.
> Vertex:sentMsgToAllEdges should be sendMsg
> ------------------------------------------
>
> Key: GIRAPH-3
> URL: https://issues.apache.org/jira/browse/GIRAPH-3
> Project: Giraph
> Issue Type: Bug
> Reporter: Jakob Homan
> Assignee: Jakob Homan
>
> The method Vertex.java:sentMsgToAllEdges() should be sendMsgToAllEdges()
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-3) Vertex:sentMsgToAllEdges should be
sendMsg
Posted by "Hyunsik Choi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-3?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13091475#comment-13091475 ]
Hyunsik Choi commented on GIRAPH-3:
-----------------------------------
I agree to avoid abbreviations in method names. It would be good to address the naming convention in a separate issue.
And, I vote +1 to the patch.
> Vertex:sentMsgToAllEdges should be sendMsg
> ------------------------------------------
>
> Key: GIRAPH-3
> URL: https://issues.apache.org/jira/browse/GIRAPH-3
> Project: Giraph
> Issue Type: Bug
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Attachments: GIRAPH-3.patch
>
>
> The method Vertex.java:sentMsgToAllEdges() should be sendMsgToAllEdges()
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-3) Vertex:sentMsgToAllEdges should be
sendMsg
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-3?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13089834#comment-13089834 ]
Owen O'Malley commented on GIRAPH-3:
------------------------------------
In general, I like to avoid abbreviations in method names. So maybe, sendMessageToAllEdges?
> Vertex:sentMsgToAllEdges should be sendMsg
> ------------------------------------------
>
> Key: GIRAPH-3
> URL: https://issues.apache.org/jira/browse/GIRAPH-3
> Project: Giraph
> Issue Type: Bug
> Reporter: Jakob Homan
> Assignee: Jakob Homan
>
> The method Vertex.java:sentMsgToAllEdges() should be sendMsgToAllEdges()
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira