You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by Patrick Hunt <ph...@apache.org> on 2014/07/17 18:38:51 UTC
Jenkins patch available failing - findbugs issues (what changed?)
Hi folks. I see that findbugs is picking up a number of issues in
recent "precommit" builds
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2191//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
-1 findbugs. The patch appears to introduce 87 new Findbugs (version
2.0.3) warnings.
Does anyone know why?
Giri is this related to the recent upgrades?
Patrick
Re: Jenkins patch available failing - findbugs issues (what changed?)
Posted by Patrick Hunt <ph...@apache.org>.
We have a file with findbugs excludes that sets a baseline. Anything
that shows up separate from the baseline is "introduced" (but really
introduced since the last time that file was updated, although this
typically means in the patch because we don't commit stuff that
introduced new issues in findbugs). I believe what's happened here is
that findbugs itself was upgraded, it now looks for new issues and
that's likely what is beyond the baseline file.
Look at src/java/test/config/findbugsExcludeFile.xml
Patrick
On Thu, Jul 17, 2014 at 12:51 PM, Flavio Junqueira
<fp...@yahoo.com.invalid> wrote:
> Right, somehow it looks like it has been "reset".
>
> -Flavio
>
> On 17 Jul 2014, at 18:12, Bill Havanki <bh...@clouderagovt.com> wrote:
>
>> I noticed this for ZOOKEEPER-1346. I ran findbugs myself on the most recent
>> patch for that ticket and on trunk, and they appeared to have the same set
>> of findbugs issues, so the "introduce" part is misleading.
>>
>>
>> On Thu, Jul 17, 2014 at 12:38 PM, Patrick Hunt <ph...@apache.org> wrote:
>>
>>> Hi folks. I see that findbugs is picking up a number of issues in
>>> recent "precommit" builds
>>>
>>>
>>> https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2191//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
>>>
>>> -1 findbugs. The patch appears to introduce 87 new Findbugs (version
>>> 2.0.3) warnings.
>>>
>>> Does anyone know why?
>>>
>>> Giri is this related to the recent upgrades?
>>>
>>> Patrick
>>>
>>
>>
>>
>> --
>> // Bill Havanki
>> // Solutions Architect, Cloudera Govt Solutions
>> // 443.686.9283
>
Re: Jenkins patch available failing - findbugs issues (what changed?)
Posted by Flavio Junqueira <fp...@yahoo.com.INVALID>.
Right, somehow it looks like it has been "reset".
-Flavio
On 17 Jul 2014, at 18:12, Bill Havanki <bh...@clouderagovt.com> wrote:
> I noticed this for ZOOKEEPER-1346. I ran findbugs myself on the most recent
> patch for that ticket and on trunk, and they appeared to have the same set
> of findbugs issues, so the "introduce" part is misleading.
>
>
> On Thu, Jul 17, 2014 at 12:38 PM, Patrick Hunt <ph...@apache.org> wrote:
>
>> Hi folks. I see that findbugs is picking up a number of issues in
>> recent "precommit" builds
>>
>>
>> https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2191//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
>>
>> -1 findbugs. The patch appears to introduce 87 new Findbugs (version
>> 2.0.3) warnings.
>>
>> Does anyone know why?
>>
>> Giri is this related to the recent upgrades?
>>
>> Patrick
>>
>
>
>
> --
> // Bill Havanki
> // Solutions Architect, Cloudera Govt Solutions
> // 443.686.9283
Re: Jenkins patch available failing - findbugs issues (what changed?)
Posted by Bill Havanki <bh...@clouderagovt.com>.
I noticed this for ZOOKEEPER-1346. I ran findbugs myself on the most recent
patch for that ticket and on trunk, and they appeared to have the same set
of findbugs issues, so the "introduce" part is misleading.
On Thu, Jul 17, 2014 at 12:38 PM, Patrick Hunt <ph...@apache.org> wrote:
> Hi folks. I see that findbugs is picking up a number of issues in
> recent "precommit" builds
>
>
> https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2191//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
>
> -1 findbugs. The patch appears to introduce 87 new Findbugs (version
> 2.0.3) warnings.
>
> Does anyone know why?
>
> Giri is this related to the recent upgrades?
>
> Patrick
>
--
// Bill Havanki
// Solutions Architect, Cloudera Govt Solutions
// 443.686.9283