You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cordova.apache.org by jsoref <gi...@git.apache.org> on 2014/08/13 16:18:43 UTC

[GitHub] cordova-plugin-media pull request: Update index.md

Github user jsoref commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-media/pull/23#discussion_r16177462
  
    --- Diff: doc/index.md ---
    @@ -49,7 +49,7 @@ and may deprecate the current APIs.
     
     ## Media
     
    -    var media = new Media(src, mediaSuccess, [mediaError], [mediaStatus]);
    --- End diff --
    
    Do we usually use this notation *in* JavaScript?
    
    In JavaScript, []s usually mean _an_ Array. For an example, I'd expect:
    ```js
    var media = new Media(src, mediaSuccess, mediaError, mediaStatus);
    ```
    
    Also, normally things should have a bug (issues.apache.org/jira) corresponding to the change...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---