You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/11/23 03:29:42 UTC
[GitHub] [apisix-dashboard] idbeta opened a new issue #851: bug: manager-api do not support consumer with custom create time or update time
idbeta opened a new issue #851:
URL: https://github.com/apache/apisix-dashboard/issues/851
# Bug report
## Describe the bug
use manager-api add a consumer with custom create time or update time,
but the consumer actually created does not use the custom time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] ShiningRush commented on issue #851: bug: manager-api do not support add consumer with custom create time or update time
Posted by GitBox <gi...@apache.org>.
ShiningRush commented on issue #851:
URL: https://github.com/apache/apisix-dashboard/issues/851#issuecomment-732531288
I don't think it is a bug, audit field should maintain by server not client.So we should not accept client audit field such as CreatedAt, CreatedBy etc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] ShiningRush edited a comment on issue #851: bug: manager-api do not support add consumer with custom create time or update time
Posted by GitBox <gi...@apache.org>.
ShiningRush edited a comment on issue #851:
URL: https://github.com/apache/apisix-dashboard/issues/851#issuecomment-732531288
I don't think it is a bug, audit field should maintain by server not client.So we should not accept client audit field such as `CreatedAt`, `CreatedBy` etc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on issue #851: bug: manager-api do not support add consumer with custom create time or update time
Posted by GitBox <gi...@apache.org>.
starsz commented on issue #851:
URL: https://github.com/apache/apisix-dashboard/issues/851#issuecomment-732162047
OK, I reproduce the issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] idbeta commented on issue #851: bug: manager-api do not support add consumer with custom create time or update time
Posted by GitBox <gi...@apache.org>.
idbeta commented on issue #851:
URL: https://github.com/apache/apisix-dashboard/issues/851#issuecomment-731935442
hi, @starsz you can refer tohttps://github.com/apache/apisix-dashboard/pull/830/files#diff-d6674616f38aabf4e6e7f91f04b057982213b9b3758fc363ffc140843db957e3R344-R385
this case is failed, it will return the current timestamp.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] idbeta edited a comment on issue #851: bug: manager-api do not support add consumer with custom create time or update time
Posted by GitBox <gi...@apache.org>.
idbeta edited a comment on issue #851:
URL: https://github.com/apache/apisix-dashboard/issues/851#issuecomment-733430843
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] idbeta closed issue #851: bug: manager-api do not support add consumer with custom create time or update time
Posted by GitBox <gi...@apache.org>.
idbeta closed issue #851:
URL: https://github.com/apache/apisix-dashboard/issues/851
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on issue #851: bug: manager-api do not support add consumer with custom create time or update time
Posted by GitBox <gi...@apache.org>.
liuxiran commented on issue #851:
URL: https://github.com/apache/apisix-dashboard/issues/851#issuecomment-732556546
> I don't think it is a bug, audit field should maintain by server not client.So we should not accept client audit field such as `CreatedAt`, `CreatedBy` etc.
agree +1.
If the user customizes these fields, it goes against the original intent of using these fields to record the time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on issue #851: bug: manager-api do not support add consumer with custom create time or update time
Posted by GitBox <gi...@apache.org>.
starsz commented on issue #851:
URL: https://github.com/apache/apisix-dashboard/issues/851#issuecomment-731929057
Hi, @idbeta, I can't get your point.
Can you give me an example or steps to reproduce the issue?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] idbeta edited a comment on issue #851: bug: manager-api do not support add consumer with custom create time or update time
Posted by GitBox <gi...@apache.org>.
idbeta edited a comment on issue #851:
URL: https://github.com/apache/apisix-dashboard/issues/851#issuecomment-731935442
hi, @starsz you can refer to https://github.com/apache/apisix-dashboard/pull/830/files#diff-d6674616f38aabf4e6e7f91f04b057982213b9b3758fc363ffc140843db957e3R344-R385
this case is failed, it will return the current timestamp.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on issue #851: bug: manager-api do not support add consumer with custom create time or update time
Posted by GitBox <gi...@apache.org>.
starsz commented on issue #851:
URL: https://github.com/apache/apisix-dashboard/issues/851#issuecomment-733427642
OK. So the conclusion is that we should not accept the client audit fields such as CreatedAt, CreatedBy.
If the client put those fields, just ignore them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] idbeta commented on issue #851: bug: manager-api do not support add consumer with custom create time or update time
Posted by GitBox <gi...@apache.org>.
idbeta commented on issue #851:
URL: https://github.com/apache/apisix-dashboard/issues/851#issuecomment-733430843
At the beginning, I referred to the processing of adminAPI. After reading your comments, I think that manager-api does not need to be the same as adminAPI at this point. I will modify the related test cases.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #851: bug: manager-api do not support add consumer with custom create time or update time
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #851:
URL: https://github.com/apache/apisix-dashboard/issues/851#issuecomment-733430504
Should we add this tip to FAQ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #851: bug: manager-api do not support add consumer with custom create time or update time
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #851:
URL: https://github.com/apache/apisix-dashboard/issues/851#issuecomment-732546208
Not sure if it's a bug indeed, what's your opinion? I would be more prefer with @ShiningRush's opinion 🤔
cc @membphis @nic-chen @liuxiran @tokers
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #851: bug: manager-api do not support add consumer with custom create time or update time
Posted by GitBox <gi...@apache.org>.
nic-chen commented on issue #851:
URL: https://github.com/apache/apisix-dashboard/issues/851#issuecomment-733425618
> I don't think it is a bug, audit field should maintain by server not client.So we should not accept client audit field such as `CreatedAt`, `CreatedBy` etc.
agree +1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org