You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/01/14 08:57:55 UTC
[GitHub] [airflow] turbaszek opened a new pull request #13670: Treat default value in HostnameCallable rule as good one
turbaszek opened a new pull request #13670:
URL: https://github.com/apache/airflow/pull/13670
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek merged pull request #13670: Treat default value in HostnameCallable rule as good one
Posted by GitBox <gi...@apache.org>.
turbaszek merged pull request #13670:
URL: https://github.com/apache/airflow/pull/13670
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #13670: Treat default value in HostnameCallable rule as good one
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #13670:
URL: https://github.com/apache/airflow/pull/13670#issuecomment-765707309
Rebasing to latest v1-10-stable should now run the tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #13670: Treat default value in HostnameCallable rule as good one
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #13670:
URL: https://github.com/apache/airflow/pull/13670#issuecomment-767096159
https://github.com/apache/airflow/pull/13897 should fix failing tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13670: Treat default value in HostnameCallable rule as good one
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13670:
URL: https://github.com/apache/airflow/pull/13670#issuecomment-768191575
[The Workflow run](https://github.com/apache/airflow/actions/runs/514761092) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13670: Treat default value in HostnameCallable rule as good one
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13670:
URL: https://github.com/apache/airflow/pull/13670#issuecomment-767105064
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on pull request #13670: Treat default value in HostnameCallable rule as good one
Posted by GitBox <gi...@apache.org>.
turbaszek commented on pull request #13670:
URL: https://github.com/apache/airflow/pull/13670#issuecomment-770768910
@kaxil I think we are good to merge this one?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek merged pull request #13670: Treat default value in HostnameCallable rule as good one
Posted by GitBox <gi...@apache.org>.
turbaszek merged pull request #13670:
URL: https://github.com/apache/airflow/pull/13670
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #13670: Treat default value in HostnameCallable rule as good one
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #13670:
URL: https://github.com/apache/airflow/pull/13670#issuecomment-767096159
https://github.com/apache/airflow/pull/13897 should fix failing tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #13670: Treat default value in HostnameCallable rule as good one
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #13670:
URL: https://github.com/apache/airflow/pull/13670#discussion_r557427326
##########
File path: airflow/upgrade/rules/hostname_callable_rule.py
##########
@@ -24,10 +24,15 @@
class HostnameCallable(BaseRule):
title = "Unify hostname_callable option in core section"
- description = ""
+ description = "hostname_callable option is using now only dots instead of dots and colons"
Review comment:
```suggestion
description = "hostname_callable option is now only using dots instead of dots and colons"
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13670: Treat default value in HostnameCallable rule as good one
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13670:
URL: https://github.com/apache/airflow/pull/13670#issuecomment-767105064
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13670: Treat default value in HostnameCallable rule as good one
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13670:
URL: https://github.com/apache/airflow/pull/13670#issuecomment-770759892
[The Workflow run](https://github.com/apache/airflow/actions/runs/527171798) is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org