You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@poi.apache.org by ki...@apache.org on 2020/01/06 21:48:00 UTC
svn commit: r1872397 [3/3] - in /poi/trunk/src/testcases/org/apache/poi:
hssf/usermodel/TestBugs.java ss/usermodel/BaseTestBugzillaIssues.java
Modified: poi/trunk/src/testcases/org/apache/poi/ss/usermodel/BaseTestBugzillaIssues.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/usermodel/BaseTestBugzillaIssues.java?rev=1872397&r1=1872396&r2=1872397&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/ss/usermodel/BaseTestBugzillaIssues.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/ss/usermodel/BaseTestBugzillaIssues.java Mon Jan 6 21:48:00 2020
@@ -50,8 +50,6 @@ import org.junit.Test;
/**
* A base class for bugzilla issues that can be described in terms of common ss interfaces.
- *
- * @author Yegor Kozlov
*/
public abstract class BaseTestBugzillaIssues {
private static final POILogger logger = POILogFactory.getLogger(BaseTestBugzillaIssues.class);
@@ -73,7 +71,7 @@ public abstract class BaseTestBugzillaIs
* where delta is an absolute error value, this function's factor is a relative error,
* so it's easier to express "actual is within 5% of expected".
*/
- public static void assertAlmostEquals(double expected, double actual, float factor) {
+ private static void assertAlmostEquals(double expected, double actual, float factor) {
double diff = Math.abs(expected - actual);
double fuzz = expected * factor;
if (diff > fuzz) {
@@ -89,22 +87,21 @@ public abstract class BaseTestBugzillaIs
*/
@Test
public final void bug23094() throws IOException {
- Workbook wb1 = _testDataProvider.createWorkbook();
- Sheet s = wb1.createSheet();
- Row r = s.createRow(0);
- r.createCell(0).setCellFormula("HYPERLINK(\"http://jakarta.apache.org\",\"Jakarta\")");
- r.createCell(1).setCellFormula("HYPERLINK(\"http://google.com\",\"Google\")");
-
- Workbook wb2 = _testDataProvider.writeOutAndReadBack(wb1);
- wb1.close();
- r = wb2.getSheetAt(0).getRow(0);
-
- Cell cell_0 = r.getCell(0);
- assertEquals("HYPERLINK(\"http://jakarta.apache.org\",\"Jakarta\")", cell_0.getCellFormula());
- Cell cell_1 = r.getCell(1);
- assertEquals("HYPERLINK(\"http://google.com\",\"Google\")", cell_1.getCellFormula());
-
- wb2.close();
+ try (Workbook wb1 = _testDataProvider.createWorkbook()) {
+ Sheet s = wb1.createSheet();
+ Row r = s.createRow(0);
+ r.createCell(0).setCellFormula("HYPERLINK(\"http://jakarta.apache.org\",\"Jakarta\")");
+ r.createCell(1).setCellFormula("HYPERLINK(\"http://google.com\",\"Google\")");
+
+ try (Workbook wb2 = _testDataProvider.writeOutAndReadBack(wb1)) {
+ r = wb2.getSheetAt(0).getRow(0);
+
+ Cell cell_0 = r.getCell(0);
+ assertEquals("HYPERLINK(\"http://jakarta.apache.org\",\"Jakarta\")", cell_0.getCellFormula());
+ Cell cell_1 = r.getCell(1);
+ assertEquals("HYPERLINK(\"http://google.com\",\"Google\")", cell_1.getCellFormula());
+ }
+ }
}
/**
@@ -113,40 +110,40 @@ public abstract class BaseTestBugzillaIs
* @param num the number of strings to generate
*/
public final void bug15375(int num) throws IOException {
- Workbook wb1 = _testDataProvider.createWorkbook();
- Sheet sheet = wb1.createSheet();
- CreationHelper factory = wb1.getCreationHelper();
-
- for (int i = 0; i < num; i++) {
- String tmp1 = "Test1" + i;
- String tmp2 = "Test2" + i;
- String tmp3 = "Test3" + i;
-
- Row row = sheet.createRow(i);
-
- Cell cell = row.createCell(0);
- cell.setCellValue(factory.createRichTextString(tmp1));
- cell = row.createCell(1);
- cell.setCellValue(factory.createRichTextString(tmp2));
- cell = row.createCell(2);
- cell.setCellValue(factory.createRichTextString(tmp3));
- }
- Workbook wb2 = _testDataProvider.writeOutAndReadBack(wb1);
- wb1.close();
+ try (Workbook wb1 = _testDataProvider.createWorkbook()) {
+ Sheet sheet = wb1.createSheet();
+ CreationHelper factory = wb1.getCreationHelper();
+
+ for (int i = 0; i < num; i++) {
+ String tmp1 = "Test1" + i;
+ String tmp2 = "Test2" + i;
+ String tmp3 = "Test3" + i;
+
+ Row row = sheet.createRow(i);
+
+ Cell cell = row.createCell(0);
+ cell.setCellValue(factory.createRichTextString(tmp1));
+ cell = row.createCell(1);
+ cell.setCellValue(factory.createRichTextString(tmp2));
+ cell = row.createCell(2);
+ cell.setCellValue(factory.createRichTextString(tmp3));
+ }
- sheet = wb2.getSheetAt(0);
- for (int i = 0; i < num; i++) {
- String tmp1 = "Test1" + i;
- String tmp2 = "Test2" + i;
- String tmp3 = "Test3" + i;
-
- Row row = sheet.getRow(i);
-
- assertEquals(tmp1, row.getCell(0).getStringCellValue());
- assertEquals(tmp2, row.getCell(1).getStringCellValue());
- assertEquals(tmp3, row.getCell(2).getStringCellValue());
+ try (Workbook wb2 = _testDataProvider.writeOutAndReadBack(wb1)) {
+ sheet = wb2.getSheetAt(0);
+ for (int i = 0; i < num; i++) {
+ String tmp1 = "Test1" + i;
+ String tmp2 = "Test2" + i;
+ String tmp3 = "Test3" + i;
+
+ Row row = sheet.getRow(i);
+
+ assertEquals(tmp1, row.getCell(0).getStringCellValue());
+ assertEquals(tmp2, row.getCell(1).getStringCellValue());
+ assertEquals(tmp3, row.getCell(2).getStringCellValue());
+ }
+ }
}
- wb2.close();
}
/**
@@ -154,51 +151,49 @@ public abstract class BaseTestBugzillaIs
*/
@Test
public void bug22720() throws IOException {
- Workbook wb = _testDataProvider.createWorkbook();
- wb.createSheet("TEST");
- Sheet template = wb.getSheetAt(0);
-
- assertEquals(0, template.addMergedRegion(new CellRangeAddress(0, 1, 0, 2)));
- assertEquals(1, template.addMergedRegion(new CellRangeAddress(2, 3, 0, 2)));
+ try (Workbook wb = _testDataProvider.createWorkbook()) {
+ wb.createSheet("TEST");
+ Sheet template = wb.getSheetAt(0);
- Sheet clone = wb.cloneSheet(0);
- int originalMerged = template.getNumMergedRegions();
- assertEquals("2 merged regions", 2, originalMerged);
+ assertEquals(0, template.addMergedRegion(new CellRangeAddress(0, 1, 0, 2)));
+ assertEquals(1, template.addMergedRegion(new CellRangeAddress(2, 3, 0, 2)));
- //remove merged regions from clone
- for (int i=template.getNumMergedRegions()-1; i>=0; i--) {
- clone.removeMergedRegion(i);
- }
+ Sheet clone = wb.cloneSheet(0);
+ int originalMerged = template.getNumMergedRegions();
+ assertEquals("2 merged regions", 2, originalMerged);
+
+ //remove merged regions from clone
+ for (int i = template.getNumMergedRegions() - 1; i >= 0; i--) {
+ clone.removeMergedRegion(i);
+ }
- assertEquals("Original Sheet's Merged Regions were removed", originalMerged, template.getNumMergedRegions());
- //check if template's merged regions are OK
- if (template.getNumMergedRegions()>0) {
- // fetch the first merged region...EXCEPTION OCCURS HERE
- template.getMergedRegion(0);
+ assertEquals("Original Sheet's Merged Regions were removed", originalMerged, template.getNumMergedRegions());
+ //check if template's merged regions are OK
+ if (template.getNumMergedRegions() > 0) {
+ // fetch the first merged region...EXCEPTION OCCURS HERE
+ template.getMergedRegion(0);
+ }
}
-
- wb.close();
}
@Test
public final void bug28031() throws IOException {
- Workbook wb1 = _testDataProvider.createWorkbook();
- Sheet sheet = wb1.createSheet();
- wb1.setSheetName(0, "Sheet1");
+ try (Workbook wb1 = _testDataProvider.createWorkbook()) {
+ Sheet sheet = wb1.createSheet();
+ wb1.setSheetName(0, "Sheet1");
- Row row = sheet.createRow(0);
- Cell cell = row.createCell(0);
- String formulaText =
- "IF(ROUND(A2*B2*C2,2)>ROUND(B2*D2,2),ROUND(A2*B2*C2,2),ROUND(B2*D2,2))";
- cell.setCellFormula(formulaText);
-
- assertEquals(formulaText, cell.getCellFormula());
- Workbook wb2 = _testDataProvider.writeOutAndReadBack(wb1);
- wb1.close();
-
- cell = wb2.getSheetAt(0).getRow(0).getCell(0);
- assertEquals("IF(ROUND(A2*B2*C2,2)>ROUND(B2*D2,2),ROUND(A2*B2*C2,2),ROUND(B2*D2,2))", cell.getCellFormula());
- wb2.close();
+ Row row = sheet.createRow(0);
+ Cell cell = row.createCell(0);
+ String formulaText =
+ "IF(ROUND(A2*B2*C2,2)>ROUND(B2*D2,2),ROUND(A2*B2*C2,2),ROUND(B2*D2,2))";
+ cell.setCellFormula(formulaText);
+
+ assertEquals(formulaText, cell.getCellFormula());
+ try (Workbook wb2 = _testDataProvider.writeOutAndReadBack(wb1)) {
+ cell = wb2.getSheetAt(0).getRow(0).getCell(0);
+ assertEquals("IF(ROUND(A2*B2*C2,2)>ROUND(B2*D2,2),ROUND(A2*B2*C2,2),ROUND(B2*D2,2))", cell.getCellFormula());
+ }
+ }
}
/**
@@ -208,64 +203,64 @@ public abstract class BaseTestBugzillaIs
*/
@Test
public final void bug21334() throws IOException {
- Workbook wb1 = _testDataProvider.createWorkbook();
- Sheet sh = wb1.createSheet();
- Cell cell = sh.createRow(0).createCell(0);
- String formula = "SUM(IF(FREQUENCY(IF(LEN(V4:V220)>0,MATCH(V4:V220,V4:V220,0),\"\"),IF(LEN(V4:V220)>0,MATCH(V4:V220,V4:V220,0),\"\"))>0,1))";
- cell.setCellFormula(formula);
-
- Workbook wb2 = _testDataProvider.writeOutAndReadBack(wb1);
- wb1.close();
- Cell cell_sv = wb2.getSheetAt(0).getRow(0).getCell(0);
- assertEquals(formula, cell_sv.getCellFormula());
- wb2.close();
+ try (Workbook wb1 = _testDataProvider.createWorkbook()) {
+ Sheet sh = wb1.createSheet();
+ Cell cell = sh.createRow(0).createCell(0);
+ String formula = "SUM(IF(FREQUENCY(IF(LEN(V4:V220)>0,MATCH(V4:V220,V4:V220,0),\"\"),IF(LEN(V4:V220)>0,MATCH(V4:V220,V4:V220,0),\"\"))>0,1))";
+ cell.setCellFormula(formula);
+
+ try (Workbook wb2 = _testDataProvider.writeOutAndReadBack(wb1)) {
+ Cell cell_sv = wb2.getSheetAt(0).getRow(0).getCell(0);
+ assertEquals(formula, cell_sv.getCellFormula());
+ }
+ }
}
/** another test for the number of unique strings issue
*test opening the resulting file in Excel*/
@Test
public final void bug22568() throws IOException {
- Workbook wb1 = _testDataProvider.createWorkbook();
- Sheet sheet = wb1.createSheet("ExcelTest") ;
+ try (Workbook wb1 = _testDataProvider.createWorkbook()) {
+ Sheet sheet = wb1.createSheet("ExcelTest");
- int col_cnt = 3;
- int rw_cnt = 2000;
+ int col_cnt = 3;
+ int rw_cnt = 2000;
- Row rw ;
- rw = sheet.createRow(0) ;
- //Header row
- for(int j=0; j<col_cnt; j++){
- Cell cell = rw.createCell(j) ;
- cell.setCellValue("Col " + (j+1));
- }
+ Row rw;
+ rw = sheet.createRow(0);
+ //Header row
+ for (int j = 0; j < col_cnt; j++) {
+ Cell cell = rw.createCell(j);
+ cell.setCellValue("Col " + (j + 1));
+ }
- for(int i=1; i<rw_cnt; i++){
- rw = sheet.createRow(i) ;
- for(int j=0; j<col_cnt; j++){
- Cell cell = rw.createCell(j) ;
- cell.setCellValue("Row:" + (i+1) + ",Column:" + (j+1));
+ for (int i = 1; i < rw_cnt; i++) {
+ rw = sheet.createRow(i);
+ for (int j = 0; j < col_cnt; j++) {
+ Cell cell = rw.createCell(j);
+ cell.setCellValue("Row:" + (i + 1) + ",Column:" + (j + 1));
+ }
}
- }
- sheet.setDefaultColumnWidth(18) ;
+ sheet.setDefaultColumnWidth(18);
- Workbook wb2 = _testDataProvider.writeOutAndReadBack(wb1);
- wb1.close();
- sheet = wb2.getSheetAt(0);
- rw = sheet.getRow(0);
- //Header row
- for(int j=0; j<col_cnt; j++){
- Cell cell = rw.getCell(j) ;
- assertEquals("Col " + (j+1), cell.getStringCellValue());
- }
- for(int i=1; i<rw_cnt; i++){
- rw = sheet.getRow(i) ;
- for(int j=0; j<col_cnt; j++){
- Cell cell = rw.getCell(j) ;
- assertEquals("Row:" + (i+1) + ",Column:" + (j+1), cell.getStringCellValue());
+ try (Workbook wb2 = _testDataProvider.writeOutAndReadBack(wb1)) {
+ sheet = wb2.getSheetAt(0);
+ rw = sheet.getRow(0);
+ //Header row
+ for (int j = 0; j < col_cnt; j++) {
+ Cell cell = rw.getCell(j);
+ assertEquals("Col " + (j + 1), cell.getStringCellValue());
+ }
+ for (int i = 1; i < rw_cnt; i++) {
+ rw = sheet.getRow(i);
+ for (int j = 0; j < col_cnt; j++) {
+ Cell cell = rw.getCell(j);
+ assertEquals("Row:" + (i + 1) + ",Column:" + (j + 1), cell.getStringCellValue());
+ }
+ }
}
}
- wb2.close();
}
/**
@@ -273,28 +268,35 @@ public abstract class BaseTestBugzillaIs
*/
@Test
public final void bug42448() throws IOException {
- Workbook wb = _testDataProvider.createWorkbook();
- Cell cell = wb.createSheet().createRow(0).createCell(0);
- cell.setCellFormula("SUMPRODUCT(A!C7:A!C67, B8:B68) / B69");
- assertTrue("no errors parsing formula", true);
- wb.close();
+ String exp = "SUMPRODUCT(A!C7:A!C67, B8:B68) / B69";
+ try (Workbook wb1 = _testDataProvider.createWorkbook()) {
+ Cell cell = wb1.createSheet().createRow(0).createCell(0);
+ cell.setCellFormula(exp);
+ wb1.createSheet("A");
+ cell.setCellFormula(exp);
+ try (Workbook wb2 = _testDataProvider.writeOutAndReadBack(wb1)) {
+ String act = wb2.getSheetAt(0).getRow(0).getCell(0).getCellFormula();
+ // XSSF saves formula as-is, HSSF saves as PTG and strips the whitespace
+ assertEquals(exp.replace(" ",""), act.replace(" ", ""));
+ }
+ }
}
@Test
public void bug18800() throws IOException {
- Workbook wb1 = _testDataProvider.createWorkbook();
- wb1.createSheet("TEST");
- Sheet sheet = wb1.cloneSheet(0);
- wb1.setSheetName(1,"CLONE");
- sheet.createRow(0).createCell(0).setCellValue("Test");
-
- Workbook wb2 = _testDataProvider.writeOutAndReadBack(wb1);
- wb1.close();
- sheet = wb2.getSheet("CLONE");
- Row row = sheet.getRow(0);
- Cell cell = row.getCell(0);
- assertEquals("Test", cell.getRichStringCellValue().getString());
- wb2.close();
+ try (Workbook wb1 = _testDataProvider.createWorkbook()) {
+ wb1.createSheet("TEST");
+ Sheet sheet = wb1.cloneSheet(0);
+ wb1.setSheetName(1, "CLONE");
+ sheet.createRow(0).createCell(0).setCellValue("Test");
+
+ try (Workbook wb2 = _testDataProvider.writeOutAndReadBack(wb1)) {
+ sheet = wb2.getSheet("CLONE");
+ Row row = sheet.getRow(0);
+ Cell cell = row.getCell(0);
+ assertEquals("Test", cell.getRichStringCellValue().getString());
+ }
+ }
}
private static void addNewSheetWithCellsA1toD4(Workbook book, int sheet) {
@@ -313,24 +315,24 @@ public abstract class BaseTestBugzillaIs
@Test
public void bug43093() throws IOException {
- Workbook xlw = _testDataProvider.createWorkbook();
-
- addNewSheetWithCellsA1toD4(xlw, 1);
- addNewSheetWithCellsA1toD4(xlw, 2);
- addNewSheetWithCellsA1toD4(xlw, 3);
- addNewSheetWithCellsA1toD4(xlw, 4);
+ try (Workbook wb = _testDataProvider.createWorkbook()) {
- Sheet s2 = xlw.getSheet("s2");
- Row s2r3 = s2.getRow(3);
- Cell s2E4 = s2r3.createCell(4);
- s2E4.setCellFormula("SUM(s3!B2:C3)");
+ addNewSheetWithCellsA1toD4(wb, 1);
+ addNewSheetWithCellsA1toD4(wb, 2);
+ addNewSheetWithCellsA1toD4(wb, 3);
+ addNewSheetWithCellsA1toD4(wb, 4);
+
+ Sheet s2 = wb.getSheet("s2");
+ Row s2r3 = s2.getRow(3);
+ Cell s2E4 = s2r3.createCell(4);
+ s2E4.setCellFormula("SUM(s3!B2:C3)");
- FormulaEvaluator eva = xlw.getCreationHelper().createFormulaEvaluator();
- double d = eva.evaluate(s2E4).getNumberValue();
+ FormulaEvaluator eva = wb.getCreationHelper().createFormulaEvaluator();
+ double d = eva.evaluate(s2E4).getNumberValue();
- assertEquals(d, (311+312+321+322), 0.0000001);
+ assertEquals(d, (311 + 312 + 321 + 322), 0.0000001);
- xlw.close();
+ }
}
@Test
@@ -338,27 +340,27 @@ public abstract class BaseTestBugzillaIs
String[] func = {"COUNT", "AVERAGE", "MAX", "MIN", "OR", "SUBTOTAL", "SKEW"};
SpreadsheetVersion ssVersion = _testDataProvider.getSpreadsheetVersion();
- Workbook wb = _testDataProvider.createWorkbook();
- Cell cell = wb.createSheet().createRow(0).createCell(0);
-
- String fmla;
- for (String name : func) {
+ try (Workbook wb = _testDataProvider.createWorkbook()) {
+ Cell cell = wb.createSheet().createRow(0).createCell(0);
- fmla = createFunction(name, 5);
- cell.setCellFormula(fmla);
+ String fmla;
+ for (String name : func) {
- fmla = createFunction(name, ssVersion.getMaxFunctionArgs());
- cell.setCellFormula(fmla);
+ fmla = createFunction(name, 5);
+ cell.setCellFormula(fmla);
- try {
- fmla = createFunction(name, ssVersion.getMaxFunctionArgs() + 1);
+ fmla = createFunction(name, ssVersion.getMaxFunctionArgs());
cell.setCellFormula(fmla);
- fail("Expected FormulaParseException");
- } catch (FormulaParseException e){
- assertTrue(e.getMessage().startsWith("Too many arguments to function '"+name+"'"));
+
+ try {
+ fmla = createFunction(name, ssVersion.getMaxFunctionArgs() + 1);
+ cell.setCellFormula(fmla);
+ fail("Expected FormulaParseException");
+ } catch (FormulaParseException e) {
+ assertTrue(e.getMessage().startsWith("Too many arguments to function '" + name + "'"));
+ }
}
}
- wb.close();
}
private static String createFunction(String name, int maxArgs){
@@ -377,102 +379,102 @@ public abstract class BaseTestBugzillaIs
@Test
public final void bug50681_testAutoSize() throws IOException {
- Workbook wb = _testDataProvider.createWorkbook();
- Sheet sheet = wb.createSheet("Sheet1");
- _testDataProvider.trackAllColumnsForAutosizing(sheet);
- Row row = sheet.createRow(0);
- Cell cell0 = row.createCell(0);
-
- String longValue = "www.hostname.com, www.hostname.com, " +
- "www.hostname.com, www.hostname.com, www.hostname.com, " +
- "www.hostname.com, www.hostname.com, www.hostname.com, " +
- "www.hostname.com, www.hostname.com, www.hostname.com, " +
- "www.hostname.com, www.hostname.com, www.hostname.com, " +
- "www.hostname.com, www.hostname.com, www.hostname.com, www.hostname.com";
-
- cell0.setCellValue(longValue);
-
- // autoSize will fail if required fonts are not installed, skip this test then
- Font font = wb.getFontAt(cell0.getCellStyle().getFontIndexAsInt());
- Assume.assumeTrue("Cannot verify autoSizeColumn() because the necessary Fonts are not installed on this machine: " + font,
- SheetUtil.canComputeColumnWidth(font));
-
- assertEquals("Expecting no indentation in this test",
- 0, cell0.getCellStyle().getIndention());
- assertEquals("Expecting no rotation in this test",
- 0, cell0.getCellStyle().getRotation());
+ try (Workbook wb = _testDataProvider.createWorkbook()) {
+ Sheet sheet = wb.createSheet("Sheet1");
+ _testDataProvider.trackAllColumnsForAutosizing(sheet);
+ Row row = sheet.createRow(0);
+ Cell cell0 = row.createCell(0);
+
+ String longValue = "www.hostname.com, www.hostname.com, " +
+ "www.hostname.com, www.hostname.com, www.hostname.com, " +
+ "www.hostname.com, www.hostname.com, www.hostname.com, " +
+ "www.hostname.com, www.hostname.com, www.hostname.com, " +
+ "www.hostname.com, www.hostname.com, www.hostname.com, " +
+ "www.hostname.com, www.hostname.com, www.hostname.com, www.hostname.com";
+
+ cell0.setCellValue(longValue);
+
+ // autoSize will fail if required fonts are not installed, skip this test then
+ Font font = wb.getFontAt(cell0.getCellStyle().getFontIndexAsInt());
+ Assume.assumeTrue("Cannot verify autoSizeColumn() because the necessary Fonts are not installed on this machine: " + font,
+ SheetUtil.canComputeColumnWidth(font));
+
+ assertEquals("Expecting no indentation in this test",
+ 0, cell0.getCellStyle().getIndention());
+ assertEquals("Expecting no rotation in this test",
+ 0, cell0.getCellStyle().getRotation());
- // check computing size up to a large size
+ // check computing size up to a large size
// StringBuilder b = new StringBuilder();
// for(int i = 0;i < longValue.length()*5;i++) {
// b.append("w");
// assertTrue("Had zero length starting at length " + i, computeCellWidthFixed(font, b.toString()) > 0);
// }
- double widthManual = computeCellWidthManually(cell0, font);
- double widthBeforeCell = SheetUtil.getCellWidth(cell0, 8, null, false);
- double widthBeforeCol = SheetUtil.getColumnWidth(sheet, 0, false);
-
- String info = widthManual + "/" + widthBeforeCell + "/" + widthBeforeCol + "/" +
- SheetUtil.canComputeColumnWidth(font) + "/" + computeCellWidthFixed(font, "1") + "/" + computeCellWidthFixed(font, "w") + "/" +
- computeCellWidthFixed(font, "1w") + "/" + computeCellWidthFixed(font, "0000") + "/" + computeCellWidthFixed(font, longValue);
- assertTrue("Expected to have cell width > 0 when computing manually, but had " + info, widthManual > 0);
- assertTrue("Expected to have cell width > 0 BEFORE auto-size, but had " + info, widthBeforeCell > 0);
- assertTrue("Expected to have column width > 0 BEFORE auto-size, but had " + info, widthBeforeCol > 0);
-
- sheet.autoSizeColumn(0);
-
- double width = SheetUtil.getColumnWidth(sheet, 0, false);
- assertTrue("Expected to have column width > 0 AFTER auto-size, but had " + width, width > 0);
- width = SheetUtil.getCellWidth(cell0, 8, null, false);
- assertTrue("Expected to have cell width > 0 AFTER auto-size, but had " + width, width > 0);
-
- assertEquals(255*256, sheet.getColumnWidth(0)); // maximum column width is 255 characters
- sheet.setColumnWidth(0, sheet.getColumnWidth(0)); // Bug 50681 reports exception at this point
- wb.close();
+ double widthManual = computeCellWidthManually(cell0, font);
+ double widthBeforeCell = SheetUtil.getCellWidth(cell0, 8, null, false);
+ double widthBeforeCol = SheetUtil.getColumnWidth(sheet, 0, false);
+
+ String info = widthManual + "/" + widthBeforeCell + "/" + widthBeforeCol + "/" +
+ SheetUtil.canComputeColumnWidth(font) + "/" + computeCellWidthFixed(font, "1") + "/" + computeCellWidthFixed(font, "w") + "/" +
+ computeCellWidthFixed(font, "1w") + "/" + computeCellWidthFixed(font, "0000") + "/" + computeCellWidthFixed(font, longValue);
+ assertTrue("Expected to have cell width > 0 when computing manually, but had " + info, widthManual > 0);
+ assertTrue("Expected to have cell width > 0 BEFORE auto-size, but had " + info, widthBeforeCell > 0);
+ assertTrue("Expected to have column width > 0 BEFORE auto-size, but had " + info, widthBeforeCol > 0);
+
+ sheet.autoSizeColumn(0);
+
+ double width = SheetUtil.getColumnWidth(sheet, 0, false);
+ assertTrue("Expected to have column width > 0 AFTER auto-size, but had " + width, width > 0);
+ width = SheetUtil.getCellWidth(cell0, 8, null, false);
+ assertTrue("Expected to have cell width > 0 AFTER auto-size, but had " + width, width > 0);
+
+ assertEquals(255 * 256, sheet.getColumnWidth(0)); // maximum column width is 255 characters
+ sheet.setColumnWidth(0, sheet.getColumnWidth(0)); // Bug 50681 reports exception at this point
+ }
}
-
+
@Test
public final void bug51622_testAutoSizeShouldRecognizeLeadingSpaces() throws IOException {
- Workbook wb = _testDataProvider.createWorkbook();
- Sheet sheet = wb.createSheet();
- _testDataProvider.trackAllColumnsForAutosizing(sheet);
- Row row = sheet.createRow(0);
- Cell cell0 = row.createCell(0);
- Cell cell1 = row.createCell(1);
- Cell cell2 = row.createCell(2);
-
- cell0.setCellValue("Test Column AutoSize");
- cell1.setCellValue(" Test Column AutoSize");
- cell2.setCellValue("Test Column AutoSize ");
-
- sheet.autoSizeColumn(0);
- sheet.autoSizeColumn(1);
- sheet.autoSizeColumn(2);
-
- int noWhitespaceColWidth = sheet.getColumnWidth(0);
- int leadingWhitespaceColWidth = sheet.getColumnWidth(1);
- int trailingWhitespaceColWidth = sheet.getColumnWidth(2);
-
- // Based on the amount of text and whitespace used, and the default font
- // assume that the cell with whitespace should be at least 20% wider than
- // the cell without whitespace. This number is arbitrary, but should be large
- // enough to guarantee that the whitespace cell isn't wider due to chance.
- // Experimentally, I calculated the ratio as 1.2478181, though this ratio may change
- // if the default font or margins change.
- final double expectedRatioThreshold = 1.2f;
- double leadingWhitespaceRatio = ((double) leadingWhitespaceColWidth)/noWhitespaceColWidth;
- double trailingWhitespaceRatio = ((double) leadingWhitespaceColWidth)/noWhitespaceColWidth;
-
- assertGreaterThan("leading whitespace is longer than no whitespace",
- leadingWhitespaceRatio, expectedRatioThreshold);
- assertGreaterThan("trailing whitespace is longer than no whitespace",
- trailingWhitespaceRatio, expectedRatioThreshold);
- assertEquals("cells with equal leading and trailing whitespace have equal width",
- leadingWhitespaceColWidth, trailingWhitespaceColWidth);
-
- wb.close();
+ try (Workbook wb = _testDataProvider.createWorkbook()) {
+ Sheet sheet = wb.createSheet();
+ _testDataProvider.trackAllColumnsForAutosizing(sheet);
+ Row row = sheet.createRow(0);
+ Cell cell0 = row.createCell(0);
+ Cell cell1 = row.createCell(1);
+ Cell cell2 = row.createCell(2);
+
+ cell0.setCellValue("Test Column AutoSize");
+ cell1.setCellValue(" Test Column AutoSize");
+ cell2.setCellValue("Test Column AutoSize ");
+
+ sheet.autoSizeColumn(0);
+ sheet.autoSizeColumn(1);
+ sheet.autoSizeColumn(2);
+
+ int noWhitespaceColWidth = sheet.getColumnWidth(0);
+ int leadingWhitespaceColWidth = sheet.getColumnWidth(1);
+ int trailingWhitespaceColWidth = sheet.getColumnWidth(2);
+
+ // Based on the amount of text and whitespace used, and the default font
+ // assume that the cell with whitespace should be at least 20% wider than
+ // the cell without whitespace. This number is arbitrary, but should be large
+ // enough to guarantee that the whitespace cell isn't wider due to chance.
+ // Experimentally, I calculated the ratio as 1.2478181, though this ratio may change
+ // if the default font or margins change.
+ final double expectedRatioThreshold = 1.2f;
+ double leadingWhitespaceRatio = ((double) leadingWhitespaceColWidth) / noWhitespaceColWidth;
+ double trailingWhitespaceRatio = ((double) leadingWhitespaceColWidth) / noWhitespaceColWidth;
+
+ assertGreaterThan("leading whitespace is longer than no whitespace",
+ leadingWhitespaceRatio, expectedRatioThreshold);
+ assertGreaterThan("trailing whitespace is longer than no whitespace",
+ trailingWhitespaceRatio, expectedRatioThreshold);
+ assertEquals("cells with equal leading and trailing whitespace have equal width",
+ leadingWhitespaceColWidth, trailingWhitespaceColWidth);
+
+ }
}
-
+
/**
* Test if a > b. Fails if false.
*/
@@ -484,7 +486,7 @@ public abstract class BaseTestBugzillaIs
}
// FIXME: this function is a self-fulfilling prophecy: this test will always pass as long
- // as the code-under-test and the testcase code are written the same way (have the same bugs).
+ // as the code-under-test and the testcase code are written the same way (have the same bugs).
private double computeCellWidthManually(Cell cell0, Font font) {
final FontRenderContext fontRenderContext = new FontRenderContext(null, true, true);
RichTextString rt = cell0.getRichStringCellValue();
@@ -503,7 +505,7 @@ public abstract class BaseTestBugzillaIs
double frameWidth = getFrameWidth(layout);
return ((frameWidth / 1) / 8);
}
-
+
private double getFrameWidth(TextLayout layout) {
Rectangle2D bounds = layout.getBounds();
return bounds.getX() + bounds.getWidth();
@@ -537,52 +539,52 @@ public abstract class BaseTestBugzillaIs
*/
@Test
public void bug49381() throws IOException {
- Workbook wb = _testDataProvider.createWorkbook();
- int colSplit = 1;
- int rowSplit = 2;
- int leftmostColumn = 3;
- int topRow = 4;
-
- Sheet s = wb.createSheet();
-
- // Populate
- for(int rn=0; rn<= topRow; rn++) {
- Row r = s.createRow(rn);
- for(int cn=0; cn<leftmostColumn; cn++) {
- Cell c = r.createCell(cn, CellType.NUMERIC);
- c.setCellValue(100*rn + cn);
+ try (Workbook wb = _testDataProvider.createWorkbook()) {
+ int colSplit = 1;
+ int rowSplit = 2;
+ int leftmostColumn = 3;
+ int topRow = 4;
+
+ Sheet s = wb.createSheet();
+
+ // Populate
+ for (int rn = 0; rn <= topRow; rn++) {
+ Row r = s.createRow(rn);
+ for (int cn = 0; cn < leftmostColumn; cn++) {
+ Cell c = r.createCell(cn, CellType.NUMERIC);
+ c.setCellValue(100 * rn + cn);
+ }
}
- }
- // Create the Freeze Pane
- s.createFreezePane(colSplit, rowSplit, leftmostColumn, topRow);
- PaneInformation paneInfo = s.getPaneInformation();
-
- // Check it
- assertEquals(colSplit, paneInfo.getVerticalSplitPosition());
- assertEquals(rowSplit, paneInfo.getHorizontalSplitPosition());
- assertEquals(leftmostColumn, paneInfo.getVerticalSplitLeftColumn());
- assertEquals(topRow, paneInfo.getHorizontalSplitTopRow());
-
-
- // Now a row only freezepane
- s.createFreezePane(0, 3);
- paneInfo = s.getPaneInformation();
-
- assertEquals(0, paneInfo.getVerticalSplitPosition());
- assertEquals(3, paneInfo.getHorizontalSplitPosition());
- assertEquals(0, paneInfo.getVerticalSplitLeftColumn());
- assertEquals(3, paneInfo.getHorizontalSplitTopRow());
-
- // Now a column only freezepane
- s.createFreezePane(4, 0);
- paneInfo = s.getPaneInformation();
-
- assertEquals(4, paneInfo.getVerticalSplitPosition());
- assertEquals(0, paneInfo.getHorizontalSplitPosition());
- assertEquals(4 , paneInfo.getVerticalSplitLeftColumn());
- assertEquals(0, paneInfo.getHorizontalSplitTopRow());
- wb.close();
+ // Create the Freeze Pane
+ s.createFreezePane(colSplit, rowSplit, leftmostColumn, topRow);
+ PaneInformation paneInfo = s.getPaneInformation();
+
+ // Check it
+ assertEquals(colSplit, paneInfo.getVerticalSplitPosition());
+ assertEquals(rowSplit, paneInfo.getHorizontalSplitPosition());
+ assertEquals(leftmostColumn, paneInfo.getVerticalSplitLeftColumn());
+ assertEquals(topRow, paneInfo.getHorizontalSplitTopRow());
+
+
+ // Now a row only freezepane
+ s.createFreezePane(0, 3);
+ paneInfo = s.getPaneInformation();
+
+ assertEquals(0, paneInfo.getVerticalSplitPosition());
+ assertEquals(3, paneInfo.getHorizontalSplitPosition());
+ assertEquals(0, paneInfo.getVerticalSplitLeftColumn());
+ assertEquals(3, paneInfo.getHorizontalSplitTopRow());
+
+ // Now a column only freezepane
+ s.createFreezePane(4, 0);
+ paneInfo = s.getPaneInformation();
+
+ assertEquals(4, paneInfo.getVerticalSplitPosition());
+ assertEquals(0, paneInfo.getHorizontalSplitPosition());
+ assertEquals(4, paneInfo.getVerticalSplitLeftColumn());
+ assertEquals(0, paneInfo.getHorizontalSplitTopRow());
+ }
}
/**
@@ -593,23 +595,23 @@ public abstract class BaseTestBugzillaIs
public void bug15353() throws IOException {
String hyperlinkF = "HYPERLINK(\"http://google.com\",\"Google\")";
- Workbook wb1 = _testDataProvider.createWorkbook();
- Sheet sheet = wb1.createSheet("My sheet");
+ try (Workbook wb1 = _testDataProvider.createWorkbook()) {
+ Sheet sheet = wb1.createSheet("My sheet");
- Row row = sheet.createRow(0);
- Cell cell = row.createCell(0);
- cell.setCellFormula(hyperlinkF);
+ Row row = sheet.createRow(0);
+ Cell cell = row.createCell(0);
+ cell.setCellFormula(hyperlinkF);
- assertEquals(hyperlinkF, cell.getCellFormula());
+ assertEquals(hyperlinkF, cell.getCellFormula());
- Workbook wb2 = _testDataProvider.writeOutAndReadBack(wb1);
- wb1.close();
- sheet = wb2.getSheet("My Sheet");
- row = sheet.getRow(0);
- cell = row.getCell(0);
+ try (Workbook wb2 = _testDataProvider.writeOutAndReadBack(wb1)) {
+ sheet = wb2.getSheet("My Sheet");
+ row = sheet.getRow(0);
+ cell = row.getCell(0);
- assertEquals(hyperlinkF, cell.getCellFormula());
- wb2.close();
+ assertEquals(hyperlinkF, cell.getCellFormula());
+ }
+ }
}
/**
@@ -617,106 +619,104 @@ public abstract class BaseTestBugzillaIs
*/
@Test
public void bug51024() throws IOException {
- Workbook wb = _testDataProvider.createWorkbook();
- Sheet s = wb.createSheet();
- Row r1 = s.createRow(0);
- Row r2 = s.createRow(1);
-
- r1.createCell(0).setCellValue("v A1");
- r2.createCell(0).setCellValue("v A2");
- r1.createCell(1).setCellValue("v B1");
+ try (Workbook wb = _testDataProvider.createWorkbook()) {
+ Sheet s = wb.createSheet();
+ Row r1 = s.createRow(0);
+ Row r2 = s.createRow(1);
- Cell c = r1.createCell(4);
+ r1.createCell(0).setCellValue("v A1");
+ r2.createCell(0).setCellValue("v A2");
+ r1.createCell(1).setCellValue("v B1");
- FormulaEvaluator eval = wb.getCreationHelper().createFormulaEvaluator();
+ Cell c = r1.createCell(4);
- c.setCellFormula("VLOOKUP(\"v A1\", A1:B2, 1)");
- assertEquals("v A1", eval.evaluate(c).getStringValue());
+ FormulaEvaluator eval = wb.getCreationHelper().createFormulaEvaluator();
- c.setCellFormula("VLOOKUP(\"v A1\", A1:B2, 1, 1)");
- assertEquals("v A1", eval.evaluate(c).getStringValue());
+ c.setCellFormula("VLOOKUP(\"v A1\", A1:B2, 1)");
+ assertEquals("v A1", eval.evaluate(c).getStringValue());
- c.setCellFormula("VLOOKUP(\"v A1\", A1:B2, 1, )");
- assertEquals("v A1", eval.evaluate(c).getStringValue());
+ c.setCellFormula("VLOOKUP(\"v A1\", A1:B2, 1, 1)");
+ assertEquals("v A1", eval.evaluate(c).getStringValue());
+ c.setCellFormula("VLOOKUP(\"v A1\", A1:B2, 1, )");
+ assertEquals("v A1", eval.evaluate(c).getStringValue());
- c.setCellFormula("HLOOKUP(\"v A1\", A1:B2, 1)");
- assertEquals("v A1", eval.evaluate(c).getStringValue());
- c.setCellFormula("HLOOKUP(\"v A1\", A1:B2, 1, 1)");
- assertEquals("v A1", eval.evaluate(c).getStringValue());
+ c.setCellFormula("HLOOKUP(\"v A1\", A1:B2, 1)");
+ assertEquals("v A1", eval.evaluate(c).getStringValue());
- c.setCellFormula("HLOOKUP(\"v A1\", A1:B2, 1, )");
- assertEquals("v A1", eval.evaluate(c).getStringValue());
+ c.setCellFormula("HLOOKUP(\"v A1\", A1:B2, 1, 1)");
+ assertEquals("v A1", eval.evaluate(c).getStringValue());
- wb.close();
+ c.setCellFormula("HLOOKUP(\"v A1\", A1:B2, 1, )");
+ assertEquals("v A1", eval.evaluate(c).getStringValue());
+ }
}
@Test
public void stackoverflow23114397() throws IOException {
- Workbook wb = _testDataProvider.createWorkbook();
- DataFormat format = wb.getCreationHelper().createDataFormat();
+ try (Workbook wb = _testDataProvider.createWorkbook()) {
+ DataFormat format = wb.getCreationHelper().createDataFormat();
- // How close the sizing should be, given that not all
- // systems will have quite the same fonts on them
- float fontAccuracy = 0.22f;
-
- // x%
- CellStyle iPercent = wb.createCellStyle();
- iPercent.setDataFormat(format.getFormat("0%"));
- // x.x%
- CellStyle d1Percent = wb.createCellStyle();
- d1Percent.setDataFormat(format.getFormat("0.0%"));
- // x.xx%
- CellStyle d2Percent = wb.createCellStyle();
- d2Percent.setDataFormat(format.getFormat("0.00%"));
+ // How close the sizing should be, given that not all
+ // systems will have quite the same fonts on them
+ float fontAccuracy = 0.22f;
+
+ // x%
+ CellStyle iPercent = wb.createCellStyle();
+ iPercent.setDataFormat(format.getFormat("0%"));
+ // x.x%
+ CellStyle d1Percent = wb.createCellStyle();
+ d1Percent.setDataFormat(format.getFormat("0.0%"));
+ // x.xx%
+ CellStyle d2Percent = wb.createCellStyle();
+ d2Percent.setDataFormat(format.getFormat("0.00%"));
+
+ Sheet s = wb.createSheet();
+ _testDataProvider.trackAllColumnsForAutosizing(s);
+ Row r1 = s.createRow(0);
- Sheet s = wb.createSheet();
- _testDataProvider.trackAllColumnsForAutosizing(s);
- Row r1 = s.createRow(0);
+ for (int i = 0; i < 3; i++) {
+ r1.createCell(i, CellType.NUMERIC).setCellValue(0);
+ }
+ for (int i = 3; i < 6; i++) {
+ r1.createCell(i, CellType.NUMERIC).setCellValue(1);
+ }
+ for (int i = 6; i < 9; i++) {
+ r1.createCell(i, CellType.NUMERIC).setCellValue(0.12345);
+ }
+ for (int i = 9; i < 12; i++) {
+ r1.createCell(i, CellType.NUMERIC).setCellValue(1.2345);
+ }
+ for (int i = 0; i < 12; i += 3) {
+ r1.getCell(i).setCellStyle(iPercent);
+ r1.getCell(i + 1).setCellStyle(d1Percent);
+ r1.getCell(i + 2).setCellStyle(d2Percent);
+ }
+ for (int i = 0; i < 12; i++) {
+ s.autoSizeColumn(i);
+ }
- for (int i=0; i<3; i++) {
- r1.createCell(i, CellType.NUMERIC).setCellValue(0);
- }
- for (int i=3; i<6; i++) {
- r1.createCell(i, CellType.NUMERIC).setCellValue(1);
- }
- for (int i=6; i<9; i++) {
- r1.createCell(i, CellType.NUMERIC).setCellValue(0.12345);
+ // Check the 0(.00)% ones
+ assertAlmostEquals(980, s.getColumnWidth(0), fontAccuracy);
+ assertAlmostEquals(1400, s.getColumnWidth(1), fontAccuracy);
+ assertAlmostEquals(1700, s.getColumnWidth(2), fontAccuracy);
+
+ // Check the 100(.00)% ones
+ assertAlmostEquals(1500, s.getColumnWidth(3), fontAccuracy);
+ assertAlmostEquals(1950, s.getColumnWidth(4), fontAccuracy);
+ assertAlmostEquals(2225, s.getColumnWidth(5), fontAccuracy);
+
+ // Check the 12(.34)% ones
+ assertAlmostEquals(1225, s.getColumnWidth(6), fontAccuracy);
+ assertAlmostEquals(1650, s.getColumnWidth(7), fontAccuracy);
+ assertAlmostEquals(1950, s.getColumnWidth(8), fontAccuracy);
+
+ // Check the 123(.45)% ones
+ assertAlmostEquals(1500, s.getColumnWidth(9), fontAccuracy);
+ assertAlmostEquals(1950, s.getColumnWidth(10), fontAccuracy);
+ assertAlmostEquals(2225, s.getColumnWidth(11), fontAccuracy);
}
- for (int i=9; i<12; i++) {
- r1.createCell(i, CellType.NUMERIC).setCellValue(1.2345);
- }
- for (int i=0; i<12; i+=3) {
- r1.getCell(i).setCellStyle(iPercent);
- r1.getCell(i+1).setCellStyle(d1Percent);
- r1.getCell(i+2).setCellStyle(d2Percent);
- }
- for (int i=0; i<12; i++) {
- s.autoSizeColumn(i);
- }
-
- // Check the 0(.00)% ones
- assertAlmostEquals(980, s.getColumnWidth(0), fontAccuracy);
- assertAlmostEquals(1400, s.getColumnWidth(1), fontAccuracy);
- assertAlmostEquals(1700, s.getColumnWidth(2), fontAccuracy);
-
- // Check the 100(.00)% ones
- assertAlmostEquals(1500, s.getColumnWidth(3), fontAccuracy);
- assertAlmostEquals(1950, s.getColumnWidth(4), fontAccuracy);
- assertAlmostEquals(2225, s.getColumnWidth(5), fontAccuracy);
-
- // Check the 12(.34)% ones
- assertAlmostEquals(1225, s.getColumnWidth(6), fontAccuracy);
- assertAlmostEquals(1650, s.getColumnWidth(7), fontAccuracy);
- assertAlmostEquals(1950, s.getColumnWidth(8), fontAccuracy);
-
- // Check the 123(.45)% ones
- assertAlmostEquals(1500, s.getColumnWidth(9), fontAccuracy);
- assertAlmostEquals(1950, s.getColumnWidth(10), fontAccuracy);
- assertAlmostEquals(2225, s.getColumnWidth(11), fontAccuracy);
-
- wb.close();
}
/**
@@ -724,143 +724,143 @@ public abstract class BaseTestBugzillaIs
*/
@Test
public void stackoverflow26437323() throws IOException {
- Workbook wb = _testDataProvider.createWorkbook();
- Sheet s = wb.createSheet();
- Row r1 = s.createRow(0);
- Row r2 = s.createRow(1);
+ try (Workbook wb = _testDataProvider.createWorkbook()) {
+ Sheet s = wb.createSheet();
+ Row r1 = s.createRow(0);
+ Row r2 = s.createRow(1);
- // A1 is a number
- r1.createCell(0).setCellValue(1.1);
- // B1 is a string, with the wanted text in it
- r1.createCell(1).setCellValue("This is text with AM in it");
- // C1 is a string, with different text
- r1.createCell(2).setCellValue("This some other text");
- // D1 is a blank cell
- r1.createCell(3, CellType.BLANK);
- // E1 is null
+ // A1 is a number
+ r1.createCell(0).setCellValue(1.1);
+ // B1 is a string, with the wanted text in it
+ r1.createCell(1).setCellValue("This is text with AM in it");
+ // C1 is a string, with different text
+ r1.createCell(2).setCellValue("This some other text");
+ // D1 is a blank cell
+ r1.createCell(3, CellType.BLANK);
+ // E1 is null
- // A2 will hold our test formulas
- Cell cf = r2.createCell(0, CellType.FORMULA);
+ // A2 will hold our test formulas
+ Cell cf = r2.createCell(0, CellType.FORMULA);
- // First up, check that TRUE and ISLOGICAL both behave
- cf.setCellFormula("TRUE()");
- cf = evaluateCell(wb, cf);
- assertTrue(cf.getBooleanCellValue());
+ // First up, check that TRUE and ISLOGICAL both behave
+ cf.setCellFormula("TRUE()");
+ cf = evaluateCell(wb, cf);
+ assertTrue(cf.getBooleanCellValue());
- cf.setCellFormula("ISLOGICAL(TRUE())");
- cf = evaluateCell(wb, cf);
- assertTrue(cf.getBooleanCellValue());
+ cf.setCellFormula("ISLOGICAL(TRUE())");
+ cf = evaluateCell(wb, cf);
+ assertTrue(cf.getBooleanCellValue());
- cf.setCellFormula("ISLOGICAL(4)");
- cf = evaluateCell(wb, cf);
- assertFalse(cf.getBooleanCellValue());
+ cf.setCellFormula("ISLOGICAL(4)");
+ cf = evaluateCell(wb, cf);
+ assertFalse(cf.getBooleanCellValue());
- // Now, check ISNUMBER / ISTEXT / ISNONTEXT
- cf.setCellFormula("ISNUMBER(A1)");
- cf = evaluateCell(wb, cf);
- assertTrue(cf.getBooleanCellValue());
+ // Now, check ISNUMBER / ISTEXT / ISNONTEXT
+ cf.setCellFormula("ISNUMBER(A1)");
+ cf = evaluateCell(wb, cf);
+ assertTrue(cf.getBooleanCellValue());
- cf.setCellFormula("ISNUMBER(B1)");
- cf = evaluateCell(wb, cf);
- assertFalse(cf.getBooleanCellValue());
+ cf.setCellFormula("ISNUMBER(B1)");
+ cf = evaluateCell(wb, cf);
+ assertFalse(cf.getBooleanCellValue());
- cf.setCellFormula("ISNUMBER(C1)");
- cf = evaluateCell(wb, cf);
- assertFalse(cf.getBooleanCellValue());
+ cf.setCellFormula("ISNUMBER(C1)");
+ cf = evaluateCell(wb, cf);
+ assertFalse(cf.getBooleanCellValue());
- cf.setCellFormula("ISNUMBER(D1)");
- cf = evaluateCell(wb, cf);
- assertFalse(cf.getBooleanCellValue());
+ cf.setCellFormula("ISNUMBER(D1)");
+ cf = evaluateCell(wb, cf);
+ assertFalse(cf.getBooleanCellValue());
- cf.setCellFormula("ISNUMBER(E1)");
- cf = evaluateCell(wb, cf);
- assertFalse(cf.getBooleanCellValue());
+ cf.setCellFormula("ISNUMBER(E1)");
+ cf = evaluateCell(wb, cf);
+ assertFalse(cf.getBooleanCellValue());
- cf.setCellFormula("ISTEXT(A1)");
- cf = evaluateCell(wb, cf);
- assertFalse(cf.getBooleanCellValue());
+ cf.setCellFormula("ISTEXT(A1)");
+ cf = evaluateCell(wb, cf);
+ assertFalse(cf.getBooleanCellValue());
- cf.setCellFormula("ISTEXT(B1)");
- cf = evaluateCell(wb, cf);
- assertTrue(cf.getBooleanCellValue());
+ cf.setCellFormula("ISTEXT(B1)");
+ cf = evaluateCell(wb, cf);
+ assertTrue(cf.getBooleanCellValue());
- cf.setCellFormula("ISTEXT(C1)");
- cf = evaluateCell(wb, cf);
- assertTrue(cf.getBooleanCellValue());
+ cf.setCellFormula("ISTEXT(C1)");
+ cf = evaluateCell(wb, cf);
+ assertTrue(cf.getBooleanCellValue());
- cf.setCellFormula("ISTEXT(D1)");
- cf = evaluateCell(wb, cf);
- assertFalse(cf.getBooleanCellValue());
+ cf.setCellFormula("ISTEXT(D1)");
+ cf = evaluateCell(wb, cf);
+ assertFalse(cf.getBooleanCellValue());
- cf.setCellFormula("ISTEXT(E1)");
- cf = evaluateCell(wb, cf);
- assertFalse(cf.getBooleanCellValue());
+ cf.setCellFormula("ISTEXT(E1)");
+ cf = evaluateCell(wb, cf);
+ assertFalse(cf.getBooleanCellValue());
- cf.setCellFormula("ISNONTEXT(A1)");
- cf = evaluateCell(wb, cf);
- assertTrue(cf.getBooleanCellValue());
+ cf.setCellFormula("ISNONTEXT(A1)");
+ cf = evaluateCell(wb, cf);
+ assertTrue(cf.getBooleanCellValue());
- cf.setCellFormula("ISNONTEXT(B1)");
- cf = evaluateCell(wb, cf);
- assertFalse(cf.getBooleanCellValue());
+ cf.setCellFormula("ISNONTEXT(B1)");
+ cf = evaluateCell(wb, cf);
+ assertFalse(cf.getBooleanCellValue());
- cf.setCellFormula("ISNONTEXT(C1)");
- cf = evaluateCell(wb, cf);
- assertFalse(cf.getBooleanCellValue());
+ cf.setCellFormula("ISNONTEXT(C1)");
+ cf = evaluateCell(wb, cf);
+ assertFalse(cf.getBooleanCellValue());
- cf.setCellFormula("ISNONTEXT(D1)");
- cf = evaluateCell(wb, cf);
- assertTrue(cf.getBooleanCellValue());
+ cf.setCellFormula("ISNONTEXT(D1)");
+ cf = evaluateCell(wb, cf);
+ assertTrue(cf.getBooleanCellValue());
- cf.setCellFormula("ISNONTEXT(E1)");
- cf = evaluateCell(wb, cf);
- assertTrue(cf.getBooleanCellValue()); // Blank and Null the same
+ cf.setCellFormula("ISNONTEXT(E1)");
+ cf = evaluateCell(wb, cf);
+ assertTrue(cf.getBooleanCellValue()); // Blank and Null the same
- // Next up, SEARCH on its own
- cf.setCellFormula("SEARCH(\"am\", A1)");
- cf = evaluateCell(wb, cf);
- assertEquals(FormulaError.VALUE.getCode(), cf.getErrorCellValue());
+ // Next up, SEARCH on its own
+ cf.setCellFormula("SEARCH(\"am\", A1)");
+ cf = evaluateCell(wb, cf);
+ assertEquals(FormulaError.VALUE.getCode(), cf.getErrorCellValue());
- cf.setCellFormula("SEARCH(\"am\", B1)");
- cf = evaluateCell(wb, cf);
- assertEquals(19, (int)cf.getNumericCellValue());
+ cf.setCellFormula("SEARCH(\"am\", B1)");
+ cf = evaluateCell(wb, cf);
+ assertEquals(19, (int) cf.getNumericCellValue());
- cf.setCellFormula("SEARCH(\"am\", C1)");
- cf = evaluateCell(wb, cf);
- assertEquals(FormulaError.VALUE.getCode(), cf.getErrorCellValue());
+ cf.setCellFormula("SEARCH(\"am\", C1)");
+ cf = evaluateCell(wb, cf);
+ assertEquals(FormulaError.VALUE.getCode(), cf.getErrorCellValue());
- cf.setCellFormula("SEARCH(\"am\", D1)");
- cf = evaluateCell(wb, cf);
- assertEquals(FormulaError.VALUE.getCode(), cf.getErrorCellValue());
+ cf.setCellFormula("SEARCH(\"am\", D1)");
+ cf = evaluateCell(wb, cf);
+ assertEquals(FormulaError.VALUE.getCode(), cf.getErrorCellValue());
- // Finally, bring it all together
- cf.setCellFormula("ISNUMBER(SEARCH(\"am\", A1))");
- cf = evaluateCell(wb, cf);
- assertFalse(cf.getBooleanCellValue());
+ // Finally, bring it all together
+ cf.setCellFormula("ISNUMBER(SEARCH(\"am\", A1))");
+ cf = evaluateCell(wb, cf);
+ assertFalse(cf.getBooleanCellValue());
- cf.setCellFormula("ISNUMBER(SEARCH(\"am\", B1))");
- cf = evaluateCell(wb, cf);
- assertTrue(cf.getBooleanCellValue());
+ cf.setCellFormula("ISNUMBER(SEARCH(\"am\", B1))");
+ cf = evaluateCell(wb, cf);
+ assertTrue(cf.getBooleanCellValue());
- cf.setCellFormula("ISNUMBER(SEARCH(\"am\", C1))");
- cf = evaluateCell(wb, cf);
- assertFalse(cf.getBooleanCellValue());
+ cf.setCellFormula("ISNUMBER(SEARCH(\"am\", C1))");
+ cf = evaluateCell(wb, cf);
+ assertFalse(cf.getBooleanCellValue());
- cf.setCellFormula("ISNUMBER(SEARCH(\"am\", D1))");
- cf = evaluateCell(wb, cf);
- assertFalse(cf.getBooleanCellValue());
+ cf.setCellFormula("ISNUMBER(SEARCH(\"am\", D1))");
+ cf = evaluateCell(wb, cf);
+ assertFalse(cf.getBooleanCellValue());
- cf.setCellFormula("ISNUMBER(SEARCH(\"am\", E1))");
- cf = evaluateCell(wb, cf);
- assertFalse(cf.getBooleanCellValue());
+ cf.setCellFormula("ISNUMBER(SEARCH(\"am\", E1))");
+ cf = evaluateCell(wb, cf);
+ assertFalse(cf.getBooleanCellValue());
- wb.close();
+ }
}
private Cell evaluateCell(Workbook wb, Cell c) {
@@ -958,48 +958,48 @@ public abstract class BaseTestBugzillaIs
@Test
public void test56574OverwriteExistingRow() throws IOException {
- Workbook wb = _testDataProvider.createWorkbook();
- Sheet sheet = wb.createSheet();
+ try (Workbook wb = _testDataProvider.createWorkbook()) {
+ Sheet sheet = wb.createSheet();
- { // create the Formula-Cell
- Row row = sheet.createRow(0);
- Cell cell = row.createCell(0);
- cell.setCellFormula("A2");
- }
+ { // create the Formula-Cell
+ Row row = sheet.createRow(0);
+ Cell cell = row.createCell(0);
+ cell.setCellFormula("A2");
+ }
- { // check that it is there now
- Row row = sheet.getRow(0);
+ { // check that it is there now
+ Row row = sheet.getRow(0);
/* CTCell[] cArray = ((XSSFRow)row).getCTRow().getCArray();
assertEquals(1, cArray.length);*/
- Cell cell = row.getCell(0);
- assertEquals(CellType.FORMULA, cell.getCellType());
- }
+ Cell cell = row.getCell(0);
+ assertEquals(CellType.FORMULA, cell.getCellType());
+ }
- { // overwrite the row
- Row row = sheet.createRow(0);
- assertNotNull(row);
- }
+ { // overwrite the row
+ Row row = sheet.createRow(0);
+ assertNotNull(row);
+ }
- { // creating a row in place of another should remove the existing data,
- // check that the cell is gone now
- Row row = sheet.getRow(0);
+ { // creating a row in place of another should remove the existing data,
+ // check that the cell is gone now
+ Row row = sheet.getRow(0);
/*CTCell[] cArray = ((XSSFRow)row).getCTRow().getCArray();
assertEquals(0, cArray.length);*/
- Cell cell = row.getCell(0);
- assertNull(cell);
- }
+ Cell cell = row.getCell(0);
+ assertNull(cell);
+ }
- // the calculation chain in XSSF is empty in a newly created workbook, so we cannot check if it is correctly updated
+ // the calculation chain in XSSF is empty in a newly created workbook, so we cannot check if it is correctly updated
/*assertNull(((XSSFWorkbook)wb).getCalculationChain());
assertNotNull(((XSSFWorkbook)wb).getCalculationChain().getCTCalcChain());
assertNotNull(((XSSFWorkbook)wb).getCalculationChain().getCTCalcChain().getCArray());
assertEquals(0, ((XSSFWorkbook)wb).getCalculationChain().getCTCalcChain().getCArray().length);*/
- wb.close();
+ }
}
/**
@@ -1011,122 +1011,114 @@ public abstract class BaseTestBugzillaIs
*/
@Test
public void bug48718() throws IOException {
- Workbook wb = _testDataProvider.createWorkbook();
- int startingFonts = wb instanceof HSSFWorkbook ? 4 : 1;
+ try (Workbook wb = _testDataProvider.createWorkbook()) {
+ int startingFonts = wb instanceof HSSFWorkbook ? 4 : 1;
- assertEquals(startingFonts, wb.getNumberOfFontsAsInt());
+ assertEquals(startingFonts, wb.getNumberOfFontsAsInt());
- // Get a font, and slightly change it
- Font a = wb.createFont();
- assertEquals(startingFonts+1, wb.getNumberOfFontsAsInt());
- a.setFontHeightInPoints((short)23);
- assertEquals(startingFonts+1, wb.getNumberOfFontsAsInt());
-
- // Get two more, unchanged
- /*Font b =*/ wb.createFont();
- assertEquals(startingFonts+2, wb.getNumberOfFontsAsInt());
- /*Font c =*/ wb.createFont();
- assertEquals(startingFonts+3, wb.getNumberOfFontsAsInt());
-
- wb.close();
+ // Get a font, and slightly change it
+ Font a = wb.createFont();
+ assertEquals(startingFonts + 1, wb.getNumberOfFontsAsInt());
+ a.setFontHeightInPoints((short) 23);
+ assertEquals(startingFonts + 1, wb.getNumberOfFontsAsInt());
+
+ // Get two more, unchanged
+ /*Font b =*/
+ wb.createFont();
+ assertEquals(startingFonts + 2, wb.getNumberOfFontsAsInt());
+ /*Font c =*/
+ wb.createFont();
+ assertEquals(startingFonts + 3, wb.getNumberOfFontsAsInt());
+ }
}
@Test
public void bug57430() throws IOException {
- Workbook wb = _testDataProvider.createWorkbook();
- wb.createSheet("Sheet1");
+ try (Workbook wb = _testDataProvider.createWorkbook()) {
+ wb.createSheet("Sheet1");
- Name name1 = wb.createName();
- name1.setNameName("FMLA");
- name1.setRefersToFormula("Sheet1!$B$3");
- wb.close();
+ Name name1 = wb.createName();
+ name1.setNameName("FMLA");
+ name1.setRefersToFormula("Sheet1!$B$3");
+ }
}
@Test
public void bug56981() throws IOException {
- Workbook wb = _testDataProvider.createWorkbook();
- CellStyle vertTop = wb.createCellStyle();
- vertTop.setVerticalAlignment(VerticalAlignment.TOP);
- CellStyle vertBottom = wb.createCellStyle();
- vertBottom.setVerticalAlignment(VerticalAlignment.BOTTOM);
- Sheet sheet = wb.createSheet("Sheet 1");
- Row row = sheet.createRow(0);
- Cell top = row.createCell(0);
- Cell bottom = row.createCell(1);
- top.setCellValue("Top");
- top.setCellStyle(vertTop); // comment this out to get all bottom-aligned
- // cells
- bottom.setCellValue("Bottom");
- bottom.setCellStyle(vertBottom);
- row.setHeightInPoints(85.75f); // make it obvious
-
- /*FileOutputStream out = new FileOutputStream("c:\\temp\\56981.xlsx");
- try {
- wb.write(out);
- } finally {
- out.close();
- }*/
-
- wb.close();
+ try (Workbook wb = _testDataProvider.createWorkbook()) {
+ CellStyle vertTop = wb.createCellStyle();
+ vertTop.setVerticalAlignment(VerticalAlignment.TOP);
+ CellStyle vertBottom = wb.createCellStyle();
+ vertBottom.setVerticalAlignment(VerticalAlignment.BOTTOM);
+ Sheet sheet = wb.createSheet("Sheet 1");
+ Row row = sheet.createRow(0);
+ Cell top = row.createCell(0);
+ Cell bottom = row.createCell(1);
+ top.setCellValue("Top");
+ top.setCellStyle(vertTop); // comment this out to get all bottom-aligned
+ // cells
+ bottom.setCellValue("Bottom");
+ bottom.setCellStyle(vertBottom);
+ row.setHeightInPoints(85.75f); // make it obvious
+ }
}
@Test
public void test57973() throws IOException {
- Workbook wb = _testDataProvider.createWorkbook();
-
- CreationHelper factory = wb.getCreationHelper();
+ try (Workbook wb = _testDataProvider.createWorkbook()) {
- Sheet sheet = wb.createSheet();
- Drawing<?> drawing = sheet.createDrawingPatriarch();
- ClientAnchor anchor = factory.createClientAnchor();
-
- Cell cell0 = sheet.createRow(0).createCell(0);
- cell0.setCellValue("Cell0");
-
- Comment comment0 = drawing.createCellComment(anchor);
- RichTextString str0 = factory.createRichTextString("Hello, World1!");
- comment0.setString(str0);
- comment0.setAuthor("Apache POI");
- cell0.setCellComment(comment0);
-
- anchor = factory.createClientAnchor();
- anchor.setCol1(1);
- anchor.setCol2(1);
- anchor.setRow1(1);
- anchor.setRow2(1);
- Cell cell1 = sheet.createRow(3).createCell(5);
- cell1.setCellValue("F4");
- Comment comment1 = drawing.createCellComment(anchor);
- RichTextString str1 = factory.createRichTextString("Hello, World2!");
- comment1.setString(str1);
- comment1.setAuthor("Apache POI");
- cell1.setCellComment(comment1);
-
- Cell cell2 = sheet.createRow(2).createCell(2);
- cell2.setCellValue("C3");
-
- anchor = factory.createClientAnchor();
- anchor.setCol1(2);
- anchor.setCol2(2);
- anchor.setRow1(2);
- anchor.setRow2(2);
-
- Comment comment2 = drawing.createCellComment(anchor);
- RichTextString str2 = factory.createRichTextString("XSSF can set cell comments");
- //apply custom font to the text in the comment
- Font font = wb.createFont();
- font.setFontName("Arial");
- font.setFontHeightInPoints((short)14);
- font.setBold(true);
- font.setColor(IndexedColors.RED.getIndex());
- str2.applyFont(font);
-
- comment2.setString(str2);
- comment2.setAuthor("Apache POI");
- comment2.setColumn(2);
- comment2.setRow(2);
+ CreationHelper factory = wb.getCreationHelper();
- wb.close();
+ Sheet sheet = wb.createSheet();
+ Drawing<?> drawing = sheet.createDrawingPatriarch();
+ ClientAnchor anchor = factory.createClientAnchor();
+
+ Cell cell0 = sheet.createRow(0).createCell(0);
+ cell0.setCellValue("Cell0");
+
+ Comment comment0 = drawing.createCellComment(anchor);
+ RichTextString str0 = factory.createRichTextString("Hello, World1!");
+ comment0.setString(str0);
+ comment0.setAuthor("Apache POI");
+ cell0.setCellComment(comment0);
+
+ anchor = factory.createClientAnchor();
+ anchor.setCol1(1);
+ anchor.setCol2(1);
+ anchor.setRow1(1);
+ anchor.setRow2(1);
+ Cell cell1 = sheet.createRow(3).createCell(5);
+ cell1.setCellValue("F4");
+ Comment comment1 = drawing.createCellComment(anchor);
+ RichTextString str1 = factory.createRichTextString("Hello, World2!");
+ comment1.setString(str1);
+ comment1.setAuthor("Apache POI");
+ cell1.setCellComment(comment1);
+
+ Cell cell2 = sheet.createRow(2).createCell(2);
+ cell2.setCellValue("C3");
+
+ anchor = factory.createClientAnchor();
+ anchor.setCol1(2);
+ anchor.setCol2(2);
+ anchor.setRow1(2);
+ anchor.setRow2(2);
+
+ Comment comment2 = drawing.createCellComment(anchor);
+ RichTextString str2 = factory.createRichTextString("XSSF can set cell comments");
+ //apply custom font to the text in the comment
+ Font font = wb.createFont();
+ font.setFontName("Arial");
+ font.setFontHeightInPoints((short) 14);
+ font.setBold(true);
+ font.setColor(IndexedColors.RED.getIndex());
+ str2.applyFont(font);
+
+ comment2.setString(str2);
+ comment2.setAuthor("Apache POI");
+ comment2.setColumn(2);
+ comment2.setRow(2);
+ }
}
/**
@@ -1136,108 +1128,106 @@ public abstract class BaseTestBugzillaIs
*/
@Test
public void bug47815() throws IOException {
- Workbook wb = _testDataProvider.createWorkbook();
- Sheet s = wb.createSheet();
- Row r = s.createRow(0);
-
- // Setup
- Cell cn = r.createCell(0, CellType.NUMERIC);
- cn.setCellValue(1.2);
- Cell cs = r.createCell(1, CellType.STRING);
- cs.setCellValue("Testing");
-
- Cell cfn = r.createCell(2, CellType.FORMULA);
- cfn.setCellFormula("A1");
- Cell cfs = r.createCell(3, CellType.FORMULA);
- cfs.setCellFormula("B1");
-
- FormulaEvaluator fe = wb.getCreationHelper().createFormulaEvaluator();
- assertEquals(CellType.NUMERIC, fe.evaluate(cfn).getCellType());
- assertEquals(CellType.STRING, fe.evaluate(cfs).getCellType());
- fe.evaluateFormulaCell(cfn);
- fe.evaluateFormulaCell(cfs);
-
- // Now test
- assertEquals(CellType.NUMERIC, cn.getCellType());
- assertEquals(CellType.STRING, cs.getCellType());
- assertEquals(CellType.FORMULA, cfn.getCellType());
- assertEquals(CellType.NUMERIC, cfn.getCachedFormulaResultType());
- assertEquals(CellType.FORMULA, cfs.getCellType());
- assertEquals(CellType.STRING, cfs.getCachedFormulaResultType());
+ try (Workbook wb = _testDataProvider.createWorkbook()) {
+ Sheet s = wb.createSheet();
+ Row r = s.createRow(0);
- // Different ways of retrieving
- assertEquals(1.2, cn.getNumericCellValue(), 0);
- try {
- cn.getRichStringCellValue();
- fail();
- } catch(IllegalStateException e) {
- // expected here
- }
+ // Setup
+ Cell cn = r.createCell(0, CellType.NUMERIC);
+ cn.setCellValue(1.2);
+ Cell cs = r.createCell(1, CellType.STRING);
+ cs.setCellValue("Testing");
+
+ Cell cfn = r.createCell(2, CellType.FORMULA);
+ cfn.setCellFormula("A1");
+ Cell cfs = r.createCell(3, CellType.FORMULA);
+ cfs.setCellFormula("B1");
+
+ FormulaEvaluator fe = wb.getCreationHelper().createFormulaEvaluator();
+ assertEquals(CellType.NUMERIC, fe.evaluate(cfn).getCellType());
+ assertEquals(CellType.STRING, fe.evaluate(cfs).getCellType());
+ fe.evaluateFormulaCell(cfn);
+ fe.evaluateFormulaCell(cfs);
+
+ // Now test
+ assertEquals(CellType.NUMERIC, cn.getCellType());
+ assertEquals(CellType.STRING, cs.getCellType());
+ assertEquals(CellType.FORMULA, cfn.getCellType());
+ assertEquals(CellType.NUMERIC, cfn.getCachedFormulaResultType());
+ assertEquals(CellType.FORMULA, cfs.getCellType());
+ assertEquals(CellType.STRING, cfs.getCachedFormulaResultType());
- assertEquals("Testing", cs.getStringCellValue());
- try {
- cs.getNumericCellValue();
- fail();
- } catch(IllegalStateException e) {
- // expected here
- }
+ // Different ways of retrieving
+ assertEquals(1.2, cn.getNumericCellValue(), 0);
+ try {
+ cn.getRichStringCellValue();
+ fail();
+ } catch (IllegalStateException e) {
+ // expected here
+ }
- assertEquals(1.2, cfn.getNumericCellValue(), 0);
- try {
- cfn.getRichStringCellValue();
- fail();
- } catch(IllegalStateException e) {
- // expected here
- }
+ assertEquals("Testing", cs.getStringCellValue());
+ try {
+ cs.getNumericCellValue();
+ fail();
+ } catch (IllegalStateException e) {
+ // expected here
+ }
- assertEquals("Testing", cfs.getStringCellValue());
- try {
- cfs.getNumericCellValue();
- fail();
- } catch(IllegalStateException e) {
- // expected here
+ assertEquals(1.2, cfn.getNumericCellValue(), 0);
+ try {
+ cfn.getRichStringCellValue();
+ fail();
+ } catch (IllegalStateException e) {
+ // expected here
+ }
+
+ assertEquals("Testing", cfs.getStringCellValue());
+ try {
+ cfs.getNumericCellValue();
+ fail();
+ } catch (IllegalStateException e) {
+ // expected here
+ }
}
-
- wb.close();
}
@Test
public void test58113() throws IOException {
- Workbook wb = _testDataProvider.createWorkbook();
- Sheet sheet = wb.createSheet( "Test" );
+ try (Workbook wb = _testDataProvider.createWorkbook()) {
+ Sheet sheet = wb.createSheet("Test");
+
+ Row row = sheet.createRow(0);
- Row row = sheet.createRow(0);
+ Cell cell = row.createCell(0);
+ // verify that null-values can be set, this was possible up to 3.11, but broken in 3.12
+ cell.setCellValue((String) null);
+ String value = cell.getStringCellValue();
+ assertTrue("HSSF will currently return empty string, XSSF/SXSSF will return null, but had: " + value,
+ value == null || value.length() == 0);
+
+ cell = row.createCell(1);
+ cell.setCellFormula("0");
+ cell.setCellValue((String) null);
- Cell cell = row.createCell(0);
- // verify that null-values can be set, this was possible up to 3.11, but broken in 3.12
- cell.setCellValue((String)null);
- String value = cell.getStringCellValue();
- assertTrue("HSSF will currently return empty string, XSSF/SXSSF will return null, but had: " + value,
- value == null || value.length() == 0);
-
- cell = row.createCell(1);
- cell.setCellFormula("0");
- cell.setCellValue((String)null);
-
- wb.getCreationHelper().createFormulaEvaluator().evaluateAll();
-
- value = cell.getStringCellValue();
- assertTrue("HSSF will currently return empty string, XSSF/SXSSF will return null, but had: " + value,
- value == null || value.length() == 0);
-
- // set some value
- cell.setCellValue("somevalue");
-
- value = cell.getStringCellValue();
- assertEquals("can set value afterwards: " + value, "somevalue", value);
-
- // verify that the null-value is actually set even if there was some value in the cell before
- cell.setCellValue((String)null);
- value = cell.getStringCellValue();
- assertTrue("HSSF will currently return empty string, XSSF/SXSSF will return null, but had: " + value,
- value == null || value.length() == 0);
-
- wb.close();
+ wb.getCreationHelper().createFormulaEvaluator().evaluateAll();
+
+ value = cell.getStringCellValue();
+ assertTrue("HSSF will currently return empty string, XSSF/SXSSF will return null, but had: " + value,
+ value == null || value.length() == 0);
+
+ // set some value
+ cell.setCellValue("somevalue");
+
+ value = cell.getStringCellValue();
+ assertEquals("can set value afterwards: " + value, "somevalue", value);
+
+ // verify that the null-value is actually set even if there was some value in the cell before
+ cell.setCellValue((String) null);
+ value = cell.getStringCellValue();
+ assertTrue("HSSF will currently return empty string, XSSF/SXSSF will return null, but had: " + value,
+ value == null || value.length() == 0);
+ }
}
/**
@@ -1246,277 +1236,268 @@ public abstract class BaseTestBugzillaIs
*/
@Test
public void bug55747() throws IOException {
- Workbook wb1 = _testDataProvider.createWorkbook();
- FormulaEvaluator ev = wb1.getCreationHelper().createFormulaEvaluator();
- Sheet s = wb1.createSheet();
-
- Row row = s.createRow(0);
- row.createCell(0).setCellValue("abc");
- row.createCell(1).setCellValue("");
- row.createCell(2).setCellValue(3);
-
- Cell cell = row.createCell(5);
- cell.setCellFormula("IF(A1<>\"\",MID(A1,1,2),\" \")");
- ev.evaluateAll();
- assertEquals("ab", cell.getStringCellValue());
-
- cell = row.createCell(6);
- cell.setCellFormula("IF(B1<>\"\",MID(A1,1,2),\"empty\")");
- ev.evaluateAll();
- assertEquals("empty", cell.getStringCellValue());
-
- cell = row.createCell(7);
- cell.setCellFormula("IF(A1<>\"\",IF(C1<>\"\",MID(A1,1,2),\"c1\"),\"c2\")");
- ev.evaluateAll();
- assertEquals("ab", cell.getStringCellValue());
-
- // Write it back out, and re-read
- Workbook wb2 = _testDataProvider.writeOutAndReadBack(wb1);
- wb1.close();
- ev = wb2.getCreationHelper().createFormulaEvaluator();
- s = wb2.getSheetAt(0);
- row = s.getRow(0);
-
- // Check read ok, and re-evaluate fine
- cell = row.getCell(5);
- assertEquals("ab", cell.getStringCellValue());
- assertEquals(CellType.FORMULA, cell.getCellType());
- assertEquals("IF(A1<>\"\",MID(A1,1,2),\" \")", cell.getCellFormula());
- ev.evaluateFormulaCell(cell);
- assertEquals("ab", cell.getStringCellValue());
- assertEquals(CellType.FORMULA, cell.getCellType());
- assertEquals("IF(A1<>\"\",MID(A1,1,2),\" \")", cell.getCellFormula());
-
- cell = row.getCell(6);
- assertEquals("empty", cell.getStringCellValue());
- assertEquals(CellType.FORMULA, cell.getCellType());
- assertEquals("IF(B1<>\"\",MID(A1,1,2),\"empty\")", cell.getCellFormula());
- ev.evaluateFormulaCell(cell);
- assertEquals("empty", cell.getStringCellValue());
- assertEquals(CellType.FORMULA, cell.getCellType());
- assertEquals("IF(B1<>\"\",MID(A1,1,2),\"empty\")", cell.getCellFormula());
-
- cell = row.getCell(7);
- assertEquals("ab", cell.getStringCellValue());
- assertEquals(CellType.FORMULA, cell.getCellType());
- assertEquals("IF(A1<>\"\",IF(C1<>\"\",MID(A1,1,2),\"c1\"),\"c2\")", cell.getCellFormula());
- ev.evaluateFormulaCell(cell);
- assertEquals("ab", cell.getStringCellValue());
- assertEquals(CellType.FORMULA, cell.getCellType());
- assertEquals("IF(A1<>\"\",IF(C1<>\"\",MID(A1,1,2),\"c1\"),\"c2\")", cell.getCellFormula());
- wb2.close();
+ try (Workbook wb1 = _testDataProvider.createWorkbook()) {
+ FormulaEvaluator ev = wb1.getCreationHelper().createFormulaEvaluator();
+ Sheet s = wb1.createSheet();
+
+ Row row = s.createRow(0);
+ row.createCell(0).setCellValue("abc");
+ row.createCell(1).setCellValue("");
+ row.createCell(2).setCellValue(3);
+
+ Cell cell = row.createCell(5);
+ cell.setCellFormula("IF(A1<>\"\",MID(A1,1,2),\" \")");
+ ev.evaluateAll();
+ assertEquals("ab", cell.getStringCellValue());
+
+ cell = row.createCell(6);
+ cell.setCellFormula("IF(B1<>\"\",MID(A1,1,2),\"empty\")");
+ ev.evaluateAll();
+ assertEquals("empty", cell.getStringCellValue());
+
+ cell = row.createCell(7);
+ cell.setCellFormula("IF(A1<>\"\",IF(C1<>\"\",MID(A1,1,2),\"c1\"),\"c2\")");
+ ev.evaluateAll();
+ assertEquals("ab", cell.getStringCellValue());
+
+ // Write it back out, and re-read
+ try (Workbook wb2 = _testDataProvider.writeOutAndReadBack(wb1)) {
+ ev = wb2.getCreationHelper().createFormulaEvaluator();
+ s = wb2.getSheetAt(0);
+ row = s.getRow(0);
+
+ // Check read ok, and re-evaluate fine
+ cell = row.getCell(5);
+ assertEquals("ab", cell.getStringCellValue());
+ assertEquals(CellType.FORMULA, cell.getCellType());
+ assertEquals("IF(A1<>\"\",MID(A1,1,2),\" \")", cell.getCellFormula());
+ ev.evaluateFormulaCell(cell);
+ assertEquals("ab", cell.getStringCellValue());
+ assertEquals(CellType.FORMULA, cell.getCellType());
+ assertEquals("IF(A1<>\"\",MID(A1,1,2),\" \")", cell.getCellFormula());
+
+ cell = row.getCell(6);
+ assertEquals("empty", cell.getStringCellValue());
+ assertEquals(CellType.FORMULA, cell.getCellType());
+ assertEquals("IF(B1<>\"\",MID(A1,1,2),\"empty\")", cell.getCellFormula());
+ ev.evaluateFormulaCell(cell);
+ assertEquals("empty", cell.getStringCellValue());
+ assertEquals(CellType.FORMULA, cell.getCellType());
+ assertEquals("IF(B1<>\"\",MID(A1,1,2),\"empty\")", cell.getCellFormula());
+
+ cell = row.getCell(7);
+ assertEquals("ab", cell.getStringCellValue());
+ assertEquals(CellType.FORMULA, cell.getCellType());
+ assertEquals("IF(A1<>\"\",IF(C1<>\"\",MID(A1,1,2),\"c1\"),\"c2\")", cell.getCellFormula());
+ ev.evaluateFormulaCell(cell);
+ assertEquals("ab", cell.getStringCellValue());
+ assertEquals(CellType.FORMULA, cell.getCellType());
+ assertEquals("IF(A1<>\"\",IF(C1<>\"\",MID(A1,1,2),\"c1\"),\"c2\")", cell.getCellFormula());
+ }
+ }
}
@Test
public void bug58260() throws IOException {
//Create workbook and worksheet
- Workbook wb = _testDataProvider.createWorkbook();
- //Sheet worksheet = wb.createSheet("sample");
+ try (Workbook wb = _testDataProvider.createWorkbook()) {
+ //Sheet worksheet = wb.createSheet("sample");
+
+ //Loop through and add all values from array list
+ // use a fixed seed to always produce the same file which makes comparing stuff easier
+ //Random rnd = new Random(4352345);
+ int maxStyles = (wb instanceof HSSFWorkbook) ? 4009 : 64000;
+ for (int i = 0; i < maxStyles; i++) {
+ //Create new row
+ //Row row = worksheet.createRow(i);
+
+ //Create cell style
+ CellStyle style = null;
+ try {
+ style = wb.createCellStyle();
+ } catch (IllegalStateException e) {
+ fail("Failed for row " + i);
+ }
+ style.setAlignment(HorizontalAlignment.RIGHT);
+ if ((wb instanceof HSSFWorkbook)) {
+ // there are some predefined styles
+ assertEquals(i + 21, style.getIndex());
+ } else {
+ // getIndex() returns short, which is not sufficient for > 32767
+ // we should really change the API to be "int" for getIndex() but
+ // that needs API changes
+ assertEquals(i + 1, style.getIndex() & 0xffff);
+ }
+
+ //Create cell
+ //Cell cell = row.createCell(0);
- //Loop through and add all values from array list
- // use a fixed seed to always produce the same file which makes comparing stuff easier
- //Random rnd = new Random(4352345);
- int maxStyles = (wb instanceof HSSFWorkbook) ? 4009 : 64000;
- for(int i = 0;i < maxStyles;i++) {
- //Create new row
- //Row row = worksheet.createRow(i);
+ //Set cell style
+ //cell.setCellStyle(style);
+
+ //Set cell value
+ //cell.setCellValue("r" + rnd.nextInt());
+ }
- //Create cell style
- CellStyle style = null;
+ // should fail if we try to add more now
try {
- style = wb.createCellStyle();
+ wb.createCellStyle();
+ fail("Should fail after " + maxStyles + " styles, but did not fail");
} catch (IllegalStateException e) {
- fail("Failed for row " + i);
- }
- style.setAlignment(HorizontalAlignment.RIGHT);
- if((wb instanceof HSSFWorkbook)) {
- // there are some predefined styles
- assertEquals(i+21, style.getIndex());
- } else {
- // getIndex() returns short, which is not sufficient for > 32767
- // we should really change the API to be "int" for getIndex() but
- // that needs API changes
- assertEquals(i+1, style.getIndex() & 0xffff);
+ // expected here
}
- //Create cell
- //Cell cell = row.createCell(0);
+ /*//add column width for appearance sake
+ worksheet.setColumnWidth(0, 5000);
- //Set cell style
- //cell.setCellStyle(style);
+ // Write the output to a file
+ System.out.println("Writing...");
+ OutputStream fileOut = new FileOutputStream("C:\\temp\\58260." + _testDataProvider.getStandardFileNameExtension());
- //Set cell value
- //cell.setCellValue("r" + rnd.nextInt());
- }
+ // the resulting file can be compressed nicely, so we need to disable the zip bomb detection here
+ double before = ZipSecureFile.getMinInflateRatio();
+ try {
+ ZipSecureFile.setMinInflateRatio(0.00001);
+ wb.write(fileOut);
+ } finally {
+ fileOut.close();
+ ZipSecureFile.setMinInflateRatio(before);
+ }*/
- // should fail if we try to add more now
- try {
- wb.createCellStyle();
- fail("Should fail after " + maxStyles + " styles, but did not fail");
- } catch (IllegalStateException e) {
- // expected here
}
-
- /*//add column width for appearance sake
- worksheet.setColumnWidth(0, 5000);
-
- // Write the output to a file
- System.out.println("Writing...");
- OutputStream fileOut = new FileOutputStream("C:\\temp\\58260." + _testDataProvider.getStandardFileNameExtension());
-
- // the resulting file can be compressed nicely, so we need to disable the zip bomb detection here
- double before = ZipSecureFile.getMinInflateRatio();
- try {
- ZipSecureFile.setMinInflateRatio(0.00001);
- wb.write(fileOut);
- } finally {
- fileOut.close();
- ZipSecureFile.setMinInflateRatio(before);
- }*/
-
- wb.close();
}
@Test
public void test50319() throws IOException {
- Workbook wb = new HSSFWorkbook();
- Sheet sheet = wb.createSheet("Test");
- sheet.createRow(0);
- sheet.groupRow(0, 0);
- sheet.setRowGroupCollapsed(0, true);
-
- sheet.groupColumn(0, 0);
- sheet.setColumnGroupCollapsed(0, true);
-
- wb.close();
+ try (Workbook wb = new HSSFWorkbook()) {
+ Sheet sheet = wb.createSheet("Test");
+ sheet.createRow(0);
+ sheet.groupRow(0, 0);
+ sheet.setRowGroupCollapsed(0, true);
+
+ sheet.groupColumn(0, 0);
+ sheet.setColumnGroupCollapsed(0, true);
+ }
}
-
+
// Bug 58648: FormulaParser throws exception in parseSimpleFactor() when getCellFormula()
// is called on a cell and the formula contains spaces between closing parentheses ") )"
- // https://bz.apache.org/bugzilla/show_bug.cgi?id=58648
@Test
public void test58648() throws IOException {
- Workbook wb = _testDataProvider.createWorkbook();
- Cell cell = wb.createSheet().createRow(0).createCell(0);
- cell.setCellFormula("((1 + 1) )");
- // fails with
- // org.apache.poi.ss.formula.FormulaParseException: Parse error near char ... ')'
- // in specified formula '((1 + 1) )'. Expected cell ref or constant literal
-
- wb.close();
+ try (Workbook wb = _testDataProvider.createWorkbook()) {
+ Cell cell = wb.createSheet().createRow(0).createCell(0);
+ cell.setCellFormula("((1 + 1) )");
+ }
}
-
+
/**
* If someone sets a null string as a cell value, treat
* it as an empty cell, and avoid a NPE on auto-sizing
*/
@Test
public void test57034() throws Exception {
- Workbook wb = _testDataProvider.createWorkbook();
- Sheet s = wb.createSheet();
- Cell cell = s.createRow(0).createCell(0);
- cell.setCellValue((String)null);
- assertEquals(CellType.BLANK, cell.getCellType());
-
- _testDataProvider.trackAllColumnsForAutosizing(s);
-
- s.autoSizeColumn(0);
- assertEquals(2048, s.getColumnWidth(0));
+ try (Workbook wb = _testDataProvider.createWorkbook()) {
+ Sheet s = wb.createSheet();
+ Cell cell = s.createRow(0).createCell(0);
+ cell.setCellValue((String) null);
+ assertEquals(CellType.BLANK, cell.getCellType());
+
+ _testDataProvider.trackAllColumnsForAutosizing(s);
- s.autoSizeColumn(0, true);
- assertEquals(2048, s.getColumnWidth(0));
+ s.autoSizeColumn(0);
+ assertEquals(2048, s.getColumnWidth(0));
- wb.close();
+ s.autoSizeColumn(0, true);
+ assertEquals(2048, s.getColumnWidth(0));
+ }
}
@Test
public void test52684() throws IOException {
- Workbook wb = _testDataProvider.createWorkbook();
-
- Sheet sheet = wb.createSheet("test");
- Row row = sheet.createRow(0);
- Cell cell = row.createCell(0);
+ try (Workbook wb = _testDataProvider.createWorkbook()) {
- cell.setCellValue(12312345123L);
+ Sheet sheet = wb.createSheet("test");
+ Row row = sheet.createRow(0);
+ Cell cell = row.createCell(0);
- DataFormat format = wb.createDataFormat();
- CellStyle style = wb.createCellStyle();
- style.setDataFormat(format.getFormat("000-00000-000"));
- cell.setCellStyle(style);
+ cell.setCellValue(12312345123L);
- assertEquals("000-00000-000",
- cell.getCellStyle().getDataFormatString());
- assertEquals(164, cell.getCellStyle().getDataFormat());
+ DataFormat format = wb.createDataFormat();
+ CellStyle style = wb.createCellStyle();
+ style.setDataFormat(format.getFormat("000-00000-000"));
+ cell.setCellStyle(style);
- DataFormatter formatter = new DataFormatter();
+ assertEquals("000-00000-000",
+ cell.getCellStyle().getDataFormatString());
+ assertEquals(164, cell.getCellStyle().getDataFormat());
- assertEquals("12-312-345-123", formatter.formatCellValue(cell));
+ DataFormatter formatter = new DataFormatter();
- wb.close();
+ assertEquals("12-312-345-123", formatter.formatCellValue(cell));
+ }
}
-
+
@Test
public void test58896() throws IOException {
final int nrows = 160;
final int ncols = 139;
-
+
// Create a workbook
- final Workbook wb = _testDataProvider.createWorkbook(nrows+1);
- final Sheet sh = wb.createSheet();
- if (logger.check(POILogger.DEBUG)) {
[... 653 lines stripped ...]
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org