You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/11/30 05:05:47 UTC
[GitHub] [cloudstack] Pearl1594 opened a new pull request #4505: Make global setting non-dynamic
Pearl1594 opened a new pull request #4505:
URL: https://github.com/apache/cloudstack/pull/4505
### Description
This PR:
- makes the global setting "secstorage.max.migrate.sessions" non dynamic - as it requires a restart to take effect
- removes an hard-coded value being passed for CopyCommand
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [X] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [X] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
Verified the behavior of global setting by changing its value and it taking effect post restart of MS
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4505: Make global setting non-dynamic
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4505:
URL: https://github.com/apache/cloudstack/pull/4505#issuecomment-735565122
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2442
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4505: Make global setting non-dynamic
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4505:
URL: https://github.com/apache/cloudstack/pull/4505#issuecomment-735548274
@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #4505: Make global setting "secstorage.max.migrate.sessions" non-dynamic
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4505:
URL: https://github.com/apache/cloudstack/pull/4505
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4505: Make global setting non-dynamic
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4505:
URL: https://github.com/apache/cloudstack/pull/4505#issuecomment-735591672
@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4505: Make global setting non-dynamic
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #4505:
URL: https://github.com/apache/cloudstack/pull/4505#issuecomment-735606880
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4505: Make global setting non-dynamic
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4505:
URL: https://github.com/apache/cloudstack/pull/4505#issuecomment-735961606
<b>Trillian test result (tid-3286)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37474 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4505-t3286-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Smoke tests completed. 85 look OK, 1 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_03_deploy_and_upgrade_kubernetes_cluster | `Failure` | 267.26 | test_kubernetes_clusters.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4505: Make global setting non-dynamic
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #4505:
URL: https://github.com/apache/cloudstack/pull/4505#issuecomment-735591408
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4505: Make global setting non-dynamic
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4505:
URL: https://github.com/apache/cloudstack/pull/4505#issuecomment-735607292
@Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4505: Make global setting non-dynamic
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4505:
URL: https://github.com/apache/cloudstack/pull/4505#issuecomment-735606602
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2445
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4505: Make global setting non-dynamic
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #4505:
URL: https://github.com/apache/cloudstack/pull/4505#issuecomment-735547926
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org