You are viewing a plain text version of this content. The canonical link for it is here.
Posted to general@incubator.apache.org by sebb <se...@gmail.com> on 2013/06/03 01:01:45 UTC
Re: svn commit: r1488735 - in /incubator/public/trunk/tools:
NOTICE.txt requirements.txt setup.py src/asf/utils/ src/asf/utils/__init__.py
src/asf/utils/config.py src/asf/utils/file.py tests/test_config.py
On 2 June 2013 17:21, <ad...@apache.org> wrote:
> Author: adc
> Date: Sun Jun 2 16:21:24 2013
> New Revision: 1488735
>
> URL: http://svn.apache.org/r1488735
> Log:
> First few utility functions/classes
>
> Also include LinkedIn notice
>
> Added:
> incubator/public/trunk/tools/src/asf/utils/
> incubator/public/trunk/tools/src/asf/utils/__init__.py
> incubator/public/trunk/tools/src/asf/utils/config.py
> incubator/public/trunk/tools/src/asf/utils/file.py
> incubator/public/trunk/tools/tests/test_config.py
> Modified:
> incubator/public/trunk/tools/NOTICE.txt
> incubator/public/trunk/tools/requirements.txt
> incubator/public/trunk/tools/setup.py
>
> Modified: incubator/public/trunk/tools/NOTICE.txt
> URL: http://svn.apache.org/viewvc/incubator/public/trunk/tools/NOTICE.txt?rev=1488735&r1=1488734&r2=1488735&view=diff
> ==============================================================================
> --- incubator/public/trunk/tools/NOTICE.txt (original)
> +++ incubator/public/trunk/tools/NOTICE.txt Sun Jun 2 16:21:24 2013
> @@ -1,5 +1,21 @@
> =========================================================================
> == NOTICE file corresponding to section 4(d) of the Apache License, ==
> -== Version 1.0.0, in this case for the LiveTribe Utilities ==
> +== Version 2.0.0, in this case for the ASF Incubator tools ==
> == distribution. ==
> =========================================================================
> +
> +This distribution contains code from the LinkedIn Corporation:
> +
> + Copyright (c) 2013 LinkedIn Corp. All rights reserved.
> +
> + Licensed under the Apache License, Version 2.0 (the "License");
> + you may not use this file except in compliance with the License.
> + You may obtain a copy of the License at
> +
> + http://www.apache.org/licenses/LICENSE-2.0
> +
> + Unless required by applicable law or agreed to in writing, software
> + distributed under the License is distributed on an "AS IS" BASIS,
> + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
> + See the License for the specific language governing permissions and
> + limitations under the License.
That does not look like a standard NOTICE file.
The part between === should not be present, and the AL 2.0 should not
be there either.
Is the notice entry even required by the Linked In license?
Remember that NOTICE files are like poems - they are only correct when
nothing more can be removed!
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: svn commit: r1488735 - in /incubator/public/trunk/tools: NOTICE.txt requirements.txt setup.py src/asf/utils/ src/asf/utils/__init__.py src/asf/utils/config.py src/asf/utils/file.py tests/test_config.py
Posted by Alan Cabrera <li...@toolazydogs.com>.
On Jun 3, 2013, at 2:23 PM, sebb <se...@gmail.com> wrote:
> On 3 June 2013 05:10, Greg Stein <gs...@gmail.com> wrote:
>> On Sun, Jun 2, 2013 at 11:08 PM, Alan Cabrera <li...@toolazydogs.com> wrote:
>>> ...
>>>
>>> Apache Incubator tools
>>> Copyright 2013 The Apache Software Foundation
>>>
>>> This product includes software developed at
>>> The Apache Software Foundation (http://www.apache.org/).
>>>
>>> This distribution contains code from the LinkedIn Corporation:
>>>
>>> Copyright (c) 2013 LinkedIn Corp. All rights reserved.
>>> Licensed under the Apache License, Version 2.0
>>>
>>>
>>> WDYT?
>>
>> Looks good. And given that the LinkedIn stuff is under ALv2, then 4(d)
>> comes into play, requesting attribution. It is Right and Proper that
>> they get a couple lines in our NOTICE file.
>
> I'm not convinced of that.
> If their attribution request is not in the NOTICE file, does it have
> to go in ours?
>
> Attribution could be added in a CREDITS file as per
>
> https://svn.apache.org/repos/asf/cocoon/branches/BRANCH_2_1_X/CREDITS.txt
A credits file does not seem to be the appropriate place for a copyright declaration.
Regards,
Alan
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: svn commit: r1488735 - in /incubator/public/trunk/tools: NOTICE.txt requirements.txt setup.py src/asf/utils/ src/asf/utils/__init__.py src/asf/utils/config.py src/asf/utils/file.py tests/test_config.py
Posted by Kevan Miller <ke...@gmail.com>.
On Jun 4, 2013, at 9:46 AM, Alan Cabrera <li...@toolazydogs.com> wrote:
>
> On Jun 4, 2013, at 5:58 AM, Kevan Miller <ke...@gmail.com> wrote:
>
>>
>> On Jun 4, 2013, at 8:46 AM, Greg Stein <gs...@gmail.com> wrote:
>>
>>> On Jun 4, 2013 4:22 AM, "ant elder" <an...@gmail.com> wrote:
>>>>
>>>> This "when in doubt leave it out" approach has gone a long way at
>>>> smoothing podling release reviews compared to the olden days.
>>>
>>> Seriously? The inserted code uses our own license! Go look at 4(d) and tell
>>> me we should not insert a notice. It is both Right, and what is demanded by
>>> our own license.
>>
>> I haven't seen a description of where this code is coming from. Is it a contribution from LinkedIn? Is it some open source code from LinkedIn that we are copying into our svn from some other project?
>>
>> If it's the former and LinkedIn has requested attribution for their contribution, then let's observe their request and add attribution to the NOTICE.
>>
>> If it's the latter *and* the subject code has a NOTICE file, then we absolutely must include the relevant portions of their NOTICE in our NOTICE. Otherwise, 4 (d) doesn't require us to do anything. Agreed?
>
>
> The code is internal LinkedIn code that I copied with the appropriate permissions. Attribution was requested.
Cool. Thanks.
So, NOTICE should contain the attribution and copyright.
--kevan
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: svn commit: r1488735 - in /incubator/public/trunk/tools: NOTICE.txt requirements.txt setup.py src/asf/utils/ src/asf/utils/__init__.py src/asf/utils/config.py src/asf/utils/file.py tests/test_config.py
Posted by Alan Cabrera <li...@toolazydogs.com>.
On Jun 4, 2013, at 5:58 AM, Kevan Miller <ke...@gmail.com> wrote:
>
> On Jun 4, 2013, at 8:46 AM, Greg Stein <gs...@gmail.com> wrote:
>
>> On Jun 4, 2013 4:22 AM, "ant elder" <an...@gmail.com> wrote:
>>>
>>> This "when in doubt leave it out" approach has gone a long way at
>>> smoothing podling release reviews compared to the olden days.
>>
>> Seriously? The inserted code uses our own license! Go look at 4(d) and tell
>> me we should not insert a notice. It is both Right, and what is demanded by
>> our own license.
>
> I haven't seen a description of where this code is coming from. Is it a contribution from LinkedIn? Is it some open source code from LinkedIn that we are copying into our svn from some other project?
>
> If it's the former and LinkedIn has requested attribution for their contribution, then let's observe their request and add attribution to the NOTICE.
>
> If it's the latter *and* the subject code has a NOTICE file, then we absolutely must include the relevant portions of their NOTICE in our NOTICE. Otherwise, 4 (d) doesn't require us to do anything. Agreed?
The code is internal LinkedIn code that I copied with the appropriate permissions. Attribution was requested.
Regards,
Alan
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: svn commit: r1488735 - in /incubator/public/trunk/tools: NOTICE.txt requirements.txt setup.py src/asf/utils/ src/asf/utils/__init__.py src/asf/utils/config.py src/asf/utils/file.py tests/test_config.py
Posted by Kevan Miller <ke...@gmail.com>.
On Jun 4, 2013, at 8:46 AM, Greg Stein <gs...@gmail.com> wrote:
> On Jun 4, 2013 4:22 AM, "ant elder" <an...@gmail.com> wrote:
>>
>> On Tue, Jun 4, 2013 at 1:45 AM, Greg Stein <gs...@gmail.com> wrote:
>>
>>>
>>> Simple as that.
>>>
>>
>> If only.
>>
>> This is the old "what goes in the NOTICE file" debate that has
>> probably caused more emails and confusion than any other topic here.
>>
>> My understanding of the current thinking on this is to only include
>> something in the NOTICE file when there is a clear legal requirement,
>> and that probably means some explicit documentation at ASF Legal for
>> the specific case (i.e raise a Legal JIRA asking). If any attribution
>> is required or wanted then its probably done by including the license
>> / copyright in the LICENSE file or the attribution should be added to
>> the README or to a separate CREDITS type file. There are numerous
>> discussions on this list about that and JIRA's like LEGAL-62 (wasn't
>> there a post from Roy once saying he'd have artifacts removed from the
>> distribution area if people had added random stuff to the NOTICE?).
>>
>> This "when in doubt leave it out" approach has gone a long way at
>> smoothing podling release reviews compared to the olden days.
>
> Seriously? The inserted code uses our own license! Go look at 4(d) and tell
> me we should not insert a notice. It is both Right, and what is demanded by
> our own license.
I haven't seen a description of where this code is coming from. Is it a contribution from LinkedIn? Is it some open source code from LinkedIn that we are copying into our svn from some other project?
If it's the former and LinkedIn has requested attribution for their contribution, then let's observe their request and add attribution to the NOTICE.
If it's the latter *and* the subject code has a NOTICE file, then we absolutely must include the relevant portions of their NOTICE in our NOTICE. Otherwise, 4 (d) doesn't require us to do anything. Agreed?
--kevan
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: svn commit: r1488735 - in /incubator/public/trunk/tools:
NOTICE.txt requirements.txt setup.py src/asf/utils/ src/asf/utils/__init__.py
src/asf/utils/config.py src/asf/utils/file.py tests/test_config.py
Posted by Marvin Humphrey <ma...@rectangular.com>.
On Tue, Jun 4, 2013 at 6:40 AM, ant elder <an...@gmail.com> wrote:
> On Tue, Jun 4, 2013 at 1:46 PM, Greg Stein <gs...@gmail.com> wrote:
>> You guys are insane. This is dead simple, or it should be if you all would
>> stop being bureaucratic, obstinate meddlers.
>>
>> -g
>
> Alan asked the question "Would this suffice:" so we're just trying to
> help, the hostility isn't necessary.
+1
> We're expected to review podling releases and help educate them about
> what needs to go into the NOTICE file so we need to understand what
> the requirements are. After numerous threads about this, questions to
> Legal etc, over some years, AIUI the consensus is that few things
> require an entry in the NOTICE file and you should not put things in
> there unless explicitly required to. I'm totally happy to be told
> thats wrong, its good if we all get a common understanding so podlings
> know what to expect. If uou're now suggesting that 3rd party code
> under AL2 then section 4(d) requires us to add an entry in our NOTICE
> then we should clarify that because most podlings don't do that now,
> if there is any question then we should just raise a Legal JIRA to
> clarify.
IANAL but here's my understanding as someone who's put in a lot of time on the
NOTICE issue...
Since Alan works for LinkedIn, from the ASF's standpoint he has the
authorization to remove or relocate LinkedIn copyright notifications. The
situation is similar to what happens when a podling starts up with an initial
code drop and we ask a representative of the copyright holder to remove or
relocate copyright notifications.
However, it appears that unlike many, many other contributions to ASF projects
by employees of LinkedIn, in this case LinkedIn's authorization for Alan to
contribute the code comes with the condition that he must ensure that the
copyright notification is preserved in some form. (They're calling it
"internal" code, but from our perspective how the material was developed
within LinkedIn is not relevant so long as they hold the copyright on all of
it -- it's no longer "internal" once Alan commits it to our repository.)
This adds a small amount of complexity to the NOTICE file, and IMO, in general
we should not encourage it. Technically, every copyright holder who
contributes a copyrightable amount of material to a project could insist on
inclusion within NOTICE, but that would be burdensome -- the less legal stuff
that we force all the non-lawyers working on ASF projects to deal with, the
better. Lengthy, complicated NOTICE files are a pain both for us and for
downstream consumers because they make us think about questions like "Do we
have to respin a new RC to update the year in the LinkedIn copyright notice?".
The advantage of providing "credit" a la Cocoon is that if somebody messes up
and an errant patch damages the credits file and omits or miscredits some
contributor, that's bad but at least there are no legal ramifications. Not so
with copyright notices.
Nevertheless, the contribution with the copyright notifications relocated to
NOTICE is valid and we should accept it gratefully. At least it is being been
adapted so that it will no longer contain copyright notifications in each
source file, reducing the legal maintenance burden somewhat and avoiding the
social issues associated with @author tags.
Marvin Humphrey
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: svn commit: r1488735 - in /incubator/public/trunk/tools:
NOTICE.txt requirements.txt setup.py src/asf/utils/ src/asf/utils/__init__.py
src/asf/utils/config.py src/asf/utils/file.py tests/test_config.py
Posted by Greg Stein <gs...@gmail.com>.
On Jun 4, 2013 9:40 AM, "ant elder" <an...@gmail.com> wrote:
>
> On Tue, Jun 4, 2013 at 1:46 PM, Greg Stein <gs...@gmail.com> wrote:
> >...
> > And this isn't some podling trying to figure shit out. This is some
> > Incubator tooling that has explicitly incorporated third party code. We
> > absolutely know third party code is there. We should provide notice.
> >
> > You guys are insane. This is dead simple, or it should be if you all
would
> > stop being bureaucratic, obstinate meddlers.
> >
> > -g
>
> Alan asked the question "Would this suffice:" so we're just trying to
> help, the hostility isn't necessary.
>
> We're expected to review podling releases and help educate them about
When you don't bother to read my email (this isn't a podling), then why
should I be happy?
-g
Re: svn commit: r1488735 - in /incubator/public/trunk/tools:
NOTICE.txt requirements.txt setup.py src/asf/utils/ src/asf/utils/__init__.py
src/asf/utils/config.py src/asf/utils/file.py tests/test_config.py
Posted by ant elder <an...@gmail.com>.
On Tue, Jun 4, 2013 at 1:46 PM, Greg Stein <gs...@gmail.com> wrote:
> On Jun 4, 2013 4:22 AM, "ant elder" <an...@gmail.com> wrote:
>>
>> On Tue, Jun 4, 2013 at 1:45 AM, Greg Stein <gs...@gmail.com> wrote:
>>
>> >
>> > Simple as that.
>> >
>>
>> If only.
>>
>> This is the old "what goes in the NOTICE file" debate that has
>> probably caused more emails and confusion than any other topic here.
>>
>> My understanding of the current thinking on this is to only include
>> something in the NOTICE file when there is a clear legal requirement,
>> and that probably means some explicit documentation at ASF Legal for
>> the specific case (i.e raise a Legal JIRA asking). If any attribution
>> is required or wanted then its probably done by including the license
>> / copyright in the LICENSE file or the attribution should be added to
>> the README or to a separate CREDITS type file. There are numerous
>> discussions on this list about that and JIRA's like LEGAL-62 (wasn't
>> there a post from Roy once saying he'd have artifacts removed from the
>> distribution area if people had added random stuff to the NOTICE?).
>>
>> This "when in doubt leave it out" approach has gone a long way at
>> smoothing podling release reviews compared to the olden days.
>
> Seriously? The inserted code uses our own license! Go look at 4(d) and tell
> me we should not insert a notice. It is both Right, and what is demanded by
> our own license.
>
> And this isn't some podling trying to figure shit out. This is some
> Incubator tooling that has explicitly incorporated third party code. We
> absolutely know third party code is there. We should provide notice.
>
> You guys are insane. This is dead simple, or it should be if you all would
> stop being bureaucratic, obstinate meddlers.
>
> -g
Alan asked the question "Would this suffice:" so we're just trying to
help, the hostility isn't necessary.
We're expected to review podling releases and help educate them about
what needs to go into the NOTICE file so we need to understand what
the requirements are. After numerous threads about this, questions to
Legal etc, over some years, AIUI the consensus is that few things
require an entry in the NOTICE file and you should not put things in
there unless explicitly required to. I'm totally happy to be told
thats wrong, its good if we all get a common understanding so podlings
know what to expect. If uou're now suggesting that 3rd party code
under AL2 then section 4(d) requires us to add an entry in our NOTICE
then we should clarify that because most podlings don't do that now,
if there is any question then we should just raise a Legal JIRA to
clarify.
...ant
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: svn commit: r1488735 - in /incubator/public/trunk/tools:
NOTICE.txt requirements.txt setup.py src/asf/utils/ src/asf/utils/__init__.py
src/asf/utils/config.py src/asf/utils/file.py tests/test_config.py
Posted by Greg Stein <gs...@gmail.com>.
On Jun 4, 2013 4:22 AM, "ant elder" <an...@gmail.com> wrote:
>
> On Tue, Jun 4, 2013 at 1:45 AM, Greg Stein <gs...@gmail.com> wrote:
>
> >
> > Simple as that.
> >
>
> If only.
>
> This is the old "what goes in the NOTICE file" debate that has
> probably caused more emails and confusion than any other topic here.
>
> My understanding of the current thinking on this is to only include
> something in the NOTICE file when there is a clear legal requirement,
> and that probably means some explicit documentation at ASF Legal for
> the specific case (i.e raise a Legal JIRA asking). If any attribution
> is required or wanted then its probably done by including the license
> / copyright in the LICENSE file or the attribution should be added to
> the README or to a separate CREDITS type file. There are numerous
> discussions on this list about that and JIRA's like LEGAL-62 (wasn't
> there a post from Roy once saying he'd have artifacts removed from the
> distribution area if people had added random stuff to the NOTICE?).
>
> This "when in doubt leave it out" approach has gone a long way at
> smoothing podling release reviews compared to the olden days.
Seriously? The inserted code uses our own license! Go look at 4(d) and tell
me we should not insert a notice. It is both Right, and what is demanded by
our own license.
And this isn't some podling trying to figure shit out. This is some
Incubator tooling that has explicitly incorporated third party code. We
absolutely know third party code is there. We should provide notice.
You guys are insane. This is dead simple, or it should be if you all would
stop being bureaucratic, obstinate meddlers.
-g
Re: svn commit: r1488735 - in /incubator/public/trunk/tools:
NOTICE.txt requirements.txt setup.py src/asf/utils/ src/asf/utils/__init__.py
src/asf/utils/config.py src/asf/utils/file.py tests/test_config.py
Posted by ant elder <an...@gmail.com>.
On Tue, Jun 4, 2013 at 1:45 AM, Greg Stein <gs...@gmail.com> wrote:
>
> Simple as that.
>
If only.
This is the old "what goes in the NOTICE file" debate that has
probably caused more emails and confusion than any other topic here.
My understanding of the current thinking on this is to only include
something in the NOTICE file when there is a clear legal requirement,
and that probably means some explicit documentation at ASF Legal for
the specific case (i.e raise a Legal JIRA asking). If any attribution
is required or wanted then its probably done by including the license
/ copyright in the LICENSE file or the attribution should be added to
the README or to a separate CREDITS type file. There are numerous
discussions on this list about that and JIRA's like LEGAL-62 (wasn't
there a post from Roy once saying he'd have artifacts removed from the
distribution area if people had added random stuff to the NOTICE?).
This "when in doubt leave it out" approach has gone a long way at
smoothing podling release reviews compared to the olden days.
...ant
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: svn commit: r1488735 - in /incubator/public/trunk/tools:
NOTICE.txt requirements.txt setup.py src/asf/utils/ src/asf/utils/__init__.py
src/asf/utils/config.py src/asf/utils/file.py tests/test_config.py
Posted by Greg Stein <gs...@gmail.com>.
On Mon, Jun 3, 2013 at 8:15 PM, sebb <se...@gmail.com> wrote:
> On 4 June 2013 01:04, Greg Stein <gs...@gmail.com> wrote:
>> On Mon, Jun 3, 2013 at 5:45 PM, sebb <se...@gmail.com> wrote:
>>>...
>>> I think that conflicts with the advice here:
>>>
>>> http://www.apache.org/dev/licensing-howto.html#mod-notice
>>>
>>> The last sentence says: "Do not add anything to NOTICE which is not
>>> legally required."
>>>
>>> Being legal and being nice may not be completely disjoint but they are
>>> certainly not identical.
>>
>>
>> Let me turn it around: why should it NOT go in there? Why is it not
>> legally required?
>
> Since the intention is to minimise the content of NOTICE, the onus
> should be on showing that it must be in there rather showing why it
> should not be there.
Already stated:
If their code is under ALv2, then the license says we must put their
copyright notice into our NOTICE file. Simple as that.
-g
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: svn commit: r1488735 - in /incubator/public/trunk/tools:
NOTICE.txt requirements.txt setup.py src/asf/utils/ src/asf/utils/__init__.py
src/asf/utils/config.py src/asf/utils/file.py tests/test_config.py
Posted by sebb <se...@gmail.com>.
On 4 June 2013 01:04, Greg Stein <gs...@gmail.com> wrote:
> On Mon, Jun 3, 2013 at 5:45 PM, sebb <se...@gmail.com> wrote:
>>...
>> I think that conflicts with the advice here:
>>
>> http://www.apache.org/dev/licensing-howto.html#mod-notice
>>
>> The last sentence says: "Do not add anything to NOTICE which is not
>> legally required."
>>
>> Being legal and being nice may not be completely disjoint but they are
>> certainly not identical.
>
>
> Let me turn it around: why should it NOT go in there? Why is it not
> legally required?
Since the intention is to minimise the content of NOTICE, the onus
should be on showing that it must be in there rather showing why it
should not be there.
> -g
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: svn commit: r1488735 - in /incubator/public/trunk/tools:
NOTICE.txt requirements.txt setup.py src/asf/utils/ src/asf/utils/__init__.py
src/asf/utils/config.py src/asf/utils/file.py tests/test_config.py
Posted by Greg Stein <gs...@gmail.com>.
On Mon, Jun 3, 2013 at 5:45 PM, sebb <se...@gmail.com> wrote:
>...
> I think that conflicts with the advice here:
>
> http://www.apache.org/dev/licensing-howto.html#mod-notice
>
> The last sentence says: "Do not add anything to NOTICE which is not
> legally required."
>
> Being legal and being nice may not be completely disjoint but they are
> certainly not identical.
Geez. Come on. Now you're just being a dick.
Let me turn it around: why should it NOT go in there? Why is it not
legally required?
-g
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: svn commit: r1488735 - in /incubator/public/trunk/tools:
NOTICE.txt requirements.txt setup.py src/asf/utils/ src/asf/utils/__init__.py
src/asf/utils/config.py src/asf/utils/file.py tests/test_config.py
Posted by sebb <se...@gmail.com>.
On 3 June 2013 22:40, Greg Stein <gs...@gmail.com> wrote:
> On Mon, Jun 3, 2013 at 5:23 PM, sebb <se...@gmail.com> wrote:
>> On 3 June 2013 05:10, Greg Stein <gs...@gmail.com> wrote:
>>> On Sun, Jun 2, 2013 at 11:08 PM, Alan Cabrera <li...@toolazydogs.com> wrote:
>>>>...
>>>>
>>>> Apache Incubator tools
>>>> Copyright 2013 The Apache Software Foundation
>>>>
>>>> This product includes software developed at
>>>> The Apache Software Foundation (http://www.apache.org/).
>>>>
>>>> This distribution contains code from the LinkedIn Corporation:
>>>>
>>>> Copyright (c) 2013 LinkedIn Corp. All rights reserved.
>>>> Licensed under the Apache License, Version 2.0
>>>>
>>>>
>>>> WDYT?
>>>
>>> Looks good. And given that the LinkedIn stuff is under ALv2, then 4(d)
>>> comes into play, requesting attribution. It is Right and Proper that
>>> they get a couple lines in our NOTICE file.
>>
>> I'm not convinced of that.
>> If their attribution request is not in the NOTICE file, does it have
>> to go in ours?
>
> Maybe, maybe not. Why be so concerned? Let's be good citizens and
> recognize their contribution in our NOTICE file. It doesn't hurt
> anybody.
>
> If they have their own NOTICE file, which gets incorporated into a
> subdir of *our* distro, then we can/should reference it from our
> NOTICE file.
>
> I'd rather that we be nice by default.
I think that conflicts with the advice here:
http://www.apache.org/dev/licensing-howto.html#mod-notice
The last sentence says: "Do not add anything to NOTICE which is not
legally required."
Being legal and being nice may not be completely disjoint but they are
certainly not identical.
> Cheers,
> -g
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: svn commit: r1488735 - in /incubator/public/trunk/tools:
NOTICE.txt requirements.txt setup.py src/asf/utils/ src/asf/utils/__init__.py
src/asf/utils/config.py src/asf/utils/file.py tests/test_config.py
Posted by Greg Stein <gs...@gmail.com>.
On Mon, Jun 3, 2013 at 5:23 PM, sebb <se...@gmail.com> wrote:
> On 3 June 2013 05:10, Greg Stein <gs...@gmail.com> wrote:
>> On Sun, Jun 2, 2013 at 11:08 PM, Alan Cabrera <li...@toolazydogs.com> wrote:
>>>...
>>>
>>> Apache Incubator tools
>>> Copyright 2013 The Apache Software Foundation
>>>
>>> This product includes software developed at
>>> The Apache Software Foundation (http://www.apache.org/).
>>>
>>> This distribution contains code from the LinkedIn Corporation:
>>>
>>> Copyright (c) 2013 LinkedIn Corp. All rights reserved.
>>> Licensed under the Apache License, Version 2.0
>>>
>>>
>>> WDYT?
>>
>> Looks good. And given that the LinkedIn stuff is under ALv2, then 4(d)
>> comes into play, requesting attribution. It is Right and Proper that
>> they get a couple lines in our NOTICE file.
>
> I'm not convinced of that.
> If their attribution request is not in the NOTICE file, does it have
> to go in ours?
Maybe, maybe not. Why be so concerned? Let's be good citizens and
recognize their contribution in our NOTICE file. It doesn't hurt
anybody.
If they have their own NOTICE file, which gets incorporated into a
subdir of *our* distro, then we can/should reference it from our
NOTICE file.
I'd rather that we be nice by default.
Cheers,
-g
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: svn commit: r1488735 - in /incubator/public/trunk/tools:
NOTICE.txt requirements.txt setup.py src/asf/utils/ src/asf/utils/__init__.py
src/asf/utils/config.py src/asf/utils/file.py tests/test_config.py
Posted by sebb <se...@gmail.com>.
On 3 June 2013 05:10, Greg Stein <gs...@gmail.com> wrote:
> On Sun, Jun 2, 2013 at 11:08 PM, Alan Cabrera <li...@toolazydogs.com> wrote:
>>...
>>
>> Apache Incubator tools
>> Copyright 2013 The Apache Software Foundation
>>
>> This product includes software developed at
>> The Apache Software Foundation (http://www.apache.org/).
>>
>> This distribution contains code from the LinkedIn Corporation:
>>
>> Copyright (c) 2013 LinkedIn Corp. All rights reserved.
>> Licensed under the Apache License, Version 2.0
>>
>>
>> WDYT?
>
> Looks good. And given that the LinkedIn stuff is under ALv2, then 4(d)
> comes into play, requesting attribution. It is Right and Proper that
> they get a couple lines in our NOTICE file.
I'm not convinced of that.
If their attribution request is not in the NOTICE file, does it have
to go in ours?
Attribution could be added in a CREDITS file as per
https://svn.apache.org/repos/asf/cocoon/branches/BRANCH_2_1_X/CREDITS.txt
> Note that we may even need to incorporate portions of *their* NOTICE
Indeed, see http://www.apache.org/dev/licensing-howto.html#mod-notice
> file. (I don't know the extent of inclusion/derivation, but ALv2 4(d)
> is pretty straight-forward)
>
> Cheers,
> -g
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: svn commit: r1488735 - in /incubator/public/trunk/tools:
NOTICE.txt requirements.txt setup.py src/asf/utils/ src/asf/utils/__init__.py
src/asf/utils/config.py src/asf/utils/file.py tests/test_config.py
Posted by Greg Stein <gs...@gmail.com>.
On Sun, Jun 2, 2013 at 11:08 PM, Alan Cabrera <li...@toolazydogs.com> wrote:
>...
>
> Apache Incubator tools
> Copyright 2013 The Apache Software Foundation
>
> This product includes software developed at
> The Apache Software Foundation (http://www.apache.org/).
>
> This distribution contains code from the LinkedIn Corporation:
>
> Copyright (c) 2013 LinkedIn Corp. All rights reserved.
> Licensed under the Apache License, Version 2.0
>
>
> WDYT?
Looks good. And given that the LinkedIn stuff is under ALv2, then 4(d)
comes into play, requesting attribution. It is Right and Proper that
they get a couple lines in our NOTICE file.
Note that we may even need to incorporate portions of *their* NOTICE
file. (I don't know the extent of inclusion/derivation, but ALv2 4(d)
is pretty straight-forward)
Cheers,
-g
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: svn commit: r1488735 - in /incubator/public/trunk/tools: NOTICE.txt requirements.txt setup.py src/asf/utils/ src/asf/utils/__init__.py src/asf/utils/config.py src/asf/utils/file.py tests/test_config.py
Posted by Alan Cabrera <li...@toolazydogs.com>.
On Jun 2, 2013, at 8:51 PM, Kevan Miller <ke...@gmail.com> wrote:
>
> On Jun 2, 2013, at 11:08 PM, Alan Cabrera <li...@toolazydogs.com> wrote:
>
>> Apache Incubator tools
>> Copyright 2013 The Apache Software Foundation
>>
>> This product includes software developed at
>> The Apache Software Foundation (http://www.apache.org/).
>>
>> This distribution contains code from the LinkedIn Corporation:
>>
>> Copyright (c) 2013 LinkedIn Corp. All rights reserved.
>> Licensed under the Apache License, Version 2.0
>>
>>
>> WDYT?
>
> There is still Sebb's outstanding question:
>
> "Anyway, does the LinkedIn license REQUIRE attribution in a NOTICE file?"
I was asked to provide attribution. The NOTICE file seemed to be a reasonable plea to put it.
Regards,
Alan
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: svn commit: r1488735 - in /incubator/public/trunk/tools: NOTICE.txt requirements.txt setup.py src/asf/utils/ src/asf/utils/__init__.py src/asf/utils/config.py src/asf/utils/file.py tests/test_config.py
Posted by Kevan Miller <ke...@gmail.com>.
On Jun 2, 2013, at 11:08 PM, Alan Cabrera <li...@toolazydogs.com> wrote:
> Apache Incubator tools
> Copyright 2013 The Apache Software Foundation
>
> This product includes software developed at
> The Apache Software Foundation (http://www.apache.org/).
>
> This distribution contains code from the LinkedIn Corporation:
>
> Copyright (c) 2013 LinkedIn Corp. All rights reserved.
> Licensed under the Apache License, Version 2.0
>
>
> WDYT?
There is still Sebb's outstanding question:
"Anyway, does the LinkedIn license REQUIRE attribution in a NOTICE file?"
--kevan
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: svn commit: r1488735 - in /incubator/public/trunk/tools: NOTICE.txt requirements.txt setup.py src/asf/utils/ src/asf/utils/__init__.py src/asf/utils/config.py src/asf/utils/file.py tests/test_config.py
Posted by Kevan Miller <ke...@gmail.com>.
On Jun 4, 2013, at 9:34 AM, Alan Cabrera <li...@toolazydogs.com> wrote:
>
> On Jun 3, 2013, at 5:12 PM, Greg Stein <gs...@gmail.com> wrote:
>
>> As I said, it does look good. But I don't see the LinkedIn Copyright
>> in any files under tools/. The copyright/license header should remain
>> in the files that you copied into our repos. It is impossible to tell
>> what is from LinkedIn.
>>
>
> I'll add the copyright to those files.
If you are the copyright holder, then the copyrights should be removed (or not be added to the source files). For guidance, see:
http://apache.org/legal/src-headers.html#headers
--kevan
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: svn commit: r1488735 - in /incubator/public/trunk/tools: NOTICE.txt requirements.txt setup.py src/asf/utils/ src/asf/utils/__init__.py src/asf/utils/config.py src/asf/utils/file.py tests/test_config.py
Posted by Alan Cabrera <li...@toolazydogs.com>.
On Jun 4, 2013, at 6:34 AM, Alan Cabrera <li...@toolazydogs.com> wrote:
>
> On Jun 3, 2013, at 5:12 PM, Greg Stein <gs...@gmail.com> wrote:
>
>> As I said, it does look good. But I don't see the LinkedIn Copyright
>> in any files under tools/. The copyright/license header should remain
>> in the files that you copied into our repos. It is impossible to tell
>> what is from LinkedIn.
>>
>
> I'll add the copyright to those files.
This was what was in my head when I checked in my code:
http://www.apache.org/legal/src-headers.html#header-existingcopyright
More specifically:
"move them to the NOTICE file associated with each applicable project release"
Regards,
Alan
Re: svn commit: r1488735 - in /incubator/public/trunk/tools: NOTICE.txt requirements.txt setup.py src/asf/utils/ src/asf/utils/__init__.py src/asf/utils/config.py src/asf/utils/file.py tests/test_config.py
Posted by Alan Cabrera <li...@toolazydogs.com>.
On Jun 3, 2013, at 5:12 PM, Greg Stein <gs...@gmail.com> wrote:
> As I said, it does look good. But I don't see the LinkedIn Copyright
> in any files under tools/. The copyright/license header should remain
> in the files that you copied into our repos. It is impossible to tell
> what is from LinkedIn.
>
I'll add the copyright to those files.
Regards,
Alan
Re: svn commit: r1488735 - in /incubator/public/trunk/tools:
NOTICE.txt requirements.txt setup.py src/asf/utils/ src/asf/utils/__init__.py
src/asf/utils/config.py src/asf/utils/file.py tests/test_config.py
Posted by Greg Stein <gs...@gmail.com>.
As I said, it does look good. But I don't see the LinkedIn Copyright
in any files under tools/. The copyright/license header should remain
in the files that you copied into our repos. It is impossible to tell
what is from LinkedIn.
Cheers,
-g
On Sun, Jun 2, 2013 at 11:08 PM, Alan Cabrera <li...@toolazydogs.com> wrote:
>
> On Jun 2, 2013, at 7:45 PM, Kevan Miller <ke...@gmail.com> wrote:
>
>>
>> On Jun 2, 2013, at 10:09 PM, Alan Cabrera <li...@toolazydogs.com> wrote:
>>
>>>
>>> On Jun 2, 2013, at 5:29 PM, sebb <se...@gmail.com> wrote:
>>>
>>>> On 3 June 2013 00:37, Alan Cabrera <li...@toolazydogs.com> wrote:
>>>>>
>>>>> On Jun 2, 2013, at 4:01 PM, sebb <se...@gmail.com> wrote:
>>>>>
>>>>>>> Modified: incubator/public/trunk/tools/NOTICE.txt
>>>>>>> URL: http://svn.apache.org/viewvc/incubator/public/trunk/tools/NOTICE.txt?rev=1488735&r1=1488734&r2=1488735&view=diff
>>>>>>> ==============================================================================
>>>>>>> --- incubator/public/trunk/tools/NOTICE.txt (original)
>>>>>>> +++ incubator/public/trunk/tools/NOTICE.txt Sun Jun 2 16:21:24 2013
>>>>>>> @@ -1,5 +1,21 @@
>>>>>>> =========================================================================
>>>>>>> == NOTICE file corresponding to section 4(d) of the Apache License, ==
>>>>>>> -== Version 1.0.0, in this case for the LiveTribe Utilities ==
>>>>>>> +== Version 2.0.0, in this case for the ASF Incubator tools ==
>>>>>>> == distribution. ==
>>>>>>> =========================================================================
>>>>>>> +
>>>>>>> +This distribution contains code from the LinkedIn Corporation:
>>>>>>> +
>>>>>>> + Copyright (c) 2013 LinkedIn Corp. All rights reserved.
>>>>>>> +
>>>>>>> + Licensed under the Apache License, Version 2.0 (the "License");
>>>>>>> + you may not use this file except in compliance with the License.
>>>>>>> + You may obtain a copy of the License at
>>>>>>> +
>>>>>>> + http://www.apache.org/licenses/LICENSE-2.0
>>>>>>> +
>>>>>>> + Unless required by applicable law or agreed to in writing, software
>>>>>>> + distributed under the License is distributed on an "AS IS" BASIS,
>>>>>>> + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
>>>>>>> + See the License for the specific language governing permissions and
>>>>>>> + limitations under the License.
>>>>>>
>>>>>> That does not look like a standard NOTICE file.
>>>>>> The part between === should not be present, and the AL 2.0 should not
>>>>>> be there either.
>>>>>>
>>>>>> Is the notice entry even required by the Linked In license?
>>>>>>
>>>>>> Remember that NOTICE files are like poems - they are only correct when
>>>>>> nothing more can be removed!
>>>>>
>>>>> Would this suffice:
>>>>>
>>>>> <begin>
>>>>> This distribution contains code from the LinkedIn Corporation:
>>>>>
>>>>> Copyright (c) 2013 LinkedIn Corp. All rights reserved.
>>>>> <end>j
>>>>
>>>> IMO, no.
>>>>
>>>> It's not a standard NOTICE file - the ASF header is missing.
>>>
>>>
>>> Can you point to a canonical example for me to emulate?
>>
>> How about the following:
>>
>> http://www.apache.org/legal/src-headers.html#notice
>> and
>> http://www.apache.org/dev/licensing-howto.html
>
>
> Apache Incubator tools
> Copyright 2013 The Apache Software Foundation
>
> This product includes software developed at
> The Apache Software Foundation (http://www.apache.org/).
>
> This distribution contains code from the LinkedIn Corporation:
>
> Copyright (c) 2013 LinkedIn Corp. All rights reserved.
> Licensed under the Apache License, Version 2.0
>
>
> WDYT?
>
>
> Regards,
> Alan
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: svn commit: r1488735 - in /incubator/public/trunk/tools: NOTICE.txt requirements.txt setup.py src/asf/utils/ src/asf/utils/__init__.py src/asf/utils/config.py src/asf/utils/file.py tests/test_config.py
Posted by Alan Cabrera <li...@toolazydogs.com>.
On Jun 2, 2013, at 7:45 PM, Kevan Miller <ke...@gmail.com> wrote:
>
> On Jun 2, 2013, at 10:09 PM, Alan Cabrera <li...@toolazydogs.com> wrote:
>
>>
>> On Jun 2, 2013, at 5:29 PM, sebb <se...@gmail.com> wrote:
>>
>>> On 3 June 2013 00:37, Alan Cabrera <li...@toolazydogs.com> wrote:
>>>>
>>>> On Jun 2, 2013, at 4:01 PM, sebb <se...@gmail.com> wrote:
>>>>
>>>>>> Modified: incubator/public/trunk/tools/NOTICE.txt
>>>>>> URL: http://svn.apache.org/viewvc/incubator/public/trunk/tools/NOTICE.txt?rev=1488735&r1=1488734&r2=1488735&view=diff
>>>>>> ==============================================================================
>>>>>> --- incubator/public/trunk/tools/NOTICE.txt (original)
>>>>>> +++ incubator/public/trunk/tools/NOTICE.txt Sun Jun 2 16:21:24 2013
>>>>>> @@ -1,5 +1,21 @@
>>>>>> =========================================================================
>>>>>> == NOTICE file corresponding to section 4(d) of the Apache License, ==
>>>>>> -== Version 1.0.0, in this case for the LiveTribe Utilities ==
>>>>>> +== Version 2.0.0, in this case for the ASF Incubator tools ==
>>>>>> == distribution. ==
>>>>>> =========================================================================
>>>>>> +
>>>>>> +This distribution contains code from the LinkedIn Corporation:
>>>>>> +
>>>>>> + Copyright (c) 2013 LinkedIn Corp. All rights reserved.
>>>>>> +
>>>>>> + Licensed under the Apache License, Version 2.0 (the "License");
>>>>>> + you may not use this file except in compliance with the License.
>>>>>> + You may obtain a copy of the License at
>>>>>> +
>>>>>> + http://www.apache.org/licenses/LICENSE-2.0
>>>>>> +
>>>>>> + Unless required by applicable law or agreed to in writing, software
>>>>>> + distributed under the License is distributed on an "AS IS" BASIS,
>>>>>> + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
>>>>>> + See the License for the specific language governing permissions and
>>>>>> + limitations under the License.
>>>>>
>>>>> That does not look like a standard NOTICE file.
>>>>> The part between === should not be present, and the AL 2.0 should not
>>>>> be there either.
>>>>>
>>>>> Is the notice entry even required by the Linked In license?
>>>>>
>>>>> Remember that NOTICE files are like poems - they are only correct when
>>>>> nothing more can be removed!
>>>>
>>>> Would this suffice:
>>>>
>>>> <begin>
>>>> This distribution contains code from the LinkedIn Corporation:
>>>>
>>>> Copyright (c) 2013 LinkedIn Corp. All rights reserved.
>>>> <end>j
>>>
>>> IMO, no.
>>>
>>> It's not a standard NOTICE file - the ASF header is missing.
>>
>>
>> Can you point to a canonical example for me to emulate?
>
> How about the following:
>
> http://www.apache.org/legal/src-headers.html#notice
> and
> http://www.apache.org/dev/licensing-howto.html
Apache Incubator tools
Copyright 2013 The Apache Software Foundation
This product includes software developed at
The Apache Software Foundation (http://www.apache.org/).
This distribution contains code from the LinkedIn Corporation:
Copyright (c) 2013 LinkedIn Corp. All rights reserved.
Licensed under the Apache License, Version 2.0
WDYT?
Regards,
Alan
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: svn commit: r1488735 - in /incubator/public/trunk/tools: NOTICE.txt requirements.txt setup.py src/asf/utils/ src/asf/utils/__init__.py src/asf/utils/config.py src/asf/utils/file.py tests/test_config.py
Posted by Kevan Miller <ke...@gmail.com>.
On Jun 2, 2013, at 10:09 PM, Alan Cabrera <li...@toolazydogs.com> wrote:
>
> On Jun 2, 2013, at 5:29 PM, sebb <se...@gmail.com> wrote:
>
>> On 3 June 2013 00:37, Alan Cabrera <li...@toolazydogs.com> wrote:
>>>
>>> On Jun 2, 2013, at 4:01 PM, sebb <se...@gmail.com> wrote:
>>>
>>>>> Modified: incubator/public/trunk/tools/NOTICE.txt
>>>>> URL: http://svn.apache.org/viewvc/incubator/public/trunk/tools/NOTICE.txt?rev=1488735&r1=1488734&r2=1488735&view=diff
>>>>> ==============================================================================
>>>>> --- incubator/public/trunk/tools/NOTICE.txt (original)
>>>>> +++ incubator/public/trunk/tools/NOTICE.txt Sun Jun 2 16:21:24 2013
>>>>> @@ -1,5 +1,21 @@
>>>>> =========================================================================
>>>>> == NOTICE file corresponding to section 4(d) of the Apache License, ==
>>>>> -== Version 1.0.0, in this case for the LiveTribe Utilities ==
>>>>> +== Version 2.0.0, in this case for the ASF Incubator tools ==
>>>>> == distribution. ==
>>>>> =========================================================================
>>>>> +
>>>>> +This distribution contains code from the LinkedIn Corporation:
>>>>> +
>>>>> + Copyright (c) 2013 LinkedIn Corp. All rights reserved.
>>>>> +
>>>>> + Licensed under the Apache License, Version 2.0 (the "License");
>>>>> + you may not use this file except in compliance with the License.
>>>>> + You may obtain a copy of the License at
>>>>> +
>>>>> + http://www.apache.org/licenses/LICENSE-2.0
>>>>> +
>>>>> + Unless required by applicable law or agreed to in writing, software
>>>>> + distributed under the License is distributed on an "AS IS" BASIS,
>>>>> + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
>>>>> + See the License for the specific language governing permissions and
>>>>> + limitations under the License.
>>>>
>>>> That does not look like a standard NOTICE file.
>>>> The part between === should not be present, and the AL 2.0 should not
>>>> be there either.
>>>>
>>>> Is the notice entry even required by the Linked In license?
>>>>
>>>> Remember that NOTICE files are like poems - they are only correct when
>>>> nothing more can be removed!
>>>
>>> Would this suffice:
>>>
>>> <begin>
>>> This distribution contains code from the LinkedIn Corporation:
>>>
>>> Copyright (c) 2013 LinkedIn Corp. All rights reserved.
>>> <end>j
>>
>> IMO, no.
>>
>> It's not a standard NOTICE file - the ASF header is missing.
>
>
> Can you point to a canonical example for me to emulate?
How about the following:
http://www.apache.org/legal/src-headers.html#notice
and
http://www.apache.org/dev/licensing-howto.html
--kevan
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: svn commit: r1488735 - in /incubator/public/trunk/tools: NOTICE.txt requirements.txt setup.py src/asf/utils/ src/asf/utils/__init__.py src/asf/utils/config.py src/asf/utils/file.py tests/test_config.py
Posted by Alan Cabrera <li...@toolazydogs.com>.
On Jun 2, 2013, at 5:29 PM, sebb <se...@gmail.com> wrote:
> On 3 June 2013 00:37, Alan Cabrera <li...@toolazydogs.com> wrote:
>>
>> On Jun 2, 2013, at 4:01 PM, sebb <se...@gmail.com> wrote:
>>
>>>> Modified: incubator/public/trunk/tools/NOTICE.txt
>>>> URL: http://svn.apache.org/viewvc/incubator/public/trunk/tools/NOTICE.txt?rev=1488735&r1=1488734&r2=1488735&view=diff
>>>> ==============================================================================
>>>> --- incubator/public/trunk/tools/NOTICE.txt (original)
>>>> +++ incubator/public/trunk/tools/NOTICE.txt Sun Jun 2 16:21:24 2013
>>>> @@ -1,5 +1,21 @@
>>>> =========================================================================
>>>> == NOTICE file corresponding to section 4(d) of the Apache License, ==
>>>> -== Version 1.0.0, in this case for the LiveTribe Utilities ==
>>>> +== Version 2.0.0, in this case for the ASF Incubator tools ==
>>>> == distribution. ==
>>>> =========================================================================
>>>> +
>>>> +This distribution contains code from the LinkedIn Corporation:
>>>> +
>>>> + Copyright (c) 2013 LinkedIn Corp. All rights reserved.
>>>> +
>>>> + Licensed under the Apache License, Version 2.0 (the "License");
>>>> + you may not use this file except in compliance with the License.
>>>> + You may obtain a copy of the License at
>>>> +
>>>> + http://www.apache.org/licenses/LICENSE-2.0
>>>> +
>>>> + Unless required by applicable law or agreed to in writing, software
>>>> + distributed under the License is distributed on an "AS IS" BASIS,
>>>> + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
>>>> + See the License for the specific language governing permissions and
>>>> + limitations under the License.
>>>
>>> That does not look like a standard NOTICE file.
>>> The part between === should not be present, and the AL 2.0 should not
>>> be there either.
>>>
>>> Is the notice entry even required by the Linked In license?
>>>
>>> Remember that NOTICE files are like poems - they are only correct when
>>> nothing more can be removed!
>>
>> Would this suffice:
>>
>> <begin>
>> This distribution contains code from the LinkedIn Corporation:
>>
>> Copyright (c) 2013 LinkedIn Corp. All rights reserved.
>> <end>j
>
> IMO, no.
>
> It's not a standard NOTICE file - the ASF header is missing.
Can you point to a canonical example for me to emulate?
Regards,
Alan
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: svn commit: r1488735 - in /incubator/public/trunk/tools:
NOTICE.txt requirements.txt setup.py src/asf/utils/ src/asf/utils/__init__.py
src/asf/utils/config.py src/asf/utils/file.py tests/test_config.py
Posted by sebb <se...@gmail.com>.
On 3 June 2013 00:37, Alan Cabrera <li...@toolazydogs.com> wrote:
>
> On Jun 2, 2013, at 4:01 PM, sebb <se...@gmail.com> wrote:
>
>>> Modified: incubator/public/trunk/tools/NOTICE.txt
>>> URL: http://svn.apache.org/viewvc/incubator/public/trunk/tools/NOTICE.txt?rev=1488735&r1=1488734&r2=1488735&view=diff
>>> ==============================================================================
>>> --- incubator/public/trunk/tools/NOTICE.txt (original)
>>> +++ incubator/public/trunk/tools/NOTICE.txt Sun Jun 2 16:21:24 2013
>>> @@ -1,5 +1,21 @@
>>> =========================================================================
>>> == NOTICE file corresponding to section 4(d) of the Apache License, ==
>>> -== Version 1.0.0, in this case for the LiveTribe Utilities ==
>>> +== Version 2.0.0, in this case for the ASF Incubator tools ==
>>> == distribution. ==
>>> =========================================================================
>>> +
>>> +This distribution contains code from the LinkedIn Corporation:
>>> +
>>> + Copyright (c) 2013 LinkedIn Corp. All rights reserved.
>>> +
>>> + Licensed under the Apache License, Version 2.0 (the "License");
>>> + you may not use this file except in compliance with the License.
>>> + You may obtain a copy of the License at
>>> +
>>> + http://www.apache.org/licenses/LICENSE-2.0
>>> +
>>> + Unless required by applicable law or agreed to in writing, software
>>> + distributed under the License is distributed on an "AS IS" BASIS,
>>> + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
>>> + See the License for the specific language governing permissions and
>>> + limitations under the License.
>>
>> That does not look like a standard NOTICE file.
>> The part between === should not be present, and the AL 2.0 should not
>> be there either.
>>
>> Is the notice entry even required by the Linked In license?
>>
>> Remember that NOTICE files are like poems - they are only correct when
>> nothing more can be removed!
>
> Would this suffice:
>
> <begin>
> This distribution contains code from the LinkedIn Corporation:
>
> Copyright (c) 2013 LinkedIn Corp. All rights reserved.
> <end>j
IMO, no.
It's not a standard NOTICE file - the ASF header is missing.
Anyway, does the LinkedIn license REQUIRE attribution in a NOTICE file?
>
> Regards,
> Alan
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: svn commit: r1488735 - in /incubator/public/trunk/tools: NOTICE.txt requirements.txt setup.py src/asf/utils/ src/asf/utils/__init__.py src/asf/utils/config.py src/asf/utils/file.py tests/test_config.py
Posted by Alan Cabrera <li...@toolazydogs.com>.
On Jun 2, 2013, at 4:01 PM, sebb <se...@gmail.com> wrote:
>> Modified: incubator/public/trunk/tools/NOTICE.txt
>> URL: http://svn.apache.org/viewvc/incubator/public/trunk/tools/NOTICE.txt?rev=1488735&r1=1488734&r2=1488735&view=diff
>> ==============================================================================
>> --- incubator/public/trunk/tools/NOTICE.txt (original)
>> +++ incubator/public/trunk/tools/NOTICE.txt Sun Jun 2 16:21:24 2013
>> @@ -1,5 +1,21 @@
>> =========================================================================
>> == NOTICE file corresponding to section 4(d) of the Apache License, ==
>> -== Version 1.0.0, in this case for the LiveTribe Utilities ==
>> +== Version 2.0.0, in this case for the ASF Incubator tools ==
>> == distribution. ==
>> =========================================================================
>> +
>> +This distribution contains code from the LinkedIn Corporation:
>> +
>> + Copyright (c) 2013 LinkedIn Corp. All rights reserved.
>> +
>> + Licensed under the Apache License, Version 2.0 (the "License");
>> + you may not use this file except in compliance with the License.
>> + You may obtain a copy of the License at
>> +
>> + http://www.apache.org/licenses/LICENSE-2.0
>> +
>> + Unless required by applicable law or agreed to in writing, software
>> + distributed under the License is distributed on an "AS IS" BASIS,
>> + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
>> + See the License for the specific language governing permissions and
>> + limitations under the License.
>
> That does not look like a standard NOTICE file.
> The part between === should not be present, and the AL 2.0 should not
> be there either.
>
> Is the notice entry even required by the Linked In license?
>
> Remember that NOTICE files are like poems - they are only correct when
> nothing more can be removed!
Would this suffice:
<begin>
This distribution contains code from the LinkedIn Corporation:
Copyright (c) 2013 LinkedIn Corp. All rights reserved.
<end>j
Regards,
Alan
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org