You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by Jeremy Karn <jk...@mortardata.com> on 2013/01/08 16:43:38 UTC

Problem creating patch for HADOOP-9184

I opened this jira yesterday and tried to include a patch for the problem
but the Jenkins pre-commit job keeps failing because it says it can't apply
my patch (https://builds.apache.org/job/PreCommit-HADOOP-Build/2012//console).
 I thought at first the problem was because I generated the patch with git,
but I've since done a svn checkout, regenerated the patch file, and been
able to apply the commit locally without a problem.

Any help would be appreciated!  Thanks,

-- 

Jeremy Karn / Lead Developer
MORTAR DATA / www.mortardata.com

Re: Problem creating patch for HADOOP-9184

Posted by Robert Evans <ev...@yahoo-inc.com>.
http://wiki.apache.org/hadoop/HowToContribute should explain it.  There
are sections for both pre and post mavinization.  Look for test-patch.sh
which is the script you run for the 1.0 branch

--Bobby

On 1/10/13 9:54 AM, "Jeremy Karn" <jk...@mortardata.com> wrote:

>The patch doesn't apply to trunk (I'm not that familiar with the latest
>code structure but it looks like the problem doesn't exist in trunk), but
>I'm not sure what I'm suppose to run for a non-trunk commit.  The
>dev-support directory doesn't exist and there's no pre-commit ant target
>for the 0.20 branch.  I tried running the test-contrib target but I was
>having tests fail because of timeouts.
>
>Is there documentation somewhere about what I should post to the jira for
>an older commit?
>
>
>On Tue, Jan 8, 2013 at 10:53 AM, Jeremy Karn <jk...@mortardata.com> wrote:
>
>> Thanks!
>>
>>
>> On Tue, Jan 8, 2013 at 10:48 AM, Robert Evans <ev...@yahoo-inc.com>
>>wrote:
>>
>>> This is because your patch is against the 0.20 branch, not against
>>>trunk.
>>> Jenkins pre commit only works for trunk right now.  If the issue also
>>> exists on trunk then please provide a patch for trunk too, if it is a
>>> 1.0/0.20 specific issue then you
>>>
>>
>>


Re: Problem creating patch for HADOOP-9184

Posted by Jeremy Karn <jk...@mortardata.com>.
The patch doesn't apply to trunk (I'm not that familiar with the latest
code structure but it looks like the problem doesn't exist in trunk), but
I'm not sure what I'm suppose to run for a non-trunk commit.  The
dev-support directory doesn't exist and there's no pre-commit ant target
for the 0.20 branch.  I tried running the test-contrib target but I was
having tests fail because of timeouts.

Is there documentation somewhere about what I should post to the jira for
an older commit?


On Tue, Jan 8, 2013 at 10:53 AM, Jeremy Karn <jk...@mortardata.com> wrote:

> Thanks!
>
>
> On Tue, Jan 8, 2013 at 10:48 AM, Robert Evans <ev...@yahoo-inc.com> wrote:
>
>> This is because your patch is against the 0.20 branch, not against trunk.
>> Jenkins pre commit only works for trunk right now.  If the issue also
>> exists on trunk then please provide a patch for trunk too, if it is a
>> 1.0/0.20 specific issue then you
>>
>
>

Re: Problem creating patch for HADOOP-9184

Posted by Jeremy Karn <jk...@mortardata.com>.
Thanks!

On Tue, Jan 8, 2013 at 10:48 AM, Robert Evans <ev...@yahoo-inc.com> wrote:

> This is because your patch is against the 0.20 branch, not against trunk.
> Jenkins pre commit only works for trunk right now.  If the issue also
> exists on trunk then please provide a patch for trunk too, if it is a
> 1.0/0.20 specific issue then you
>

Re: Problem creating patch for HADOOP-9184

Posted by Robert Evans <ev...@yahoo-inc.com>.
This is because your patch is against the 0.20 branch, not against trunk.
Jenkins pre commit only works for trunk right now.  If the issue also
exists on trunk then please provide a patch for trunk too, if it is a
1.0/0.20 specific issue then you can run the pre commit tests yourself and
just post the results.

--Bobby

On 1/8/13 9:43 AM, "Jeremy Karn" <jk...@mortardata.com> wrote:

>I opened this jira yesterday and tried to include a patch for the problem
>but the Jenkins pre-commit job keeps failing because it says it can't
>apply
>my patch 
>(https://builds.apache.org/job/PreCommit-HADOOP-Build/2012//console).
> I thought at first the problem was because I generated the patch with
>git,
>but I've since done a svn checkout, regenerated the patch file, and been
>able to apply the commit locally without a problem.
>
>Any help would be appreciated!  Thanks,
>
>-- 
>
>Jeremy Karn / Lead Developer
>MORTAR DATA / www.mortardata.com