[GitHub] [activemq-artemis] jbertram opened a new pull request #3669: ARTEMIS-3399 fix audit logging for AMQP

[GitBox <gi...@apache.org>]

jbertram opened a new pull request #3669:
URL: https://github.com/apache/activemq-artemis/pull/3669


   Due to the multi-threaded AMQP implementation the ThreadLocal variables
   used by the AuditLogger to track the username and remote address don't
   work properly. Changes include:
   
    - Passing the audit Subject (set during authentication) and the remote
      address explicitly for audit logging on the relevant ServerSession
      methods rather than relying on the AuditLogger's ThreadLocal
      variables
    - Audit logging core session creation *after* successful authentication
      so that we have the proper Subject; this is especially important for
      the SSL certificate authentication use-case
    - Renaming some methods and variables in AuditLogger to more accurately
      reflect their intended use
    - Adding JavaDoc and refactoring the getCaller methods on AuditLogger
    - Refactor audit log testing and add a new test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-artemis] asfgit closed pull request #3669: Audit logging updates

[GitBox <gi...@apache.org>]

asfgit closed pull request #3669:
URL: https://github.com/apache/activemq-artemis/pull/3669


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org