You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "gerlowskija (via GitHub)" <gi...@apache.org> on 2023/04/16 19:35:56 UTC
[GitHub] [solr] gerlowskija opened a new pull request, #1572: SOLR-16391: Tweak "create coll" API to be more REST-ful
gerlowskija opened a new pull request, #1572:
URL: https://github.com/apache/solr/pull/1572
https://issues.apache.org/jira/browse/SOLR-16391
# Description
Solr is currently making slow progress in moving its v2 APIs in a more REST-ful direction. Many APIs have been improved, but many remaining including the commonly used API to create collections.
# Solution
This commit makes various cosmetic improvements to Solr's v2 create collection API, to bring it more into line with the more REST-ful v2 design. This mostly includes tweaking a few parameter names, and removing the "create" top-level key representing the "command".
It also migrates the API definition to JAX-RS.
# Tests
Unit tests for converting between the v1 and v2 parameter formats have been added in `CreateCollectionAPITest`.
# Checklist
Please review the following and check all that apply:
- [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [x] I have created a Jira issue and added the issue ID to my pull request title.
- [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [x] I have developed this patch against the `main` branch.
- [ ] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
- [x] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] gerlowskija commented on pull request #1572: SOLR-16391: Tweak "create coll" API to be more REST-ful
Posted by "gerlowskija (via GitHub)" <gi...@apache.org>.
gerlowskija commented on PR #1572:
URL: https://github.com/apache/solr/pull/1572#issuecomment-1511692830
Tests and 'check' pass! Will aim to merge in a few days since the bulk of this code has been available for review for some time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] gerlowskija merged pull request #1572: SOLR-16391: Tweak "create coll" API to be more REST-ful
Posted by "gerlowskija (via GitHub)" <gi...@apache.org>.
gerlowskija merged PR #1572:
URL: https://github.com/apache/solr/pull/1572
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] gerlowskija commented on pull request #1572: SOLR-16391: Tweak "create coll" API to be more REST-ful
Posted by "gerlowskija (via GitHub)" <gi...@apache.org>.
gerlowskija commented on PR #1572:
URL: https://github.com/apache/solr/pull/1572#issuecomment-1510470765
With the exception of a few tests that are unique to this PR, the code here all comes from #1453. I'm in the process of splitting that PR up into smaller chunks, of which this is one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org