You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Tomasz Janiszewski <ja...@gmail.com> on 2017/10/25 21:41:28 UTC
Review Request 63314: Add support for Ubuntu 16.04 in docker build.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63314/
-----------------------------------------------------------
Review request for mesos, Jie Yu and Vinod Kone.
Repository: mesos
Description
-------
Add support for Ubuntu 16.04 in docker build.
Diffs
-----
support/docker-build.sh 50e693ca71d499f71f2935923f4691feef560b12
Diff: https://reviews.apache.org/r/63314/diff/1/
Testing
-------
Thanks,
Tomasz Janiszewski
Re: Review Request 63314: Add support for Ubuntu 16.04 in docker
build.
Posted by Vinod Kone <vi...@apache.org>.
> On Oct. 26, 2017, 7:55 a.m., Vinod Kone wrote:
> > support/docker-build.sh
> > Lines 72 (patched)
> > <https://reviews.apache.org/r/63314/diff/1/?file=1869001#file1869001line72>
> >
> > do we need to install `zlib1g-dev` explicitly in ubuntu 16.04 but not in other versions?
>
> Tomasz Janiszewski wrote:
> I'm not sure if we need it in 14.04. I follow instructions from [getting started](http://mesos.apache.org/documentation/latest/building/#ubuntu-14-04) and it looks like this are the only difference between 14.04 and 16.04 https://www.diffchecker.com/Aj4N9M8y
>
> Tomasz Janiszewski wrote:
> @vindo Should I add this package to 14.04 scrip too even if it's not required?
That's fine.
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63314/#review189278
-----------------------------------------------------------
On Oct. 26, 2017, 8:08 a.m., Tomasz Janiszewski wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63314/
> -----------------------------------------------------------
>
> (Updated Oct. 26, 2017, 8:08 a.m.)
>
>
> Review request for mesos, Jie Yu and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add support for Ubuntu 16.04 in docker build.
>
>
> Diffs
> -----
>
> support/docker-build.sh 50e693ca71d499f71f2935923f4691feef560b12
>
>
> Diff: https://reviews.apache.org/r/63314/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Tomasz Janiszewski
>
>
Re: Review Request 63314: Add support for Ubuntu 16.04 in docker
build.
Posted by Tomasz Janiszewski <ja...@gmail.com>.
> On Oct. 26, 2017, 7:55 a.m., Vinod Kone wrote:
> > support/docker-build.sh
> > Lines 72 (patched)
> > <https://reviews.apache.org/r/63314/diff/1/?file=1869001#file1869001line72>
> >
> > do we need to install `zlib1g-dev` explicitly in ubuntu 16.04 but not in other versions?
I'm not sure if we need it in 14.04. I follow instructions from [getting started](http://mesos.apache.org/documentation/latest/building/#ubuntu-14-04) and it looks like this are the only difference between 14.04 and 16.04 https://www.diffchecker.com/Aj4N9M8y
- Tomasz
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63314/#review189278
-----------------------------------------------------------
On Oct. 26, 2017, 8:08 a.m., Tomasz Janiszewski wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63314/
> -----------------------------------------------------------
>
> (Updated Oct. 26, 2017, 8:08 a.m.)
>
>
> Review request for mesos, Jie Yu and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add support for Ubuntu 16.04 in docker build.
>
>
> Diffs
> -----
>
> support/docker-build.sh 50e693ca71d499f71f2935923f4691feef560b12
>
>
> Diff: https://reviews.apache.org/r/63314/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Tomasz Janiszewski
>
>
Re: Review Request 63314: Add support for Ubuntu 16.04 in docker
build.
Posted by Tomasz Janiszewski <ja...@gmail.com>.
> On Oct. 26, 2017, 7:55 a.m., Vinod Kone wrote:
> > support/docker-build.sh
> > Lines 72 (patched)
> > <https://reviews.apache.org/r/63314/diff/1/?file=1869001#file1869001line72>
> >
> > do we need to install `zlib1g-dev` explicitly in ubuntu 16.04 but not in other versions?
>
> Tomasz Janiszewski wrote:
> I'm not sure if we need it in 14.04. I follow instructions from [getting started](http://mesos.apache.org/documentation/latest/building/#ubuntu-14-04) and it looks like this are the only difference between 14.04 and 16.04 https://www.diffchecker.com/Aj4N9M8y
@vindo Should I add this package to 14.04 scrip too even if it's not required?
- Tomasz
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63314/#review189278
-----------------------------------------------------------
On Oct. 26, 2017, 8:08 a.m., Tomasz Janiszewski wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63314/
> -----------------------------------------------------------
>
> (Updated Oct. 26, 2017, 8:08 a.m.)
>
>
> Review request for mesos, Jie Yu and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add support for Ubuntu 16.04 in docker build.
>
>
> Diffs
> -----
>
> support/docker-build.sh 50e693ca71d499f71f2935923f4691feef560b12
>
>
> Diff: https://reviews.apache.org/r/63314/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Tomasz Janiszewski
>
>
Re: Review Request 63314: Add support for Ubuntu 16.04 in docker
build.
Posted by Vinod Kone <vi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63314/#review189278
-----------------------------------------------------------
support/docker-build.sh
Lines 65-67 (original), 65-67 (patched)
<https://reviews.apache.org/r/63314/#comment266290>
not yours but can you change
s/-y install/install -y/ for consistency?
support/docker-build.sh
Lines 72 (patched)
<https://reviews.apache.org/r/63314/#comment266291>
do we need to install `zlib1g-dev` explicitly in ubuntu 16.04 but not in other versions?
- Vinod Kone
On Oct. 25, 2017, 9:41 p.m., Tomasz Janiszewski wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63314/
> -----------------------------------------------------------
>
> (Updated Oct. 25, 2017, 9:41 p.m.)
>
>
> Review request for mesos, Jie Yu and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add support for Ubuntu 16.04 in docker build.
>
>
> Diffs
> -----
>
> support/docker-build.sh 50e693ca71d499f71f2935923f4691feef560b12
>
>
> Diff: https://reviews.apache.org/r/63314/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Tomasz Janiszewski
>
>
Re: Review Request 63314: Add support for Ubuntu 16.04 in docker
build.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63314/#review189376
-----------------------------------------------------------
Patch looks great!
Reviews applied: [63314]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Oct. 26, 2017, 8:08 a.m., Tomasz Janiszewski wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63314/
> -----------------------------------------------------------
>
> (Updated Oct. 26, 2017, 8:08 a.m.)
>
>
> Review request for mesos, Jie Yu and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add support for Ubuntu 16.04 in docker build.
>
>
> Diffs
> -----
>
> support/docker-build.sh 50e693ca71d499f71f2935923f4691feef560b12
>
>
> Diff: https://reviews.apache.org/r/63314/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Tomasz Janiszewski
>
>
Re: Review Request 63314: Add support for Ubuntu 16.04 in docker
build.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63314/#review189437
-----------------------------------------------------------
PASS: Mesos patch 63314 was successfully built and tested.
Reviews applied: `['63314']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63314
- Mesos Reviewbot Windows
On Oct. 26, 2017, 8:08 a.m., Tomasz Janiszewski wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63314/
> -----------------------------------------------------------
>
> (Updated Oct. 26, 2017, 8:08 a.m.)
>
>
> Review request for mesos, Jie Yu and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add support for Ubuntu 16.04 in docker build.
>
>
> Diffs
> -----
>
> support/docker-build.sh 50e693ca71d499f71f2935923f4691feef560b12
>
>
> Diff: https://reviews.apache.org/r/63314/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Tomasz Janiszewski
>
>
Re: Review Request 63314: Add support for Ubuntu 16.04 in docker
build.
Posted by Tomasz Janiszewski <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63314/
-----------------------------------------------------------
(Updated Oct. 26, 2017, 8:08 a.m.)
Review request for mesos, Jie Yu and Vinod Kone.
Changes
-------
Make `apt-get install -y` consistent
Repository: mesos
Description
-------
Add support for Ubuntu 16.04 in docker build.
Diffs (updated)
-----
support/docker-build.sh 50e693ca71d499f71f2935923f4691feef560b12
Diff: https://reviews.apache.org/r/63314/diff/2/
Changes: https://reviews.apache.org/r/63314/diff/1-2/
Testing
-------
Thanks,
Tomasz Janiszewski