You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Ka-Hing Cheung <no...@github.com> on 2015/06/11 03:10:12 UTC

[jclouds] use segment names similar to those created by python-swiftclient (#770)

Currently swift creates blob-1, blob-2... blob-n for multipart
upload segments, which are very common names that can easily
collide with normal objects. This changes the naming convention
to that of python-swiftclient (the `swift' command line).

python-swiftclient also uses a different segment container by
default, that's not implemented by this patch
You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds/pull/770

-- Commit Summary --

  * use segment names similar to those created by python-swiftclient

-- File Changes --

    M apis/openstack-swift/src/main/java/org/jclouds/openstack/swift/v1/blobstore/RegionScopedSwiftBlobStore.java (30)

-- Patch Links --

https://github.com/jclouds/jclouds/pull/770.patch
https://github.com/jclouds/jclouds/pull/770.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/770

Re: [jclouds] use segment names similar to those created by python-swiftclient (#770)

Posted by Andrew Gaul <no...@github.com>.
Closed #770.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/770#event-335752357

Re: [jclouds] use segment names similar to those created by python-swiftclient (#770)

Posted by Andrew Gaul <no...@github.com>.
@kahing Overall agree with the approach.

@zack-shoylev What do you think?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/770#issuecomment-110963045

Re: [jclouds] use segment names similar to those created by python-swiftclient (#770)

Posted by Ka-Hing Cheung <no...@github.com>.
> @@ -410,7 +410,16 @@ public long countBlobs(String containerName) {
>  
>     @Override
>     public MultipartUpload initiateMultipartUpload(String container, BlobMetadata blobMetadata) {
> -      String uploadId = UUID.randomUUID().toString();

done

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/770/files#r32187887

Re: [jclouds] use segment names similar to those created by python-swiftclient (#770)

Posted by Andrew Gaul <no...@github.com>.
> @@ -410,7 +410,16 @@ public long countBlobs(String containerName) {
>  
>     @Override
>     public MultipartUpload initiateMultipartUpload(String container, BlobMetadata blobMetadata) {
> -      String uploadId = UUID.randomUUID().toString();

Call `initiateMultipartUpload(container, blobMetadata, 0)`?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/770/files#r32183494