You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "pefernan (via GitHub)" <gi...@apache.org> on 2025/03/06 15:14:50 UTC
[PR] [NO-ISSUE] Add missing dependencies to `dev-deployment-kogito-quarkus-blank-app` [incubator-kie-tools]
pefernan opened a new pull request, #2965:
URL: https://github.com/apache/incubator-kie-tools/pull/2965
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [NO-ISSUE] Add missing dependencies to `dev-deployment-kogito-quarkus-blank-app` [incubator-kie-tools]
Posted by "thiagoelg (via GitHub)" <gi...@apache.org>.
thiagoelg commented on code in PR #2965:
URL: https://github.com/apache/incubator-kie-tools/pull/2965#discussion_r1984060992
##########
packages/dev-deployment-kogito-quarkus-blank-app/pom.xml:
##########
@@ -179,23 +233,6 @@
<value>!true</value>
</property>
</activation>
- <dependencyManagement>
- <dependencies>
- <dependency>
- <groupId>org.jbpm</groupId>
- <artifactId>jbpm-quarkus-devui-bom</artifactId>
- <version>${project.version}</version>
- <type>pom</type>
- <scope>import</scope>
- </dependency>
- </dependencies>
- </dependencyManagement>
- <dependencies>
- <dependency>
- <groupId>org.jbpm</groupId>
- <artifactId>jbpm-quarkus-devui</artifactId>
- </dependency>
- </dependencies>
Review Comment:
Removed the jbpm-quarkus-devui dependency since it doesn't work in Dev Deployments after upgrading to Quarkus 3.15.3 (similar to https://github.com/apache/incubator-kie-issues/issues/1818)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [NO-ISSUE] Add missing dependencies to `dev-deployment-kogito-quarkus-blank-app` [incubator-kie-tools]
Posted by "tiagobento (via GitHub)" <gi...@apache.org>.
tiagobento commented on code in PR #2965:
URL: https://github.com/apache/incubator-kie-tools/pull/2965#discussion_r1985106300
##########
packages/dev-deployment-kogito-quarkus-blank-app/pom.xml:
##########
@@ -179,23 +233,6 @@
<value>!true</value>
</property>
</activation>
- <dependencyManagement>
- <dependencies>
- <dependency>
- <groupId>org.jbpm</groupId>
- <artifactId>jbpm-quarkus-devui-bom</artifactId>
- <version>${project.version}</version>
- <type>pom</type>
- <scope>import</scope>
- </dependency>
- </dependencies>
- </dependencyManagement>
- <dependencies>
- <dependency>
- <groupId>org.jbpm</groupId>
- <artifactId>jbpm-quarkus-devui</artifactId>
- </dependency>
- </dependencies>
Review Comment:
This will be back once we go to 3.16+, though, right? I think I remember this conversation in the past somewhere. Thank you @thiagoelg!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [NO-ISSUE] Add missing dependencies to `dev-deployment-kogito-quarkus-blank-app` [incubator-kie-tools]
Posted by "thiagoelg (via GitHub)" <gi...@apache.org>.
thiagoelg commented on code in PR #2965:
URL: https://github.com/apache/incubator-kie-tools/pull/2965#discussion_r1984063518
##########
packages/online-editor/src/devDeployments/services/deploymentOptions/kogitoQuarkusBlankApp/DeploymentYaml.ts:
##########
@@ -52,7 +52,7 @@ spec:
imagePullPolicy: ${args.imagePullPolicy}
resources:
limits:
- memory: "2048Mi"
+ memory: "4Gi"
Review Comment:
With the new dependencies, the Dev Deployment is using a lot more memory for some reason. Interestingly, OpenShift uses about 1.5Gb while a minikube cluster will pull almost 3Gb for the same container image.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [NO-ISSUE] Add missing dependencies to `dev-deployment-kogito-quarkus-blank-app` [incubator-kie-tools]
Posted by "tiagobento (via GitHub)" <gi...@apache.org>.
tiagobento commented on PR #2965:
URL: https://github.com/apache/incubator-kie-tools/pull/2965#issuecomment-2706970361
There are still some adjustments to be made on Management Console to overcome the Dev deployment pointing to 0.0.0.0:8080, but it will be addressed on a separate PR. Thank you @pefernan @thiagoelg
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [NO-ISSUE] Add missing dependencies to `dev-deployment-kogito-quarkus-blank-app` [incubator-kie-tools]
Posted by "thiagoelg (via GitHub)" <gi...@apache.org>.
thiagoelg commented on code in PR #2965:
URL: https://github.com/apache/incubator-kie-tools/pull/2965#discussion_r1984063518
##########
packages/online-editor/src/devDeployments/services/deploymentOptions/kogitoQuarkusBlankApp/DeploymentYaml.ts:
##########
@@ -52,7 +52,7 @@ spec:
imagePullPolicy: ${args.imagePullPolicy}
resources:
limits:
- memory: "2048Mi"
+ memory: "4Gi"
Review Comment:
With these changes, the Dev Deployment is using a lot more memory for some reason. Interestingly, OpenShift uses about 1.5Gb while a minikube cluster will pull almost 3Gb for the same container image.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [NO-ISSUE] Add missing dependencies to `dev-deployment-kogito-quarkus-blank-app` [incubator-kie-tools]
Posted by "thiagoelg (via GitHub)" <gi...@apache.org>.
thiagoelg commented on code in PR #2965:
URL: https://github.com/apache/incubator-kie-tools/pull/2965#discussion_r1984061484
##########
packages/dev-deployment-kogito-quarkus-blank-app/src/main/resources/application.properties:
##########
@@ -17,11 +17,56 @@
# under the License.
#
+###############
+# Development #
+###############
+
+# Swagger Dev UI configuration.
+# More at https://quarkus.io/guides/openapi-swaggerui
+
quarkus.swagger-ui.always-include=true
quarkus.http.cors=true
quarkus.http.cors.origins=*
quarkus.dev-ui.cors.enabled=false
-kogito.service.url=http://localhost:8080
+
+#####################################
+# Services definition
+#####################################
+kogito.service.url=http://${quarkus.http.host}:${quarkus.http.port}${quarkus.http.root-path}
+kogito.jobs-service.url=http://${quarkus.http.host}:${quarkus.http.port}${quarkus.http.root-path}
+kogito.data-index.url=http://${quarkus.http.host}:${quarkus.http.port}${quarkus.http.root-path}
quarkus.http.host=0.0.0.0
quarkus.devservices.enabled=false
+
+quarkus.kogito.data-index.graphql.ui.always-include=true
+
+###############
+# Persistence #
+###############
+
+# Apache KIE provides a separate Flyway subsystem that allows Kogito's internal tables to be created and migrated
+# without interfering with your application's Flyway, if you're using it.
+#
+# This property enables running this isolated Flyway mechanism automatically when the application starts.
+# If you want more control over when/how/who executes changes to your database, disable it and run the SQL scripts manually.
+kie.flyway.enabled=true
+
+# Tells the Kogito runtime what kind of persistence is configured.
+kogito.persistence.type=jdbc
+
+# Default DS
+quarkus.datasource.db-kind=h2
+quarkus.datasource.username=kie
+quarkus.datasource.jdbc.url=jdbc:h2:mem:default;NON_KEYWORDS=VALUE,KEY
+
+############
+# Security #
+############
+
+# Keeping it disabled for simplicity.
+quarkus.oidc.enabled=false
+kogito.auth.enabled=false
+
+quarkus.keycloak.devservices.create-realm=false
+quarkus.keycloak.devservices.enabled=false
Review Comment:
I don't know if this does anything, but I noticed they were enabled before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [NO-ISSUE] Add missing dependencies to `dev-deployment-kogito-quarkus-blank-app` [incubator-kie-tools]
Posted by "thiagoelg (via GitHub)" <gi...@apache.org>.
thiagoelg commented on code in PR #2965:
URL: https://github.com/apache/incubator-kie-tools/pull/2965#discussion_r1985247333
##########
packages/dev-deployment-kogito-quarkus-blank-app/pom.xml:
##########
@@ -179,23 +233,6 @@
<value>!true</value>
</property>
</activation>
- <dependencyManagement>
- <dependencies>
- <dependency>
- <groupId>org.jbpm</groupId>
- <artifactId>jbpm-quarkus-devui-bom</artifactId>
- <version>${project.version}</version>
- <type>pom</type>
- <scope>import</scope>
- </dependency>
- </dependencies>
- </dependencyManagement>
- <dependencies>
- <dependency>
- <groupId>org.jbpm</groupId>
- <artifactId>jbpm-quarkus-devui</artifactId>
- </dependency>
- </dependencies>
Review Comment:
Yes! Quarkus 3.16 supports regex on the `quarkus.dev-ui.hosts` property.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [NO-ISSUE] Add missing dependencies to `dev-deployment-kogito-quarkus-blank-app` [incubator-kie-tools]
Posted by "tiagobento (via GitHub)" <gi...@apache.org>.
tiagobento merged PR #2965:
URL: https://github.com/apache/incubator-kie-tools/pull/2965
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [NO-ISSUE] Add missing dependencies to `dev-deployment-kogito-quarkus-blank-app` [incubator-kie-tools]
Posted by "thiagoelg (via GitHub)" <gi...@apache.org>.
thiagoelg commented on code in PR #2965:
URL: https://github.com/apache/incubator-kie-tools/pull/2965#discussion_r1985251657
##########
packages/dev-deployment-kogito-quarkus-blank-app/pom.xml:
##########
@@ -179,23 +233,6 @@
<value>!true</value>
</property>
</activation>
- <dependencyManagement>
- <dependencies>
- <dependency>
- <groupId>org.jbpm</groupId>
- <artifactId>jbpm-quarkus-devui-bom</artifactId>
- <version>${project.version}</version>
- <type>pom</type>
- <scope>import</scope>
- </dependency>
- </dependencies>
- </dependencyManagement>
- <dependencies>
- <dependency>
- <groupId>org.jbpm</groupId>
- <artifactId>jbpm-quarkus-devui</artifactId>
- </dependency>
- </dependencies>
Review Comment:
https://github.com/apache/incubator-kie-issues/issues/1863
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [NO-ISSUE] Add missing dependencies to `dev-deployment-kogito-quarkus-blank-app` [incubator-kie-tools]
Posted by "thiagoelg (via GitHub)" <gi...@apache.org>.
thiagoelg commented on code in PR #2965:
URL: https://github.com/apache/incubator-kie-tools/pull/2965#discussion_r1984065245
##########
packages/dev-deployment-kogito-quarkus-blank-app-image/Containerfile:
##########
@@ -22,15 +22,15 @@ FROM --platform=linux/amd64 ${BUILDER_IMAGE_ARG}
USER root
-ENV ROOT_PATH=""
+ENV ROOT_PATH="/"
ENV DEV_DEPLOYMENT__UPLOAD_SERVICE_EXTRACT_TO_DIR=$HOME_PATH/app/src/main/resources
ENV DEV_DEPLOYMENT__UPLOAD_SERVICE_PORT=8080
COPY --chown=$USER_ID:$USER_ID dist-dev/quarkus-app $HOME_PATH/app/
COPY --chown=$USER_ID:$USER_ID dist-dev/settings.xml /tmp/kogito/.m2/settings.xml
# Pre-populate local Maven repository for faster startup
-RUN ./mvnw -Dmaven=3.9.6 clean package -B -nsu --settings /tmp/kogito/.m2/settings.xml -Dmaven.test.skip -Dmaven.repo.local=/tmp/kogito/.m2/repository -Dquarkus.http.non-application-root-path=${ROOT_PATH}/q -Dquarkus.http.root-path=${ROOT_PATH} \
Review Comment:
`quarkus.http.non-application-root-path` works properly on Quarkus 3.15 and respects the `quarkus.http.root-path` setting, so we no longer need to override it.
##########
packages/dev-deployment-kogito-quarkus-blank-app-image/Containerfile:
##########
@@ -39,4 +39,4 @@ EXPOSE 8080
ENTRYPOINT ["/bin/bash", "-c"]
-CMD ["dev-deployment-upload-service && cp -r $HOME_PATH/app/. /tmp/app && cd /tmp/app && ./mvnw -Dmaven=3.9.6 quarkus:dev -o -s=/tmp/kogito/.m2/settings.xml -Dquarkus.analytics.disabled=true -Ddebug=false -Dmaven.repo.local=/tmp/kogito/.m2/repository -Dquarkus.http.non-application-root-path=${ROOT_PATH}/q -Dquarkus.http.root-path=${ROOT_PATH}"]
Review Comment:
`quarkus.http.non-application-root-path` works properly on Quarkus 3.15 and respects the `quarkus.http.root-path` setting, so we no longer need to override it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [NO-ISSUE] Add missing dependencies to `dev-deployment-kogito-quarkus-blank-app` [incubator-kie-tools]
Posted by "thiagoelg (via GitHub)" <gi...@apache.org>.
thiagoelg commented on code in PR #2965:
URL: https://github.com/apache/incubator-kie-tools/pull/2965#discussion_r1984065245
##########
packages/dev-deployment-kogito-quarkus-blank-app-image/Containerfile:
##########
@@ -22,15 +22,15 @@ FROM --platform=linux/amd64 ${BUILDER_IMAGE_ARG}
USER root
-ENV ROOT_PATH=""
+ENV ROOT_PATH="/"
ENV DEV_DEPLOYMENT__UPLOAD_SERVICE_EXTRACT_TO_DIR=$HOME_PATH/app/src/main/resources
ENV DEV_DEPLOYMENT__UPLOAD_SERVICE_PORT=8080
COPY --chown=$USER_ID:$USER_ID dist-dev/quarkus-app $HOME_PATH/app/
COPY --chown=$USER_ID:$USER_ID dist-dev/settings.xml /tmp/kogito/.m2/settings.xml
# Pre-populate local Maven repository for faster startup
-RUN ./mvnw -Dmaven=3.9.6 clean package -B -nsu --settings /tmp/kogito/.m2/settings.xml -Dmaven.test.skip -Dmaven.repo.local=/tmp/kogito/.m2/repository -Dquarkus.http.non-application-root-path=${ROOT_PATH}/q -Dquarkus.http.root-path=${ROOT_PATH} \
Review Comment:
`quarkus.http.non-application-root-path` works properly on Quarkus 3.15 and respects the `quarkus.http.root-path` setting, so we no longer need to override it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org