You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/18 12:06:42 UTC

[GitHub] [spark] ScrapCodes opened a new pull request #27948: [WIP][SPARK-30715][k8s][FOLLOW-UP] Update k8s client version in integratio…

ScrapCodes opened a new pull request #27948: [WIP][SPARK-30715][k8s][FOLLOW-UP] Update k8s client version in integratio…
URL: https://github.com/apache/spark/pull/27948
 
 
   …n tests as well.
   
   ### What changes were proposed in this pull request?
   Kubernetes client version in sync in integration-tests and kubernetes/core
   
   ### Why are the changes needed?
   More than once, the kubernetes client version has gone out of sync between integration tests and kubernetes/core. So brought them up in sync again and added a comment to save us from future need of this additional followup.
   
   
   
   ### Does this PR introduce any user-facing change?
   No
   
   
   ### How was this patch tested?
   Manually.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27948: [WIP][SPARK-30715][k8s][FOLLOW-UP] Update k8s client version in integratio…

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27948: [WIP][SPARK-30715][k8s][FOLLOW-UP] Update k8s client version in integratio…
URL: https://github.com/apache/spark/pull/27948#issuecomment-600673180
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119990/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27948: [WIP][SPARK-30715][k8s][FOLLOW-UP] Update k8s client version in integratio…

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27948: [WIP][SPARK-30715][k8s][FOLLOW-UP] Update k8s client version in integratio…
URL: https://github.com/apache/spark/pull/27948#issuecomment-600673176
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun closed pull request #27948: [SPARK-30715][K8S][TESTS][FOLLOWUP] Update k8s client version in IT as well

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #27948: [SPARK-30715][K8S][TESTS][FOLLOWUP] Update k8s client version in IT as well
URL: https://github.com/apache/spark/pull/27948
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on issue #27948: [WIP][SPARK-30715][k8s][FOLLOW-UP] Update k8s client version in integratio…

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27948: [WIP][SPARK-30715][k8s][FOLLOW-UP] Update k8s client version in integratio…
URL: https://github.com/apache/spark/pull/27948#issuecomment-600587486
 
 
   **[Test build #119990 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119990/testReport)** for PR 27948 at commit [`0a6b227`](https://github.com/apache/spark/commit/0a6b2270ccb9cc5cdc859022fc80c889151ea88b).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27948: [WIP][SPARK-30715][k8s][FOLLOW-UP] Update k8s client version in integratio…

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27948: [WIP][SPARK-30715][k8s][FOLLOW-UP] Update k8s client version in integratio…
URL: https://github.com/apache/spark/pull/27948#issuecomment-600673180
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119990/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #27948: [SPARK-30715][k8s][FOLLOW-UP] Update k8s client version in IT as well

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #27948: [SPARK-30715][k8s][FOLLOW-UP] Update k8s client version in IT as well
URL: https://github.com/apache/spark/pull/27948#discussion_r396043279
 
 

 ##########
 File path: resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/KubernetesSuite.scala
 ##########
 @@ -61,15 +61,15 @@ class KubernetesSuite extends SparkFunSuite
   protected var appLocator: String = _
 
   // Default memory limit is 1024M + 384M (minimum overhead constant)
-  private val baseMemory = s"${1024 + 384}Mi"
 
 Review comment:
   Thanks!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] ScrapCodes commented on a change in pull request #27948: [SPARK-30715][k8s][FOLLOW-UP] Update k8s client version in integratio…

Posted by GitBox <gi...@apache.org>.
ScrapCodes commented on a change in pull request #27948: [SPARK-30715][k8s][FOLLOW-UP] Update k8s client version in integratio…
URL: https://github.com/apache/spark/pull/27948#discussion_r394898775
 
 

 ##########
 File path: resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/KubernetesSuite.scala
 ##########
 @@ -61,15 +61,15 @@ class KubernetesSuite extends SparkFunSuite
   protected var appLocator: String = _
 
   // Default memory limit is 1024M + 384M (minimum overhead constant)
-  private val baseMemory = s"${1024 + 384}Mi"
 
 Review comment:
   To be precise, in 4.7.1 Quantity constructor tries to parse the amount into format and the amount. [link](https://github.com/fabric8io/kubernetes-client/blob/v4.7.1/kubernetes-model/kubernetes-model/src/main/java/io/fabric8/kubernetes/api/model/Quantity.java#L69)
   And in 4.6.4, It does not. [link](https://github.com/fabric8io/kubernetes-client/blob/v4.6.4/kubernetes-model/kubernetes-model/src/main/java/io/fabric8/kubernetes/api/model/Quantity.java#L65)
   More details here : https://github.com/fabric8io/kubernetes-client/commit/c370d2628aa5da6b7217486373e16a35d7013df2 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #27948: [WIP][SPARK-30715][k8s][FOLLOW-UP] Update k8s client version in integratio…

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27948: [WIP][SPARK-30715][k8s][FOLLOW-UP] Update k8s client version in integratio…
URL: https://github.com/apache/spark/pull/27948#issuecomment-600613766
 
 
   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/24711/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27948: [WIP][SPARK-30715][k8s][FOLLOW-UP] Update k8s client version in integratio…

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27948: [WIP][SPARK-30715][k8s][FOLLOW-UP] Update k8s client version in integratio…
URL: https://github.com/apache/spark/pull/27948#issuecomment-600623876
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27948: [WIP][SPARK-30715][k8s][FOLLOW-UP] Update k8s client version in integratio…

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27948: [WIP][SPARK-30715][k8s][FOLLOW-UP] Update k8s client version in integratio…
URL: https://github.com/apache/spark/pull/27948#issuecomment-600623891
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24711/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27948: [WIP][SPARK-30715][k8s][FOLLOW-UP] Update k8s client version in integratio…

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27948: [WIP][SPARK-30715][k8s][FOLLOW-UP] Update k8s client version in integratio…
URL: https://github.com/apache/spark/pull/27948#issuecomment-600623876
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27948: [WIP][SPARK-30715][k8s][FOLLOW-UP] Update k8s client version in integratio…

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27948: [WIP][SPARK-30715][k8s][FOLLOW-UP] Update k8s client version in integratio…
URL: https://github.com/apache/spark/pull/27948#issuecomment-600623891
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24711/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] ScrapCodes commented on a change in pull request #27948: [SPARK-30715][k8s][FOLLOW-UP] Update k8s client version in integratio…

Posted by GitBox <gi...@apache.org>.
ScrapCodes commented on a change in pull request #27948: [SPARK-30715][k8s][FOLLOW-UP] Update k8s client version in integratio…
URL: https://github.com/apache/spark/pull/27948#discussion_r395511318
 
 

 ##########
 File path: resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/KubernetesSuite.scala
 ##########
 @@ -61,15 +61,15 @@ class KubernetesSuite extends SparkFunSuite
   protected var appLocator: String = _
 
   // Default memory limit is 1024M + 384M (minimum overhead constant)
-  private val baseMemory = s"${1024 + 384}Mi"
 
 Review comment:
   Hi @dongjoon-hyun, a gentle ping.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #27948: [WIP][SPARK-30715][k8s][FOLLOW-UP] Update k8s client version in integratio…

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #27948: [WIP][SPARK-30715][k8s][FOLLOW-UP] Update k8s client version in integratio…
URL: https://github.com/apache/spark/pull/27948#discussion_r394671633
 
 

 ##########
 File path: resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/KubernetesSuite.scala
 ##########
 @@ -61,15 +61,15 @@ class KubernetesSuite extends SparkFunSuite
   protected var appLocator: String = _
 
   // Default memory limit is 1024M + 384M (minimum overhead constant)
-  private val baseMemory = s"${1024 + 384}Mi"
 
 Review comment:
   Hi, @ScrapCodes . Do we need this change in this PR?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #27948: [WIP][SPARK-30715][k8s][FOLLOW-UP] Update k8s client version in integratio…

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27948: [WIP][SPARK-30715][k8s][FOLLOW-UP] Update k8s client version in integratio…
URL: https://github.com/apache/spark/pull/27948#issuecomment-600623851
 
 
   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/24711/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] ScrapCodes commented on a change in pull request #27948: [WIP][SPARK-30715][k8s][FOLLOW-UP] Update k8s client version in integratio…

Posted by GitBox <gi...@apache.org>.
ScrapCodes commented on a change in pull request #27948: [WIP][SPARK-30715][k8s][FOLLOW-UP] Update k8s client version in integratio…
URL: https://github.com/apache/spark/pull/27948#discussion_r394751855
 
 

 ##########
 File path: resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/KubernetesSuite.scala
 ##########
 @@ -61,15 +61,15 @@ class KubernetesSuite extends SparkFunSuite
   protected var appLocator: String = _
 
   // Default memory limit is 1024M + 384M (minimum overhead constant)
-  private val baseMemory = s"${1024 + 384}Mi"
 
 Review comment:
   Hi Dongjoon, Yes, it is part of updating the client version. Tests won't pass otherwise.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27948: [WIP][SPARK-30715][k8s][FOLLOW-UP] Update k8s client version in integratio…

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27948: [WIP][SPARK-30715][k8s][FOLLOW-UP] Update k8s client version in integratio…
URL: https://github.com/apache/spark/pull/27948#issuecomment-600673176
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #27948: [WIP][SPARK-30715][k8s][FOLLOW-UP] Update k8s client version in integratio…

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27948: [WIP][SPARK-30715][k8s][FOLLOW-UP] Update k8s client version in integratio…
URL: https://github.com/apache/spark/pull/27948#issuecomment-600587486
 
 
   **[Test build #119990 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119990/testReport)** for PR 27948 at commit [`0a6b227`](https://github.com/apache/spark/commit/0a6b2270ccb9cc5cdc859022fc80c889151ea88b).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #27948: [WIP][SPARK-30715][k8s][FOLLOW-UP] Update k8s client version in integratio…

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27948: [WIP][SPARK-30715][k8s][FOLLOW-UP] Update k8s client version in integratio…
URL: https://github.com/apache/spark/pull/27948#issuecomment-600671944
 
 
   **[Test build #119990 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119990/testReport)** for PR 27948 at commit [`0a6b227`](https://github.com/apache/spark/commit/0a6b2270ccb9cc5cdc859022fc80c889151ea88b).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org