You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jmeter-dev@jakarta.apache.org by bu...@apache.org on 2007/05/03 12:19:23 UTC

DO NOT REPLY [Bug 42325] New: - Implement the "clear" method for the LogicControllers

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42325>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42325

           Summary: Implement the "clear" method for the LogicControllers
           Product: JMeter
           Version: 2.2
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: HTTP
        AssignedTo: jmeter-dev@jakarta.apache.org
        ReportedBy: alf@i100.no


When the suggested patch for bug 30120 has been applied, it becomes apparent
that the logic controllers are missing implementations of the "clear" method.
Because when a new logic controller is added, for example "IF controller", and
there already exists an "If controller" in the test plan with an expression set,
the newly added "If controller" has the same expression initially.
The newly added "If controller" should have a blank expression initially.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org

DO NOT REPLY [Bug 42325] - Implement the "clear" method for the LogicControllers

Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42325>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42325





------- Additional Comments From alf@i100.no  2007-05-03 03:37 -------
Created an attachment (id=20115)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=20115&action=view)
Suggested patch

This patch adds implementation of the "clear" method for most of the logic
controllers. It does not implement "clear" for the IncludeController and
ModuleController.

The patch also adds // $NON-NLS-1$ comments, let me know if that is only
confusing, and I can make a patch with only the clear method.

The patch also adds a resource string for the label for the dropdown box of
ModuleController.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org

DO NOT REPLY [Bug 42325] - Implement the "clear" method for the LogicControllers

Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42325>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42325





------- Additional Comments From alf@i100.no  2007-05-04 03:32 -------
Created an attachment (id=20130)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=20130&action=view)
Implement clear for IncludeController and ModuleController

This patch adds "clear" method to the two remaining logic controllers,
IncludeController and ModuleController

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org

DO NOT REPLY [Bug 42325] - Implement the "clear" method for the LogicControllers

Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42325>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42325





------- Additional Comments From sebb@apache.org  2007-05-04 08:09 -------
Thanks - patch 20130 added to SVN in r535284

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org

DO NOT REPLY [Bug 42325] - Implement the "clear" method for the LogicControllers

Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42325>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42325


sebb@apache.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




------- Additional Comments From sebb@apache.org  2007-05-04 03:23 -------
Thanks - added to SVN in r535147 and r535151.

As to the NLS-only and resource fixes, I added them as separate commits.

It's OK to add NLS markers to files that already are being updated, but in 
future please use a separate patch file for changes to other files that are 
unrelated to the current bug report. This makes it easier to follow the 
history later.



-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org