You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Matthew Jacobs (Code Review)" <ge...@cloudera.org> on 2017/04/05 19:41:04 UTC
[Impala-ASF-CR] IMPALA-5154: Handle 'unpartitioned' Kudu tables
Matthew Jacobs has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6560
Change subject: IMPALA-5154: Handle 'unpartitioned' Kudu tables
......................................................................
IMPALA-5154: Handle 'unpartitioned' Kudu tables
The catalogd was hanging trying to load an unpartitioned
Kudu table created outside of Impala. This fixes an
assumption made in KuduTable.java that the list of
'partition by' expressions is not empty. Regardless, the
list on the thrift structure must be created because the
field is marked required.
Change-Id: I40926bf6ea46cfca518bba6d4ca13fb5b0de358d
---
M fe/src/main/java/org/apache/impala/catalog/KuduTable.java
M tests/query_test/test_kudu.py
2 files changed, 34 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/6560/1
--
To view, visit http://gerrit.cloudera.org:8080/6560
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I40926bf6ea46cfca518bba6d4ca13fb5b0de358d
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
[Impala-ASF-CR] IMPALA-5154: Handle 'unpartitioned' Kudu tables
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change.
Change subject: IMPALA-5154: Handle 'unpartitioned' Kudu tables
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6560
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I40926bf6ea46cfca518bba6d4ca13fb5b0de358d
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <ma...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5154: Handle 'unpartitioned' Kudu tables
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-5154: Handle 'unpartitioned' Kudu tables
......................................................................
IMPALA-5154: Handle 'unpartitioned' Kudu tables
The catalogd was hanging trying to load an unpartitioned
Kudu table created outside of Impala. This fixes an
assumption made in KuduTable.java that the list of
'partition by' expressions is not empty. Regardless, the
list on the thrift structure must be created because the
field is marked required.
Change-Id: I40926bf6ea46cfca518bba6d4ca13fb5b0de358d
Reviewed-on: http://gerrit.cloudera.org:8080/6560
Reviewed-by: Alex Behm <al...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M fe/src/main/java/org/apache/impala/catalog/KuduTable.java
M tests/query_test/test_kudu.py
2 files changed, 35 insertions(+), 0 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Alex Behm: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/6560
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I40926bf6ea46cfca518bba6d4ca13fb5b0de358d
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Marcel Kornacker <ma...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
[Impala-ASF-CR] IMPALA-5154: Handle 'unpartitioned' Kudu tables
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5154: Handle 'unpartitioned' Kudu tables
......................................................................
Patch Set 2:
Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/440/
--
To view, visit http://gerrit.cloudera.org:8080/6560
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I40926bf6ea46cfca518bba6d4ca13fb5b0de358d
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Marcel Kornacker <ma...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5154: Handle 'unpartitioned' Kudu tables
Posted by "Marcel Kornacker (Code Review)" <ge...@cloudera.org>.
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-5154: Handle 'unpartitioned' Kudu tables
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6560/1/tests/query_test/test_kudu.py
File tests/query_test/test_kudu.py:
Line 483: it can be created directly in Kudu and then loaded as an external table.
if this is harmless/useful functionality, should impala also support it?
--
To view, visit http://gerrit.cloudera.org:8080/6560
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I40926bf6ea46cfca518bba6d4ca13fb5b0de358d
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <ma...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5154: Handle 'unpartitioned' Kudu tables
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5154: Handle 'unpartitioned' Kudu tables
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/6560
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I40926bf6ea46cfca518bba6d4ca13fb5b0de358d
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Marcel Kornacker <ma...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5154: Handle 'unpartitioned' Kudu tables
Posted by "Matthew Jacobs (Code Review)" <ge...@cloudera.org>.
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5154: Handle 'unpartitioned' Kudu tables
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/6560/1/tests/query_test/test_kudu.py
File tests/query_test/test_kudu.py:
Line 483: it can be created directly in Kudu and then loaded as an external table.
> if this is harmless/useful functionality, should impala also support it?
I had talked to DanB about it previously, and he said they want people to move away from creating tables like this but that they didn't want to break backwards compatibility in the client.
Line 500: cursor.execute("SELECT COUNT(*) FROM %s" % name)
> Just curious: Can we insert into the table? Is this table expected to suppo
It should behave normally after it's created, we don't know anything about the partitioning. I'll modify this test to insert as well.
--
To view, visit http://gerrit.cloudera.org:8080/6560
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I40926bf6ea46cfca518bba6d4ca13fb5b0de358d
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <ma...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5154: Handle 'unpartitioned' Kudu tables
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change.
Change subject: IMPALA-5154: Handle 'unpartitioned' Kudu tables
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6560/1/tests/query_test/test_kudu.py
File tests/query_test/test_kudu.py:
Line 500: cursor.execute("SELECT COUNT(*) FROM %s" % name)
Just curious: Can we insert into the table? Is this table expected to support all operations?
--
To view, visit http://gerrit.cloudera.org:8080/6560
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I40926bf6ea46cfca518bba6d4ca13fb5b0de358d
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <ma...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5154: Handle 'unpartitioned' Kudu tables
Posted by "Matthew Jacobs (Code Review)" <ge...@cloudera.org>.
Matthew Jacobs has uploaded a new patch set (#2).
Change subject: IMPALA-5154: Handle 'unpartitioned' Kudu tables
......................................................................
IMPALA-5154: Handle 'unpartitioned' Kudu tables
The catalogd was hanging trying to load an unpartitioned
Kudu table created outside of Impala. This fixes an
assumption made in KuduTable.java that the list of
'partition by' expressions is not empty. Regardless, the
list on the thrift structure must be created because the
field is marked required.
Change-Id: I40926bf6ea46cfca518bba6d4ca13fb5b0de358d
---
M fe/src/main/java/org/apache/impala/catalog/KuduTable.java
M tests/query_test/test_kudu.py
2 files changed, 35 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/6560/2
--
To view, visit http://gerrit.cloudera.org:8080/6560
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I40926bf6ea46cfca518bba6d4ca13fb5b0de358d
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <ma...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>