[jira] [Comment Edited] (HIVE-22066) Upgrade Apache parent POM to version 21

["David Mollitor (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-22066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16986957#comment-16986957 ] 

David Mollitor edited comment on HIVE-22066 at 12/3/19 2:43 PM:
----------------------------------------------------------------

[~jcamachorodriguez] OK, so I think I have a better handle on what's going wrong here...

{code:none}
============================================================================
============================================================================
                           maven install: master
============================================================================
============================================================================


cd /data/hiveptest/working/yetus_PreCommit-HIVE-Build-19708
mvn -DskipTests -Pitests -fae clean install -DskipTests=true -Dmaven.javadoc.skip=true -Dcheckstyle.skip=true -Dfindbugs.skip=true > /data/hiveptest/logs/PreCommit-HIVE-Build-19708/yetus/branch-mvninstall-root.txt 2>&1
Elapsed:   8m 21s


============================================================================
============================================================================
                       master compilation: pre-patch
============================================================================
============================================================================

...

============================================================================
============================================================================
                 Pre-patch javadoc verification on master
============================================================================
============================================================================

...

============================================================================
============================================================================
                         Applying patch to master
============================================================================
============================================================================

... 

============================================================================
============================================================================
Determining Maven Dependency Order (downloading dependencies in the process)
============================================================================
============================================================================

...

============================================================================
============================================================================
                           maven install: patch
============================================================================
============================================================================


cd /data/hiveptest/working/yetus_PreCommit-HIVE-Build-19708/storage-api
mvn -DskipTests -Pitests -fae clean install -DskipTests=true -Dmaven.javadoc.skip=true -Dcheckstyle.skip=true -Dfindbugs.skip=true > /data/hiveptest/logs/PreCommit-HIVE-Build-19708/yetus/patch-mvninstall-storage-api.txt 2>&1
Elapsed:   0m 13s
cd /data/hiveptest/working/yetus_PreCommit-HIVE-Build-19708/shims/common
mvn -DskipTests -Pitests -fae clean install -DskipTests=true -Dmaven.javadoc.skip=true -Dcheckstyle.skip=true -Dfindbugs.skip=true > /data/hiveptest/logs/PreCommit-HIVE-Build-19708/yetus/patch-mvninstall-shims_common.txt 2>&1
Elapsed:   0m 11s
cd /data/hiveptest/working/yetus_PreCommit-HIVE-Build-19708/shims/0.23
mvn -DskipTests -Pitests -fae clean install -DskipTests=true -Dmaven.javadoc.skip=true -Dcheckstyle.skip=true -Dfindbugs.skip=true > /data/hiveptest/logs/PreCommit-HIVE-Build-19708/yetus/patch-mvninstall-shims_0.23.txt 2>&1
Elapsed:   0m 12s
cd /data/hiveptest/working/yetus_PreCommit-HIVE-Build-19708/shims/scheduler
mvn -DskipTests -Pitests -fae clean install -DskipTests=true -Dmaven.javadoc.skip=true -Dcheckstyle.skip=true -Dfindbugs.skip=true > /data/hiveptest/logs/PreCommit-HIVE-Build-19708/yetus/patch-mvninstall-shims_scheduler.txt 2>&1
Elapsed:   0m  9s
cd /data/hiveptest/working/yetus_PreCommit-HIVE-Build-19708/standalone-metastore
mvn -DskipTests -Pitests -fae clean install -DskipTests=true -Dmaven.javadoc.skip=true -Dcheckstyle.skip=true -Dfindbugs.skip=true > /data/hiveptest/logs/PreCommit-HIVE-Build-19708/yetus/patch-mvninstall-standalone-metastore.txt 2>&1
Elapsed:   1m 15s
cd /data/hiveptest/working/yetus_PreCommit-HIVE-Build-19708/standalone-metastore/metastore-common
mvn -DskipTests -Pitests -fae clean install -DskipTests=true -Dmaven.javadoc.skip=true -Dcheckstyle.skip=true -Dfindbugs.skip=true > /data/hiveptest/logs/PreCommit-HIVE-Build-19708/yetus/patch-mvninstall-standalone-metastore_metastore-common.txt 2>&1
Elapsed:   0m 37s
cd /data/hiveptest/working/yetus_PreCommit-HIVE-Build-19708/common
mvn -DskipTests -Pitests -fae clean install -DskipTests=true -Dmaven.javadoc.skip=true -Dcheckstyle.skip=true -Dfindbugs.skip=true > /data/hiveptest/logs/PreCommit-HIVE-Build-19708/yetus/patch-mvninstall-common.txt 2>&1
Elapsed:   0m 15s
cd /data/hiveptest/working/yetus_PreCommit-HIVE-Build-19708/service-rpc
mvn -DskipTests -Pitests -fae clean install -DskipTests=true -Dmaven.javadoc.skip=true -Dcheckstyle.skip=true -Dfindbugs.skip=true > /data/hiveptest/logs/PreCommit-HIVE-Build-19708/yetus/patch-mvninstall-service-rpc.txt 2>&1
Elapsed:   0m 13s
cd /data/hiveptest/working/yetus_PreCommit-HIVE-Build-19708/serde
mvn -DskipTests -Pitests -fae clean install -DskipTests=true -Dmaven.javadoc.skip=true -Dcheckstyle.skip=true -Dfindbugs.skip=true > /data/hiveptest/logs/PreCommit-HIVE-Build-19708/yetus/patch-mvninstall-serde.txt 2>&1
Elapsed:   0m 20s
cd /data/hiveptest/working/yetus_PreCommit-HIVE-Build-19708/metastore
mvn -DskipTests -Pitests -fae clean install -DskipTests=true -Dmaven.javadoc.skip=true -Dcheckstyle.skip=true -Dfindbugs.skip=true > /data/hiveptest/logs/PreCommit-HIVE-Build-19708/yetus/patch-mvninstall-metastore.txt 2>&1
Elapsed:   0m 13s
cd /data/hiveptest/working/yetus_PreCommit-HIVE-Build-19708/vector-code-gen
mvn -DskipTests -Pitests -fae clean install -DskipTests=true -Dmaven.javadoc.skip=true -Dcheckstyle.skip=true -Dfindbugs.skip=true > /data/hiveptest/logs/PreCommit-HIVE-Build-19708/yetus/patch-mvninstall-vector-code-gen.txt 2>&1
Elapsed:   0m  9s
cd /data/hiveptest/working/yetus_PreCommit-HIVE-Build-19708/llap-common
mvn -DskipTests -Pitests -fae clean install -DskipTests=true -Dmaven.javadoc.skip=true -Dcheckstyle.skip=true -Dfindbugs.skip=true > /data/hiveptest/logs/PreCommit-HIVE-Build-19708/yetus/patch-mvninstall-llap-common.txt 2>&1
Elapsed:   0m 16s
cd /data/hiveptest/working/yetus_PreCommit-HIVE-Build-19708/llap-client
mvn -DskipTests -Pitests -fae clean install -DskipTests=true -Dmaven.javadoc.skip=true -Dcheckstyle.skip=true -Dfindbugs.skip=true > /data/hiveptest/logs/PreCommit-HIVE-Build-19708/yetus/patch-mvninstall-llap-client.txt 2>&1
Elapsed:   0m 16s
cd /data/hiveptest/working/yetus_PreCommit-HIVE-Build-19708/llap-tez
mvn -DskipTests -Pitests -fae clean install -DskipTests=true -Dmaven.javadoc.skip=true -Dcheckstyle.skip=true -Dfindbugs.skip=true > /data/hiveptest/logs/PreCommit-HIVE-Build-19708/yetus/patch-mvninstall-llap-tez.txt 2>&1
Elapsed:   0m 15s
cd /data/hiveptest/working/yetus_PreCommit-HIVE-Build-19708/spark-client
mvn -DskipTests -Pitests -fae clean install -DskipTests=true -Dmaven.javadoc.skip=true -Dcheckstyle.skip=true -Dfindbugs.skip=true > /data/hiveptest/logs/PreCommit-HIVE-Build-19708/yetus/patch-mvninstall-spark-client.txt 2>&1
Elapsed:   0m 16s
cd /data/hiveptest/working/yetus_PreCommit-HIVE-Build-19708/ql
mvn -DskipTests -Pitests -fae clean install -DskipTests=true -Dmaven.javadoc.skip=true -Dcheckstyle.skip=true -Dfindbugs.skip=true > /data/hiveptest/logs/PreCommit-HIVE-Build-19708/yetus/patch-mvninstall-ql.txt 2>&1
Elapsed:   0m 33s

{code}

So what you can see that the root POM gets built before the patch is applied and even though I am modifying the root POM file with this patch, those changes are not being applied.  Looking at the YETUS code, it looks like I can get it to build the root POM after the patch if I pump the project's version number in the root POM.  I submitted a dummy patch which makes the Hive version 4.0.1-SNAPSHOT to see if that will correct the issue.  If it does, I propose that we commit  [^HIVE-22066.9.patch]  with the understanding that it should start passing in future builds since the root pom will be correct.


was (Author: belugabehr):
[~jcamachorodriguez] OK, so I think I have a better handle on what's going wrong here...

{code:none}
============================================================================
============================================================================
                           maven install: master
============================================================================
============================================================================


cd /data/hiveptest/working/yetus_PreCommit-HIVE-Build-19708
mvn -DskipTests -Pitests -fae clean install -DskipTests=true -Dmaven.javadoc.skip=true -Dcheckstyle.skip=true -Dfindbugs.skip=true > /data/hiveptest/logs/PreCommit-HIVE-Build-19708/yetus/branch-mvninstall-root.txt 2>&1
Elapsed:   8m 21s


============================================================================
============================================================================
                       master compilation: pre-patch
============================================================================
============================================================================

...

============================================================================
============================================================================
                 Pre-patch javadoc verification on master
============================================================================
============================================================================

...

============================================================================
============================================================================
                         Applying patch to master
============================================================================
============================================================================

... 

============================================================================
============================================================================
Determining Maven Dependency Order (downloading dependencies in the process)
============================================================================
============================================================================

...

============================================================================
============================================================================
                           maven install: patch
============================================================================
============================================================================


cd /data/hiveptest/working/yetus_PreCommit-HIVE-Build-19708/storage-api
mvn -DskipTests -Pitests -fae clean install -DskipTests=true -Dmaven.javadoc.skip=true -Dcheckstyle.skip=true -Dfindbugs.skip=true > /data/hiveptest/logs/PreCommit-HIVE-Build-19708/yetus/patch-mvninstall-storage-api.txt 2>&1
Elapsed:   0m 13s
cd /data/hiveptest/working/yetus_PreCommit-HIVE-Build-19708/shims/common
mvn -DskipTests -Pitests -fae clean install -DskipTests=true -Dmaven.javadoc.skip=true -Dcheckstyle.skip=true -Dfindbugs.skip=true > /data/hiveptest/logs/PreCommit-HIVE-Build-19708/yetus/patch-mvninstall-shims_common.txt 2>&1
Elapsed:   0m 11s
cd /data/hiveptest/working/yetus_PreCommit-HIVE-Build-19708/shims/0.23
mvn -DskipTests -Pitests -fae clean install -DskipTests=true -Dmaven.javadoc.skip=true -Dcheckstyle.skip=true -Dfindbugs.skip=true > /data/hiveptest/logs/PreCommit-HIVE-Build-19708/yetus/patch-mvninstall-shims_0.23.txt 2>&1
Elapsed:   0m 12s
cd /data/hiveptest/working/yetus_PreCommit-HIVE-Build-19708/shims/scheduler
mvn -DskipTests -Pitests -fae clean install -DskipTests=true -Dmaven.javadoc.skip=true -Dcheckstyle.skip=true -Dfindbugs.skip=true > /data/hiveptest/logs/PreCommit-HIVE-Build-19708/yetus/patch-mvninstall-shims_scheduler.txt 2>&1
Elapsed:   0m  9s
cd /data/hiveptest/working/yetus_PreCommit-HIVE-Build-19708/standalone-metastore
mvn -DskipTests -Pitests -fae clean install -DskipTests=true -Dmaven.javadoc.skip=true -Dcheckstyle.skip=true -Dfindbugs.skip=true > /data/hiveptest/logs/PreCommit-HIVE-Build-19708/yetus/patch-mvninstall-standalone-metastore.txt 2>&1
Elapsed:   1m 15s
cd /data/hiveptest/working/yetus_PreCommit-HIVE-Build-19708/standalone-metastore/metastore-common
mvn -DskipTests -Pitests -fae clean install -DskipTests=true -Dmaven.javadoc.skip=true -Dcheckstyle.skip=true -Dfindbugs.skip=true > /data/hiveptest/logs/PreCommit-HIVE-Build-19708/yetus/patch-mvninstall-standalone-metastore_metastore-common.txt 2>&1
Elapsed:   0m 37s
cd /data/hiveptest/working/yetus_PreCommit-HIVE-Build-19708/common
mvn -DskipTests -Pitests -fae clean install -DskipTests=true -Dmaven.javadoc.skip=true -Dcheckstyle.skip=true -Dfindbugs.skip=true > /data/hiveptest/logs/PreCommit-HIVE-Build-19708/yetus/patch-mvninstall-common.txt 2>&1
Elapsed:   0m 15s
cd /data/hiveptest/working/yetus_PreCommit-HIVE-Build-19708/service-rpc
mvn -DskipTests -Pitests -fae clean install -DskipTests=true -Dmaven.javadoc.skip=true -Dcheckstyle.skip=true -Dfindbugs.skip=true > /data/hiveptest/logs/PreCommit-HIVE-Build-19708/yetus/patch-mvninstall-service-rpc.txt 2>&1
Elapsed:   0m 13s
cd /data/hiveptest/working/yetus_PreCommit-HIVE-Build-19708/serde
mvn -DskipTests -Pitests -fae clean install -DskipTests=true -Dmaven.javadoc.skip=true -Dcheckstyle.skip=true -Dfindbugs.skip=true > /data/hiveptest/logs/PreCommit-HIVE-Build-19708/yetus/patch-mvninstall-serde.txt 2>&1
Elapsed:   0m 20s
cd /data/hiveptest/working/yetus_PreCommit-HIVE-Build-19708/metastore
mvn -DskipTests -Pitests -fae clean install -DskipTests=true -Dmaven.javadoc.skip=true -Dcheckstyle.skip=true -Dfindbugs.skip=true > /data/hiveptest/logs/PreCommit-HIVE-Build-19708/yetus/patch-mvninstall-metastore.txt 2>&1
Elapsed:   0m 13s
cd /data/hiveptest/working/yetus_PreCommit-HIVE-Build-19708/vector-code-gen
mvn -DskipTests -Pitests -fae clean install -DskipTests=true -Dmaven.javadoc.skip=true -Dcheckstyle.skip=true -Dfindbugs.skip=true > /data/hiveptest/logs/PreCommit-HIVE-Build-19708/yetus/patch-mvninstall-vector-code-gen.txt 2>&1
Elapsed:   0m  9s
cd /data/hiveptest/working/yetus_PreCommit-HIVE-Build-19708/llap-common
mvn -DskipTests -Pitests -fae clean install -DskipTests=true -Dmaven.javadoc.skip=true -Dcheckstyle.skip=true -Dfindbugs.skip=true > /data/hiveptest/logs/PreCommit-HIVE-Build-19708/yetus/patch-mvninstall-llap-common.txt 2>&1
Elapsed:   0m 16s
cd /data/hiveptest/working/yetus_PreCommit-HIVE-Build-19708/llap-client
mvn -DskipTests -Pitests -fae clean install -DskipTests=true -Dmaven.javadoc.skip=true -Dcheckstyle.skip=true -Dfindbugs.skip=true > /data/hiveptest/logs/PreCommit-HIVE-Build-19708/yetus/patch-mvninstall-llap-client.txt 2>&1
Elapsed:   0m 16s
cd /data/hiveptest/working/yetus_PreCommit-HIVE-Build-19708/llap-tez
mvn -DskipTests -Pitests -fae clean install -DskipTests=true -Dmaven.javadoc.skip=true -Dcheckstyle.skip=true -Dfindbugs.skip=true > /data/hiveptest/logs/PreCommit-HIVE-Build-19708/yetus/patch-mvninstall-llap-tez.txt 2>&1
Elapsed:   0m 15s
cd /data/hiveptest/working/yetus_PreCommit-HIVE-Build-19708/spark-client
mvn -DskipTests -Pitests -fae clean install -DskipTests=true -Dmaven.javadoc.skip=true -Dcheckstyle.skip=true -Dfindbugs.skip=true > /data/hiveptest/logs/PreCommit-HIVE-Build-19708/yetus/patch-mvninstall-spark-client.txt 2>&1
Elapsed:   0m 16s
cd /data/hiveptest/working/yetus_PreCommit-HIVE-Build-19708/ql
mvn -DskipTests -Pitests -fae clean install -DskipTests=true -Dmaven.javadoc.skip=true -Dcheckstyle.skip=true -Dfindbugs.skip=true > /data/hiveptest/logs/PreCommit-HIVE-Build-19708/yetus/patch-mvninstall-ql.txt 2>&1
Elapsed:   0m 33s

{code}

So what you can see that the root POM gets built before the patch is applied and even though I am modifying the root POM file with this patch, those changes are not being applied.  Looking at the YETUS code, it looks like I can get it to build the root POM after the patch if I pump the project's version number in the root POM.  I submitted a dummy patch which makes the Hive version 4.0.1-SNAPSHOT to see if that will correct the issue.  If it does, I propose that we commit the patch with the understanding that it should start passing in future builds since the root pom will be correct.

> Upgrade Apache parent POM to version 21
> ---------------------------------------
>
>                 Key: HIVE-22066
>                 URL: https://issues.apache.org/jira/browse/HIVE-22066
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Jesus Camacho Rodriguez
>            Assignee: David Mollitor
>            Priority: Major
>         Attachments: HIVE-22066.2.patch, HIVE-22066.3.patch, HIVE-22066.4.patch, HIVE-22066.5.patch, HIVE-22066.6.patch, HIVE-22066.6.patch, HIVE-22066.7.patch, HIVE-22066.8.patch, HIVE-22066.8.patch, HIVE-22066.9.patch, HIVE-22066.999.patch, HIVE-22066.patch, HIVE-22066.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)