You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@samza.apache.org by Navina Ramesh <nr...@linkedin.com> on 2015/08/01 03:17:45 UTC
Re: Review Request 36545: SAMZA-682 Refactor Coordinator stream
messages
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36545/#review93826
-----------------------------------------------------------
Ship it!
Thanks for testing with Zopkio !
- Navina Ramesh
On July 31, 2015, 12:49 p.m., József Márton Jung wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36545/
> -----------------------------------------------------------
>
> (Updated July 31, 2015, 12:49 p.m.)
>
>
> Review request for samza.
>
>
> Repository: samza
>
>
> Description
> -------
>
> The following has been refactored:
> 1. Static inner classes from CoordinatorStreamMessage has been extracted
> 2. Common functionality from CheckpointManager, ChangelogMappingManager and LocalityManager has benn moved to a base class
>
>
> Diffs
> -----
>
> checkstyle/import-control.xml 6654319
> samza-core/src/main/java/org/apache/samza/checkpoint/CheckpointManager.java 7445996
> samza-core/src/main/java/org/apache/samza/container/LocalityManager.java 55c258f
> samza-core/src/main/java/org/apache/samza/coordinator/stream/AbstractCoordinatorStreamManager.java PRE-CREATION
> samza-core/src/main/java/org/apache/samza/coordinator/stream/CoordinatorStreamMessage.java e5ab4fb
> samza-core/src/main/java/org/apache/samza/coordinator/stream/CoordinatorStreamSystemConsumer.java b1078bd
> samza-core/src/main/java/org/apache/samza/coordinator/stream/CoordinatorStreamSystemProducer.java 92f8907
> samza-core/src/main/java/org/apache/samza/coordinator/stream/CoordinatorStreamWriter.java f769756
> samza-core/src/main/java/org/apache/samza/coordinator/stream/messages/CoordinatorStreamMessage.java PRE-CREATION
> samza-core/src/main/java/org/apache/samza/coordinator/stream/messages/Delete.java PRE-CREATION
> samza-core/src/main/java/org/apache/samza/coordinator/stream/messages/SetChangelogMapping.java PRE-CREATION
> samza-core/src/main/java/org/apache/samza/coordinator/stream/messages/SetCheckpoint.java PRE-CREATION
> samza-core/src/main/java/org/apache/samza/coordinator/stream/messages/SetConfig.java PRE-CREATION
> samza-core/src/main/java/org/apache/samza/coordinator/stream/messages/SetContainerHostMapping.java PRE-CREATION
> samza-core/src/main/java/org/apache/samza/job/model/JobModel.java ad6387d
> samza-core/src/main/java/org/apache/samza/storage/ChangelogPartitionManager.java 7d3409c
> samza-core/src/main/scala/org/apache/samza/coordinator/JobCoordinator.scala 0dbf14b
> samza-core/src/main/scala/org/apache/samza/job/JobRunner.scala 1c178a6
> samza-core/src/test/java/org/apache/samza/coordinator/stream/MockCoordinatorStreamWrappedConsumer.java e454593
> samza-core/src/test/java/org/apache/samza/coordinator/stream/TestCoordinatorStreamMessage.java ac26a01
> samza-core/src/test/java/org/apache/samza/coordinator/stream/TestCoordinatorStreamSystemConsumer.java c25f6a7
> samza-core/src/test/java/org/apache/samza/coordinator/stream/TestCoordinatorStreamSystemProducer.java 1ef07d0
> samza-core/src/test/java/org/apache/samza/coordinator/stream/TestCoordinatorStreamWriter.java c484660
> samza-core/src/test/scala/org/apache/samza/container/TestSamzaContainer.scala 84fdeaa
> samza-yarn/src/main/resources/scalate/WEB-INF/views/index.scaml 41303f7
>
> Diff: https://reviews.apache.org/r/36545/diff/
>
>
> Testing
> -------
>
> Tests has been updated.
>
>
> Thanks,
>
> József Márton Jung
>
>