You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by "Martin Webb (JIRA)" <ji...@apache.org> on 2008/01/10 20:05:34 UTC

[jira] Created: (SHINDIG-10) PHP implementation assumes that the files are in the root directory - better to allow a path in the config.php

PHP implementation assumes that the files are in the root directory - better to allow a path in the config.php
--------------------------------------------------------------------------------------------------------------

                 Key: SHINDIG-10
                 URL: https://issues.apache.org/jira/browse/SHINDIG-10
             Project: Shindig
          Issue Type: Improvement
            Reporter: Martin Webb
            Priority: Minor


The php implementation is currently hard coded to expect all the files to be in the root directory of the domain, e.g.:

http://www.example.com/config.php
http://www.example.com/js/ShindigContainer.js

If the OpenSocial API does not mandate that the implementation must be in the root directory, then the shindig implementation should be a little flexible in where it is located.

It would be better for an optional path to be specified within the config.php, e.g.:

define(SHINDIG_PATH, "/some/example/path"); // path to shindig

Probably set to an empty string as part of the svn repository, e.g.:

define(SHINDIG_PATH, ""); // path to shindig php files

In the previous example then shindig would be located at:

http://www.example.com/some/example/path/config.php
http://www.example.com/some/example/path/js/ShindigContainer.js

It may even be better to allow different paths for different types of assets, e.g one for php files, another for JS files, etc.

And then where ever resources are mentioned then the SHINDIG_PATH is included, e.g., within index.php, change:

    <iframe src="<?php echo "http://" . SITE_HOST ?>/comframe.php" id="comframe" scrolling="auto" frameborder="0" style="border:0;padding:0;margin:0;overflow:auto;background:white"/>

To:

    <iframe src="<?php echo "http://" . SITE_HOST . SHINDIG_PATH ?>/comframe.php" id="comframe" scrolling="auto" frameborder="0" style="border:0;padding:0;margin:0;overflow:auto;background:white"/>

I have not provided a diff, because I think this issue/best-practice is wider than the current files in SVN

Regards
Martin



-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (SHINDIG-10) PHP implementation assumes that the files are in the root directory - better to allow a path in the config.php

Posted by "Paul Lindner (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-10?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Paul Lindner updated SHINDIG-10:
--------------------------------

    Component/s: Gadgets Server - PHP

> PHP implementation assumes that the files are in the root directory - better to allow a path in the config.php
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: SHINDIG-10
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-10
>             Project: Shindig
>          Issue Type: Improvement
>          Components: Gadgets Server - PHP
>            Reporter: Martin Webb
>            Priority: Minor
>
> The php implementation is currently hard coded to expect all the files to be in the root directory of the domain, e.g.:
> http://www.example.com/config.php
> http://www.example.com/js/ShindigContainer.js
> If the OpenSocial API does not mandate that the implementation must be in the root directory, then the shindig implementation should be a little flexible in where it is located.
> It would be better for an optional path to be specified within the config.php, e.g.:
> define(SHINDIG_PATH, "/some/example/path"); // path to shindig
> Probably set to an empty string as part of the svn repository, e.g.:
> define(SHINDIG_PATH, ""); // path to shindig php files
> In the previous example then shindig would be located at:
> http://www.example.com/some/example/path/config.php
> http://www.example.com/some/example/path/js/ShindigContainer.js
> It may even be better to allow different paths for different types of assets, e.g one for php files, another for JS files, etc.
> And then where ever resources are mentioned then the SHINDIG_PATH is included, e.g., within index.php, change:
>     <iframe src="<?php echo "http://" . SITE_HOST ?>/comframe.php" id="comframe" scrolling="auto" frameborder="0" style="border:0;padding:0;margin:0;overflow:auto;background:white"/>
> To:
>     <iframe src="<?php echo "http://" . SITE_HOST . SHINDIG_PATH ?>/comframe.php" id="comframe" scrolling="auto" frameborder="0" style="border:0;padding:0;margin:0;overflow:auto;background:white"/>
> I have not provided a diff, because I think this issue/best-practice is wider than the current files in SVN
> Regards
> Martin

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Resolved: (SHINDIG-10) PHP implementation assumes that the files are in the root directory - better to allow a path in the config.php

Posted by "Paul Lindner (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-10?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Paul Lindner resolved SHINDIG-10.
---------------------------------

    Resolution: Invalid

Not relevant anymore as we've changed implementation in SHINDIG-103


> PHP implementation assumes that the files are in the root directory - better to allow a path in the config.php
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: SHINDIG-10
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-10
>             Project: Shindig
>          Issue Type: Improvement
>          Components: Gadgets Server - PHP
>            Reporter: Martin Webb
>            Priority: Minor
>
> The php implementation is currently hard coded to expect all the files to be in the root directory of the domain, e.g.:
> http://www.example.com/config.php
> http://www.example.com/js/ShindigContainer.js
> If the OpenSocial API does not mandate that the implementation must be in the root directory, then the shindig implementation should be a little flexible in where it is located.
> It would be better for an optional path to be specified within the config.php, e.g.:
> define(SHINDIG_PATH, "/some/example/path"); // path to shindig
> Probably set to an empty string as part of the svn repository, e.g.:
> define(SHINDIG_PATH, ""); // path to shindig php files
> In the previous example then shindig would be located at:
> http://www.example.com/some/example/path/config.php
> http://www.example.com/some/example/path/js/ShindigContainer.js
> It may even be better to allow different paths for different types of assets, e.g one for php files, another for JS files, etc.
> And then where ever resources are mentioned then the SHINDIG_PATH is included, e.g., within index.php, change:
>     <iframe src="<?php echo "http://" . SITE_HOST ?>/comframe.php" id="comframe" scrolling="auto" frameborder="0" style="border:0;padding:0;margin:0;overflow:auto;background:white"/>
> To:
>     <iframe src="<?php echo "http://" . SITE_HOST . SHINDIG_PATH ?>/comframe.php" id="comframe" scrolling="auto" frameborder="0" style="border:0;padding:0;margin:0;overflow:auto;background:white"/>
> I have not provided a diff, because I think this issue/best-practice is wider than the current files in SVN
> Regards
> Martin

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.