You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@madlib.apache.org by iyerr3 <gi...@git.apache.org> on 2018/02/15 16:11:47 UTC
[GitHub] madlib pull request #236: DT: Ensure n_folds and null_proxy are set correctl...
GitHub user iyerr3 opened a pull request:
https://github.com/apache/madlib/pull/236
DT: Ensure n_folds and null_proxy are set correctly
The summary table in Decision Tree included two entries: k and
null_proxy. The 'k' value is supposed to reflect the 'n_folds' value but
was not set correctly and was always NULL. The null_proxy was supposed
to be NULL when null_as_category=False but was set to the string 'NULL'.
Both these issues have been corrected in this commit.
Closes #236
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/iyerr3/incubator-madlib bugfix/dt_incorrect_output_values
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/madlib/pull/236.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #236
----
commit 4d27ba64c322c1e0f5423cebb805738aa84f5dcb
Author: Rahul Iyer <ri...@...>
Date: 2018-02-15T16:07:49Z
DT: Ensure n_folds and null_proxy are set correctly
The summary table in Decision Tree included two entries: k and
null_proxy. The 'k' value is supposed to reflect the 'n_folds' value but
was not set correctly and was always NULL. The null_proxy was supposed
to be NULL when null_as_category=False but was set to the string 'NULL'.
Both these issues have been corrected in this commit.
Closes #236
----
---
[GitHub] madlib issue #236: DT: Ensure n_folds and null_proxy are set correctly
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/madlib/pull/236
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/madlib-pr-build/346/
---
[GitHub] madlib pull request #236: DT: Ensure n_folds and null_proxy are set correctl...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/madlib/pull/236
---
[GitHub] madlib issue #236: DT: Ensure n_folds and null_proxy are set correctly
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/madlib/pull/236
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/madlib-pr-build/357/
---
[GitHub] madlib pull request #236: DT: Ensure n_folds and null_proxy are set correctl...
Posted by njayaram2 <gi...@git.apache.org>.
Github user njayaram2 commented on a diff in the pull request:
https://github.com/apache/madlib/pull/236#discussion_r168569487
--- Diff: src/ports/postgres/modules/recursive_partitioning/decision_tree.py_in ---
@@ -1463,15 +1463,15 @@ def _create_summary_table(
cp_str = py_list_to_sql_string(cp, 'double precision')
else:
cp_str = str(cp) + "::double precision"
- fold = k if running_cv else "NULL"
+ # n_folds_str = n_folds if running_cv else "NULL"
--- End diff --
Can we remove this commented line?
---
[GitHub] madlib issue #236: DT: Ensure n_folds and null_proxy are set correctly
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/madlib/pull/236
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/madlib-pr-build/352/
---