You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2019/03/20 02:24:15 UTC
Review Request 70243: Improved operation reconciliation in the
resource provider and manager.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70243/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, Gastón Kleiman, and Joseph Wu.
Bugs: MESOS-9318
https://issues.apache.org/jira/browse/MESOS-9318
Repository: mesos
Description
-------
This patch updates the operation reconciliation pipeline to
forward some framework-initiated reconciliation requests to
the agent. In cases where an explicit reconciliation request
specifies an operation which is not recognized on a resource
provider which is also not recognized, the master will
forward the request to the agent so that the resource
provider manager can satisfy the request based on whether or
not the resource provider has been seen before.
Diffs
-----
include/mesos/resource_provider/resource_provider.proto 5ea9e2009209b1609619874ebd63cb1e2e698434
src/master/master.cpp dc68fc324de7242737123015fbac19a2129778ce
src/messages/messages.proto 633dddbaa874550f7f0d9513c608ed75b18059a8
src/resource_provider/manager.cpp 7d3338ea7fbf330a25416f848db7742ad1bea52f
src/slave/slave.cpp 36424f89a8c1f183febabcc9582975dd21213c25
Diff: https://reviews.apache.org/r/70243/diff/1/
Testing
-------
Testing details at the end of this chain.
Thanks,
Greg Mann
Re: Review Request 70243: Improved operation reconciliation in the
resource provider and manager.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70243/#review213814
-----------------------------------------------------------
Patch looks great!
Reviews applied: [70200, 70208, 70221, 70242, 70243]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On March 19, 2019, 7:24 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70243/
> -----------------------------------------------------------
>
> (Updated March 19, 2019, 7:24 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, Gastón Kleiman, and Joseph Wu.
>
>
> Bugs: MESOS-9318
> https://issues.apache.org/jira/browse/MESOS-9318
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch updates the operation reconciliation pipeline to
> forward some framework-initiated reconciliation requests to
> the agent. In cases where an explicit reconciliation request
> specifies an operation which is not recognized on a resource
> provider which is also not recognized, the master will
> forward the request to the agent so that the resource
> provider manager can satisfy the request based on whether or
> not the resource provider has been seen before.
>
>
> Diffs
> -----
>
> include/mesos/resource_provider/resource_provider.proto 5ea9e2009209b1609619874ebd63cb1e2e698434
> src/master/master.cpp dc68fc324de7242737123015fbac19a2129778ce
> src/messages/messages.proto 633dddbaa874550f7f0d9513c608ed75b18059a8
> src/resource_provider/manager.cpp 7d3338ea7fbf330a25416f848db7742ad1bea52f
> src/slave/slave.cpp 36424f89a8c1f183febabcc9582975dd21213c25
>
>
> Diff: https://reviews.apache.org/r/70243/diff/1/
>
>
> Testing
> -------
>
> Testing details at the end of this chain.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 70243: Improved operation reconciliation for
unsubscribed resource providers.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70243/#review214017
-----------------------------------------------------------
Ship it!
Logically looks sound.
Two of the same style nit.
src/master/master.cpp
Lines 9686 (patched)
<https://reviews.apache.org/r/70243/#comment300184>
// NOTE:
src/resource_provider/manager.cpp
Lines 621 (patched)
<https://reviews.apache.org/r/70243/#comment300183>
// NOTE:
- Joseph Wu
On March 22, 2019, 7:25 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70243/
> -----------------------------------------------------------
>
> (Updated March 22, 2019, 7:25 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, Gastón Kleiman, and Joseph Wu.
>
>
> Bugs: MESOS-9318
> https://issues.apache.org/jira/browse/MESOS-9318
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch updates the operation reconciliation pipeline to
> forward some framework-initiated reconciliation requests to
> the agent. In cases where an explicit reconciliation request
> specifies an operation which is not recognized on a resource
> provider which is also not recognized, the master will
> forward the request to the agent so that the resource
> provider manager can satisfy the request based on whether or
> not the resource provider has been seen before.
>
>
> Diffs
> -----
>
> src/master/master.cpp 9c4a9e83da94535873d72c902835f229c4f96320
> src/messages/messages.proto 633dddbaa874550f7f0d9513c608ed75b18059a8
> src/resource_provider/manager.cpp 7d3338ea7fbf330a25416f848db7742ad1bea52f
> src/slave/slave.cpp 36424f89a8c1f183febabcc9582975dd21213c25
>
>
> Diff: https://reviews.apache.org/r/70243/diff/4/
>
>
> Testing
> -------
>
> Testing details at the end of this chain.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 70243: Improved operation reconciliation for
unsubscribed resource providers.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70243/
-----------------------------------------------------------
(Updated March 23, 2019, 2:25 a.m.)
Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, Gastón Kleiman, and Joseph Wu.
Bugs: MESOS-9318
https://issues.apache.org/jira/browse/MESOS-9318
Repository: mesos
Description
-------
This patch updates the operation reconciliation pipeline to
forward some framework-initiated reconciliation requests to
the agent. In cases where an explicit reconciliation request
specifies an operation which is not recognized on a resource
provider which is also not recognized, the master will
forward the request to the agent so that the resource
provider manager can satisfy the request based on whether or
not the resource provider has been seen before.
Diffs (updated)
-----
src/master/master.cpp 9c4a9e83da94535873d72c902835f229c4f96320
src/messages/messages.proto 633dddbaa874550f7f0d9513c608ed75b18059a8
src/resource_provider/manager.cpp 7d3338ea7fbf330a25416f848db7742ad1bea52f
src/slave/slave.cpp 36424f89a8c1f183febabcc9582975dd21213c25
Diff: https://reviews.apache.org/r/70243/diff/4/
Changes: https://reviews.apache.org/r/70243/diff/3-4/
Testing
-------
Testing details at the end of this chain.
Thanks,
Greg Mann
Re: Review Request 70243: Improved operation reconciliation for
unsubscribed resource providers.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70243/
-----------------------------------------------------------
(Updated March 22, 2019, 9:09 p.m.)
Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, Gastón Kleiman, and Joseph Wu.
Bugs: MESOS-9318
https://issues.apache.org/jira/browse/MESOS-9318
Repository: mesos
Description
-------
This patch updates the operation reconciliation pipeline to
forward some framework-initiated reconciliation requests to
the agent. In cases where an explicit reconciliation request
specifies an operation which is not recognized on a resource
provider which is also not recognized, the master will
forward the request to the agent so that the resource
provider manager can satisfy the request based on whether or
not the resource provider has been seen before.
Diffs (updated)
-----
src/master/master.cpp 9c4a9e83da94535873d72c902835f229c4f96320
src/messages/messages.proto 633dddbaa874550f7f0d9513c608ed75b18059a8
src/resource_provider/manager.cpp 7d3338ea7fbf330a25416f848db7742ad1bea52f
src/slave/slave.cpp 36424f89a8c1f183febabcc9582975dd21213c25
Diff: https://reviews.apache.org/r/70243/diff/3/
Changes: https://reviews.apache.org/r/70243/diff/2-3/
Testing
-------
Testing details at the end of this chain.
Thanks,
Greg Mann
Re: Review Request 70243: Improved operation reconciliation for
unsubscribed resource providers.
Posted by Greg Mann <gr...@mesosphere.io>.
> On March 21, 2019, 11:18 p.m., Joseph Wu wrote:
> > src/resource_provider/manager.cpp
> > Lines 626-628 (patched)
> > <https://reviews.apache.org/r/70243/diff/1/?file=2132878#file2132878line626>
> >
> > Is the `SlaveID` field here meant to be blank? I thought only external resource providers could omit this field.
Yea the RP manager doesn't have the agent ID so the agent injects it before forwarding to the master (that code is already in place: https://github.com/apache/mesos/blob/4580834471fb3bc0b95e2b96e04a63d34faef724/src/slave/slave.cpp#L8250-L8254). I've added a comment to that effect.
> On March 21, 2019, 11:18 p.m., Joseph Wu wrote:
> > src/slave/slave.cpp
> > Lines 4517-4527 (patched)
> > <https://reviews.apache.org/r/70243/diff/1/?file=2132879#file2132879line4517>
> >
> > You could probably do without the ternary:
> > ```
> > Option<UUID> operationUuid;
> > if (operation.has_operation_uuid()) {
> > operationUuid = operation.operation_uuid();
> > } else if (
> > operation.has_operation_id() &&
> > operationIds.contains(operation.operation_id())) {
> > operationUuid = operationIds.at(operation.operation_id());
> > }
> > ```
Good point. Had to tweak a bit now that this map is indexed by (FrameworkID, OperationID).
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70243/#review213892
-----------------------------------------------------------
On March 22, 2019, 9:09 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70243/
> -----------------------------------------------------------
>
> (Updated March 22, 2019, 9:09 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, Gastón Kleiman, and Joseph Wu.
>
>
> Bugs: MESOS-9318
> https://issues.apache.org/jira/browse/MESOS-9318
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch updates the operation reconciliation pipeline to
> forward some framework-initiated reconciliation requests to
> the agent. In cases where an explicit reconciliation request
> specifies an operation which is not recognized on a resource
> provider which is also not recognized, the master will
> forward the request to the agent so that the resource
> provider manager can satisfy the request based on whether or
> not the resource provider has been seen before.
>
>
> Diffs
> -----
>
> src/master/master.cpp 9c4a9e83da94535873d72c902835f229c4f96320
> src/messages/messages.proto 633dddbaa874550f7f0d9513c608ed75b18059a8
> src/resource_provider/manager.cpp 7d3338ea7fbf330a25416f848db7742ad1bea52f
> src/slave/slave.cpp 36424f89a8c1f183febabcc9582975dd21213c25
>
>
> Diff: https://reviews.apache.org/r/70243/diff/3/
>
>
> Testing
> -------
>
> Testing details at the end of this chain.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 70243: Improved operation reconciliation for
unsubscribed resource providers.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70243/#review213892
-----------------------------------------------------------
src/master/master.cpp
Lines 9677-9678 (patched)
<https://reviews.apache.org/r/70243/#comment300002>
I feel like we usually try to avoid constructing entries via `operator[]`, but here it is intentional.
You can consider adding a note, so no one else thinks it is a mistake.
src/master/master.cpp
Lines 9695 (patched)
<https://reviews.apache.org/r/70243/#comment300003>
This statement looks out of place compared to the rest of the function, so a note might help:
```
// Defer sending the operation status update until after this loop,
// which coagulates any reconciliation operations into combined
// messages for the agent (`forwardedReconciliations`).
```
src/resource_provider/manager.cpp
Lines 626-628 (patched)
<https://reviews.apache.org/r/70243/#comment300004>
Is the `SlaveID` field here meant to be blank? I thought only external resource providers could omit this field.
src/slave/slave.cpp
Lines 4517-4527 (patched)
<https://reviews.apache.org/r/70243/#comment300006>
You could probably do without the ternary:
```
Option<UUID> operationUuid;
if (operation.has_operation_uuid()) {
operationUuid = operation.operation_uuid();
} else if (
operation.has_operation_id() &&
operationIds.contains(operation.operation_id())) {
operationUuid = operationIds.at(operation.operation_id());
}
```
- Joseph Wu
On March 21, 2019, 3:26 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70243/
> -----------------------------------------------------------
>
> (Updated March 21, 2019, 3:26 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, Gastón Kleiman, and Joseph Wu.
>
>
> Bugs: MESOS-9318
> https://issues.apache.org/jira/browse/MESOS-9318
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch updates the operation reconciliation pipeline to
> forward some framework-initiated reconciliation requests to
> the agent. In cases where an explicit reconciliation request
> specifies an operation which is not recognized on a resource
> provider which is also not recognized, the master will
> forward the request to the agent so that the resource
> provider manager can satisfy the request based on whether or
> not the resource provider has been seen before.
>
>
> Diffs
> -----
>
> include/mesos/resource_provider/resource_provider.proto 5ea9e2009209b1609619874ebd63cb1e2e698434
> src/master/master.cpp 9c4a9e83da94535873d72c902835f229c4f96320
> src/messages/messages.proto 633dddbaa874550f7f0d9513c608ed75b18059a8
> src/resource_provider/manager.cpp 7d3338ea7fbf330a25416f848db7742ad1bea52f
> src/slave/slave.cpp 36424f89a8c1f183febabcc9582975dd21213c25
>
>
> Diff: https://reviews.apache.org/r/70243/diff/2/
>
>
> Testing
> -------
>
> Testing details at the end of this chain.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 70243: Improved operation reconciliation for
unsubscribed resource providers.
Posted by Greg Mann <gr...@mesosphere.io>.
> On March 22, 2019, 1:24 a.m., Gastón Kleiman wrote:
> > include/mesos/resource_provider/resource_provider.proto
> > Lines 101-104 (patched)
> > <https://reviews.apache.org/r/70243/diff/1/?file=2132875#file2132875line101>
> >
> > I think we should document somewhere (either protos or in the reconciliation handlers, or maybe in both places?) the difference in semantics, i.e., exactly which cases are handled differently depending on who initiated the reconciliation request.
Ah, I realized that this proto change is actually not needed since I'm not forwarding anything to the RP. I did, however, update the comment in the `framework_id` field that I added to the `ReconcileOperationsMessage`, and updated the comments in the agent handler for that message.
> On March 22, 2019, 1:24 a.m., Gastón Kleiman wrote:
> > src/slave/slave.cpp
> > Lines 4524-4525 (patched)
> > <https://reviews.apache.org/r/70243/diff/1/?file=2132879#file2132879line4524>
> >
> > Nit:
> >
> > ```
> > } else if (operationId.isSome() && operationIds.contains(operationId.get())) {
> > ```
> >
> > But I like Joseph's suggestion better =).
Good point. Had to tweak a bit now that this map is indexed by (FrameworkID, OperationID).
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70243/#review213896
-----------------------------------------------------------
On March 22, 2019, 9:09 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70243/
> -----------------------------------------------------------
>
> (Updated March 22, 2019, 9:09 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, Gastón Kleiman, and Joseph Wu.
>
>
> Bugs: MESOS-9318
> https://issues.apache.org/jira/browse/MESOS-9318
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch updates the operation reconciliation pipeline to
> forward some framework-initiated reconciliation requests to
> the agent. In cases where an explicit reconciliation request
> specifies an operation which is not recognized on a resource
> provider which is also not recognized, the master will
> forward the request to the agent so that the resource
> provider manager can satisfy the request based on whether or
> not the resource provider has been seen before.
>
>
> Diffs
> -----
>
> src/master/master.cpp 9c4a9e83da94535873d72c902835f229c4f96320
> src/messages/messages.proto 633dddbaa874550f7f0d9513c608ed75b18059a8
> src/resource_provider/manager.cpp 7d3338ea7fbf330a25416f848db7742ad1bea52f
> src/slave/slave.cpp 36424f89a8c1f183febabcc9582975dd21213c25
>
>
> Diff: https://reviews.apache.org/r/70243/diff/3/
>
>
> Testing
> -------
>
> Testing details at the end of this chain.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 70243: Improved operation reconciliation for
unsubscribed resource providers.
Posted by Gastón Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70243/#review213896
-----------------------------------------------------------
include/mesos/resource_provider/resource_provider.proto
Lines 101-104 (patched)
<https://reviews.apache.org/r/70243/#comment300013>
I think we should document somewhere (either protos or in the reconciliation handlers, or maybe in both places?) the difference in semantics, i.e., exactly which cases are handled differently depending on who initiated the reconciliation request.
src/master/master.cpp
Lines 9684-9693 (patched)
<https://reviews.apache.org/r/70243/#comment300008>
Nit: I think the following version would be more concise:
```
ReconcileOperationsMessage::Operation* forwardedOperation = reconciliationMessage.add_operations();
forwardedOperation->mutable_operation_id()
->CopyFrom(operation.operation_id());
if (resourceProviderId.isSome()) {
forwardedOperation->mutable_resource_provider_id()
->CopyFrom(resourceProviderId.get());
}
```
src/slave/slave.cpp
Lines 4524-4525 (patched)
<https://reviews.apache.org/r/70243/#comment300011>
Nit:
```
} else if (operationId.isSome() && operationIds.contains(operationId.get())) {
```
But I like Joseph's suggestion better =).
- Gastón Kleiman
On March 21, 2019, 3:26 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70243/
> -----------------------------------------------------------
>
> (Updated March 21, 2019, 3:26 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, Gastón Kleiman, and Joseph Wu.
>
>
> Bugs: MESOS-9318
> https://issues.apache.org/jira/browse/MESOS-9318
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch updates the operation reconciliation pipeline to
> forward some framework-initiated reconciliation requests to
> the agent. In cases where an explicit reconciliation request
> specifies an operation which is not recognized on a resource
> provider which is also not recognized, the master will
> forward the request to the agent so that the resource
> provider manager can satisfy the request based on whether or
> not the resource provider has been seen before.
>
>
> Diffs
> -----
>
> include/mesos/resource_provider/resource_provider.proto 5ea9e2009209b1609619874ebd63cb1e2e698434
> src/master/master.cpp 9c4a9e83da94535873d72c902835f229c4f96320
> src/messages/messages.proto 633dddbaa874550f7f0d9513c608ed75b18059a8
> src/resource_provider/manager.cpp 7d3338ea7fbf330a25416f848db7742ad1bea52f
> src/slave/slave.cpp 36424f89a8c1f183febabcc9582975dd21213c25
>
>
> Diff: https://reviews.apache.org/r/70243/diff/2/
>
>
> Testing
> -------
>
> Testing details at the end of this chain.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 70243: Improved operation reconciliation for
unsubscribed resource providers.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70243/
-----------------------------------------------------------
(Updated March 21, 2019, 10:26 p.m.)
Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, Gastón Kleiman, and Joseph Wu.
Changes
-------
Updated the `operationIds` map operation to accommodate changes in the preceding patch.
Bugs: MESOS-9318
https://issues.apache.org/jira/browse/MESOS-9318
Repository: mesos
Description
-------
This patch updates the operation reconciliation pipeline to
forward some framework-initiated reconciliation requests to
the agent. In cases where an explicit reconciliation request
specifies an operation which is not recognized on a resource
provider which is also not recognized, the master will
forward the request to the agent so that the resource
provider manager can satisfy the request based on whether or
not the resource provider has been seen before.
Diffs (updated)
-----
include/mesos/resource_provider/resource_provider.proto 5ea9e2009209b1609619874ebd63cb1e2e698434
src/master/master.cpp 9c4a9e83da94535873d72c902835f229c4f96320
src/messages/messages.proto 633dddbaa874550f7f0d9513c608ed75b18059a8
src/resource_provider/manager.cpp 7d3338ea7fbf330a25416f848db7742ad1bea52f
src/slave/slave.cpp 36424f89a8c1f183febabcc9582975dd21213c25
Diff: https://reviews.apache.org/r/70243/diff/2/
Changes: https://reviews.apache.org/r/70243/diff/1-2/
Testing
-------
Testing details at the end of this chain.
Thanks,
Greg Mann
Re: Review Request 70243: Improved operation reconciliation for
unsubscribed resource providers.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70243/
-----------------------------------------------------------
(Updated March 20, 2019, 7:08 p.m.)
Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, Gastón Kleiman, and Joseph Wu.
Summary (updated)
-----------------
Improved operation reconciliation for unsubscribed resource providers.
Bugs: MESOS-9318
https://issues.apache.org/jira/browse/MESOS-9318
Repository: mesos
Description
-------
This patch updates the operation reconciliation pipeline to
forward some framework-initiated reconciliation requests to
the agent. In cases where an explicit reconciliation request
specifies an operation which is not recognized on a resource
provider which is also not recognized, the master will
forward the request to the agent so that the resource
provider manager can satisfy the request based on whether or
not the resource provider has been seen before.
Diffs
-----
include/mesos/resource_provider/resource_provider.proto 5ea9e2009209b1609619874ebd63cb1e2e698434
src/master/master.cpp dc68fc324de7242737123015fbac19a2129778ce
src/messages/messages.proto 633dddbaa874550f7f0d9513c608ed75b18059a8
src/resource_provider/manager.cpp 7d3338ea7fbf330a25416f848db7742ad1bea52f
src/slave/slave.cpp 36424f89a8c1f183febabcc9582975dd21213c25
Diff: https://reviews.apache.org/r/70243/diff/1/
Testing
-------
Testing details at the end of this chain.
Thanks,
Greg Mann
Re: Review Request 70243: Improved operation reconciliation in the
agent and RP manager.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70243/
-----------------------------------------------------------
(Updated March 20, 2019, 7:07 p.m.)
Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, Gastón Kleiman, and Joseph Wu.
Summary (updated)
-----------------
Improved operation reconciliation in the agent and RP manager.
Bugs: MESOS-9318
https://issues.apache.org/jira/browse/MESOS-9318
Repository: mesos
Description
-------
This patch updates the operation reconciliation pipeline to
forward some framework-initiated reconciliation requests to
the agent. In cases where an explicit reconciliation request
specifies an operation which is not recognized on a resource
provider which is also not recognized, the master will
forward the request to the agent so that the resource
provider manager can satisfy the request based on whether or
not the resource provider has been seen before.
Diffs
-----
include/mesos/resource_provider/resource_provider.proto 5ea9e2009209b1609619874ebd63cb1e2e698434
src/master/master.cpp dc68fc324de7242737123015fbac19a2129778ce
src/messages/messages.proto 633dddbaa874550f7f0d9513c608ed75b18059a8
src/resource_provider/manager.cpp 7d3338ea7fbf330a25416f848db7742ad1bea52f
src/slave/slave.cpp 36424f89a8c1f183febabcc9582975dd21213c25
Diff: https://reviews.apache.org/r/70243/diff/1/
Testing
-------
Testing details at the end of this chain.
Thanks,
Greg Mann