[GitHub] [hadoop] steveloughran edited a comment on pull request #2149: HADOOP-13230. S3A to optionally retain directory markers

[GitBox <gi...@apache.org>]

steveloughran edited a comment on pull request #2149:
URL: https://github.com/apache/hadoop/pull/2149#issuecomment-674023379


   @iwasakims thanks for that review.
   
   checkstyles in, and feedback from Gabor: we now have static path capabilities probes for bucket policy as well as the dynamic "what will happen on this path". All in DirectoryPolicyImpl, so it can be unit tested too!
   
   Testing: s3 london: -Dparallel-tests -DtestsThreadCount=4 -Dmarkers=keep  -Dscale. 
   
   and
   -Dparallel-tests -DtestsThreadCount=4 -Dmarkers=delete -Ds3guard -Ddynamo -Dscale -Dfs.s3a.directory.marker.audit=true
   
   The first test run failed in ITestS3AConfiguration.testProxyConnection; one I've seen before, where an expected failure on proxies succeeds -this on a bucket where I've disabled existence checks. Doesn't happen when guarded. Hypothesis: when s3guard is on, the proxy issues surface in initialize(), when off: not until the first FS connection. Filed https://issues.apache.org/jira/browse/HADOOP-17207
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org