You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Tobias Ringström <to...@ringstrom.mine.nu> on 2004/09/29 23:20:31 UTC
[PATCH] SVNPathAuthz is broken
The SVNPathAuthz directive which was introduced recently is broken in
the sense that you can only set it to off in the topmost scope in the
config file, i.e. is not possible to say "SVNPathAuthz Off" in a
Location block. The following patch fixes the problem and a similar
problem for SVNAutoversioning, but I don't have time to run the test
suite etc right now, so I'm posting the patch here instead. I'll commit
it tomorrow when I know that it passes all tests.
Note that there is at least one problem left, because ls is a lot slower
than before, even with SVNPathAuthz off.
/Tobias
[[[
Fix the inheritence of SVNPathAuthz and SVNAutoversioning by turning
them into tri-state values (default, on, off).
* subversion/mod_dav_svn/mod_dav_svn.c
(dav_svn_flag): New tri-state enum.
(dav_svn_dir_conf): Use dav_svn_flag for autoversioning and
do_path_authz.
(dav_svn_create_dir_config): Zero is default for all values now.
(dav_svn_autoversioning_cmd, dav_svn_pathauthz_cmd): Use
dav_svn_flag values.
(dav_svn_get_autoversioning_flag): It's only on if it's explicitly
set to on.
(dav_svn_get_pathauthz_flag): If's only off if it's explicitly set
to off.
]]]