You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Sid Wagle <sw...@hortonworks.com> on 2014/07/01 00:47:41 UTC
Review Request 23182: HA Wizard: can't initialize JournalNodes
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23182/
-----------------------------------------------------------
Review request for Ambari, Mahadev Konar and Tom Beerbower.
Bugs: AMBARI-6325
https://issues.apache.org/jira/browse/AMBARI-6325
Repository: ambari
Description
-------
*STR*
# Deploy Ambari with HDP 2.1
# Open enable HA wizard
# Go through steps
# On the step "Manual Steps Required: Initialize JournalNodes"
# When performing command
{code}
sudo su -l hdfs -c 'hdfs namenode -initializeSharedEdits'
{code}
"Next" button is not enabled.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractPropertyProvider.java db914ec
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractPropertyProviderTest.java c5fd49d
Diff: https://reviews.apache.org/r/23182/diff/
Testing
-------
Tests passed.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 34.281s
[INFO] Finished at: Mon Jun 30 15:44:55 PDT 2014
[INFO] Final Memory: 39M/649M
[INFO] ------------------------------------------------------------------------
Thanks,
Sid Wagle
Re: Review Request 23182: HA Wizard: can't initialize JournalNodes
Posted by Siddharth Wagle <sw...@hortonworks.com>.
Thanks for the review, making the change and committing.
On Mon, Jun 30, 2014 at 4:04 PM, Tom Beerbower <tb...@hortonworks.com>
wrote:
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23182/
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractPropertyProvider.java
> <https://reviews.apache.org/r/23182/diff/1/?file=620664#file620664line321> (Diff
> revision 1)
>
> protected boolean isSupportedPropertyId(String componentName, String propertyId) {
>
> 320
>
> String category = PropertyHelper.getPropertyCategory(propertyId);
>
> You can move this line below the following if block so you don't pay the cost if the if check succeeds. Looks good otherwise.
>
>
> - Tom Beerbower
>
> On June 30th, 2014, 10:47 p.m. UTC, Sid Wagle wrote:
> Review request for Ambari, Mahadev Konar and Tom Beerbower.
> By Sid Wagle.
>
> *Updated June 30, 2014, 10:47 p.m.*
> *Bugs: * AMBARI-6325 <https://issues.apache.org/jira/browse/AMBARI-6325>
> *Repository: * ambari
> Description
>
> *STR*
> # Deploy Ambari with HDP 2.1
> # Open enable HA wizard
> # Go through steps
> # On the step "Manual Steps Required: Initialize JournalNodes"
> # When performing command
> {code}
> sudo su -l hdfs -c 'hdfs namenode -initializeSharedEdits'
> {code}
> "Next" button is not enabled.
>
> Testing
>
> Tests passed.
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 34.281s
> [INFO] Finished at: Mon Jun 30 15:44:55 PDT 2014
> [INFO] Final Memory: 39M/649M
> [INFO] ------------------------------------------------------------------------
>
> Diffs
>
> - ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractPropertyProvider.java
> (db914ec)
> - ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractPropertyProviderTest.java
> (c5fd49d)
>
> View Diff <https://reviews.apache.org/r/23182/diff/>
>
--
CONFIDENTIALITY NOTICE
NOTICE: This message is intended for the use of the individual or entity to
which it is addressed and may contain information that is confidential,
privileged and exempt from disclosure under applicable law. If the reader
of this message is not the intended recipient, you are hereby notified that
any printing, copying, dissemination, distribution, disclosure or
forwarding of this communication is strictly prohibited. If you have
received this communication in error, please contact the sender immediately
and delete it from your system. Thank You.
Re: Review Request 23182: HA Wizard: can't initialize JournalNodes
Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23182/#review47024
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractPropertyProvider.java
<https://reviews.apache.org/r/23182/#comment82628>
You can move this line below the following if block so you don't pay the cost if the if check succeeds. Looks good otherwise.
- Tom Beerbower
On June 30, 2014, 10:47 p.m., Sid Wagle wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23182/
> -----------------------------------------------------------
>
> (Updated June 30, 2014, 10:47 p.m.)
>
>
> Review request for Ambari, Mahadev Konar and Tom Beerbower.
>
>
> Bugs: AMBARI-6325
> https://issues.apache.org/jira/browse/AMBARI-6325
>
>
> Repository: ambari
>
>
> Description
> -------
>
> *STR*
> # Deploy Ambari with HDP 2.1
> # Open enable HA wizard
> # Go through steps
> # On the step "Manual Steps Required: Initialize JournalNodes"
> # When performing command
> {code}
> sudo su -l hdfs -c 'hdfs namenode -initializeSharedEdits'
> {code}
> "Next" button is not enabled.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractPropertyProvider.java db914ec
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractPropertyProviderTest.java c5fd49d
>
> Diff: https://reviews.apache.org/r/23182/diff/
>
>
> Testing
> -------
>
> Tests passed.
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 34.281s
> [INFO] Finished at: Mon Jun 30 15:44:55 PDT 2014
> [INFO] Final Memory: 39M/649M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Sid Wagle
>
>
Re: Review Request 23182: HA Wizard: can't initialize JournalNodes
Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23182/#review47057
-----------------------------------------------------------
Ship it!
Ship It!
- Tom Beerbower
On June 30, 2014, 11:20 p.m., Sid Wagle wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23182/
> -----------------------------------------------------------
>
> (Updated June 30, 2014, 11:20 p.m.)
>
>
> Review request for Ambari, Mahadev Konar and Tom Beerbower.
>
>
> Bugs: AMBARI-6325
> https://issues.apache.org/jira/browse/AMBARI-6325
>
>
> Repository: ambari
>
>
> Description
> -------
>
> *STR*
> # Deploy Ambari with HDP 2.1
> # Open enable HA wizard
> # Go through steps
> # On the step "Manual Steps Required: Initialize JournalNodes"
> # When performing command
> {code}
> sudo su -l hdfs -c 'hdfs namenode -initializeSharedEdits'
> {code}
> "Next" button is not enabled.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractPropertyProvider.java db914ec
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractPropertyProviderTest.java c5fd49d
>
> Diff: https://reviews.apache.org/r/23182/diff/
>
>
> Testing
> -------
>
> Tests passed.
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 34.281s
> [INFO] Finished at: Mon Jun 30 15:44:55 PDT 2014
> [INFO] Final Memory: 39M/649M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Sid Wagle
>
>
Re: Review Request 23182: HA Wizard: can't initialize JournalNodes
Posted by Mahadev Konar <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23182/#review47029
-----------------------------------------------------------
Ship it!
Ship It!
- Mahadev Konar
On June 30, 2014, 11:20 p.m., Sid Wagle wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23182/
> -----------------------------------------------------------
>
> (Updated June 30, 2014, 11:20 p.m.)
>
>
> Review request for Ambari, Mahadev Konar and Tom Beerbower.
>
>
> Bugs: AMBARI-6325
> https://issues.apache.org/jira/browse/AMBARI-6325
>
>
> Repository: ambari
>
>
> Description
> -------
>
> *STR*
> # Deploy Ambari with HDP 2.1
> # Open enable HA wizard
> # Go through steps
> # On the step "Manual Steps Required: Initialize JournalNodes"
> # When performing command
> {code}
> sudo su -l hdfs -c 'hdfs namenode -initializeSharedEdits'
> {code}
> "Next" button is not enabled.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractPropertyProvider.java db914ec
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractPropertyProviderTest.java c5fd49d
>
> Diff: https://reviews.apache.org/r/23182/diff/
>
>
> Testing
> -------
>
> Tests passed.
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 34.281s
> [INFO] Finished at: Mon Jun 30 15:44:55 PDT 2014
> [INFO] Final Memory: 39M/649M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Sid Wagle
>
>
Re: Review Request 23182: HA Wizard: can't initialize JournalNodes
Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23182/
-----------------------------------------------------------
(Updated June 30, 2014, 11:20 p.m.)
Review request for Ambari, Mahadev Konar and Tom Beerbower.
Changes
-------
Made changes based on comment.
Bugs: AMBARI-6325
https://issues.apache.org/jira/browse/AMBARI-6325
Repository: ambari
Description
-------
*STR*
# Deploy Ambari with HDP 2.1
# Open enable HA wizard
# Go through steps
# On the step "Manual Steps Required: Initialize JournalNodes"
# When performing command
{code}
sudo su -l hdfs -c 'hdfs namenode -initializeSharedEdits'
{code}
"Next" button is not enabled.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractPropertyProvider.java db914ec
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractPropertyProviderTest.java c5fd49d
Diff: https://reviews.apache.org/r/23182/diff/
Testing
-------
Tests passed.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 34.281s
[INFO] Finished at: Mon Jun 30 15:44:55 PDT 2014
[INFO] Final Memory: 39M/649M
[INFO] ------------------------------------------------------------------------
Thanks,
Sid Wagle