You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@nuttx.apache.org by Tim Hardisty <ti...@jti.uk.com.INVALID> on 2022/11/15 19:25:16 UTC

Will a PR be ignored if it fails checks?

As subject really. My (first real) PR failed some checks due to an unused variable. An easy fix, but I wanted to wait for any other feedback before resubmitting....but not much point waiting if the fail will mean no one reviews it lol.

What's the process?

Re: Will a PR be ignored if it fails checks?

Posted by Tim Hardisty <ti...@jti.uk.com.INVALID>.

Thanks Nathan - I have already left such a comment on the PR.

On 15/11/2022, 22:14, "Nathan Hartman" <ha...@gmail.com> wrote:

    On Tue, Nov 15, 2022 at 2:25 PM Tim Hardisty <ti...@jti.uk.com.invalid>
    wrote:

    > As subject really. My (first real) PR failed some checks due to an unused
    > variable. An easy fix, but I wanted to wait for any other feedback before
    > resubmitting....but not much point waiting if the fail will mean no one
    > reviews it lol.
    >
    > What's the process?



    PRs are not ignored. Generally you can just fix the problem and push to the
    branch.

    For certain test failures, sometimes we even ignore the failures and merge,
    such as if the PR fixes a typo or something and there's a NXSTYLE violation
    elsewhere in the file that has been there for a long time and would be
    nontrivial to fix and totally outside the scope of the PR.

    For important test failures, like compiler warnings or whatever, they
    should be fixed.

    You could comment on the PR that you know about the fail and would like
    other feedback in the meantime.

    Also feel free to request reviews on Git Hub from people who generally work
    on those areas.

    Hope this helps
    Nathan

Re: Will a PR be ignored if it fails checks?

Posted by Nathan Hartman <ha...@gmail.com>.

On Tue, Nov 15, 2022 at 2:25 PM Tim Hardisty <ti...@jti.uk.com.invalid>
wrote:

> As subject really. My (first real) PR failed some checks due to an unused
> variable. An easy fix, but I wanted to wait for any other feedback before
> resubmitting....but not much point waiting if the fail will mean no one
> reviews it lol.
>
> What's the process?

PRs are not ignored. Generally you can just fix the problem and push to the
branch.

For certain test failures, sometimes we even ignore the failures and merge,
such as if the PR fixes a typo or something and there's a NXSTYLE violation
elsewhere in the file that has been there for a long time and would be
nontrivial to fix and totally outside the scope of the PR.

For important test failures, like compiler warnings or whatever, they
should be fixed.

You could comment on the PR that you know about the fail and would like
other feedback in the meantime.

Also feel free to request reviews on Git Hub from people who generally work
on those areas.

Hope this helps
Nathan

RE: Will a PR be ignored if it fails checks?

Posted by "Alin.Jerpelea@sony.com" <Al...@sony.com>.

Hi Tim, 

I usually do the following steps: 
- compile locally the patch and test it 
- run nxstyle to ensure that there are no errors
- let the CI run and fix errors
- wait for others to review and comment 

Best regards
Alin


-----Original Message-----
From: Tim Hardisty <ti...@jti.uk.com.INVALID> 
Sent: den 16 november 2022 11:58
To: dev@nuttx.apache.org
Subject: Re: Will a PR be ignored if it fails checks?

Hi Alin,

Ok - will do.

I ran the checkpatch script as per guides - should I have done something else as well before submitting a PR?

Thanks,

Tim.

On 16/11/2022, 08:00, "Alin.Jerpelea@sony.com" <Al...@sony.com> wrote:

    Hi Tim,

    Please fix the warning / error without waiting for someone to review it. 

    Best regards
    Alin


    -----Original Message-----
    From: Tim Hardisty <ti...@jti.uk.com.INVALID> 
    Sent: den 15 november 2022 20:25
    To: dev@nuttx.apache.org
    Subject: Will a PR be ignored if it fails checks?

    As subject really. My (first real) PR failed some checks due to an unused variable. An easy fix, but I wanted to wait for any other feedback before resubmitting....but not much point waiting if the fail will mean no one reviews it lol.

    What's the process?

Re: Will a PR be ignored if it fails checks?

Posted by Tim Hardisty <ti...@jti.uk.com.INVALID>.

Hi Alin,

Ok - will do.

I ran the checkpatch script as per guides - should I have done something else as well before submitting a PR?

Thanks,

Tim.

On 16/11/2022, 08:00, "Alin.Jerpelea@sony.com" <Al...@sony.com> wrote:

    Hi Tim,

    Please fix the warning / error without waiting for someone to review it. 

    Best regards
    Alin


    -----Original Message-----
    From: Tim Hardisty <ti...@jti.uk.com.INVALID> 
    Sent: den 15 november 2022 20:25
    To: dev@nuttx.apache.org
    Subject: Will a PR be ignored if it fails checks?

    As subject really. My (first real) PR failed some checks due to an unused variable. An easy fix, but I wanted to wait for any other feedback before resubmitting....but not much point waiting if the fail will mean no one reviews it lol.

    What's the process?

RE: Will a PR be ignored if it fails checks?

Posted by "Alin.Jerpelea@sony.com" <Al...@sony.com>.

Hi Tim,

Please fix the warning / error without waiting for someone to review it. 

Best regards
Alin


-----Original Message-----
From: Tim Hardisty <ti...@jti.uk.com.INVALID> 
Sent: den 15 november 2022 20:25
To: dev@nuttx.apache.org
Subject: Will a PR be ignored if it fails checks?

As subject really. My (first real) PR failed some checks due to an unused variable. An easy fix, but I wanted to wait for any other feedback before resubmitting....but not much point waiting if the fail will mean no one reviews it lol.

What's the process?