You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by Trustin Lee <tr...@gmail.com> on 2007/01/04 03:38:34 UTC
Re: code formatting rules
On 11/21/06, Niklas Therning <ni...@trillian.se> wrote:
>
> peter royal wrote:
> > On Nov 16, 2006, at 7:42 AM, Julien Vermillard wrote:
> >> I know some MINA commiter (most?) don't like the current code formating
> >> rules inherited from ADS. It could make integration of patch and
> >> contributors easier.
> >>
> >> So perhaps we can change to std java formating rules for trunk (2.0) ?
> >
> > I'd be happy to use something closer to the standard java rules.
> > -
> Me too. I think that Sun's cod conventions
> (http://java.sun.com/docs/codeconv/) is the most widely used out there.
> Switching to something closer to those rules would definitely make it
> easier for MINA users to submit patches and easier for us to apply them.
>
> Though as long as I have Eclipse's Ctrl+Shift+F I'll get by. :)
It seems like at least four committers including me wants the Java standard
coding convention. Then what do you think about applying the new formatting
in trunk from now on? We could reformat one by one when we have something
to commit. Here are the Eclipse formatter setting files:
http://mina.apache.org/developer-guide.html#DeveloperGuide-CodingConvention
Trustin
--
what we call human nature is actually human habit
--
http://gleamynode.net/
--
PGP key fingerprints:
* E167 E6AF E73A CBCE EE41 4A29 544D DE48 FE95 4E7E
* B693 628E 6047 4F8F CFA4 455E 1C62 A7DC 0255 ECA6
Re: code formatting rules
Posted by Emmanuel Lecharny <el...@gmail.com>.
Just 2 more cts,
choosing java code rule standard could also help exploiting tools like
checkstyle or whatever. Of course, the first step would be to use those
tools :)
btw, I have recently plaid with FindBugs, and found it quite interesting (
http://findbugs.sourceforge.net/). It helped me to clean a hell too much
potential NPE in ADS !!! Did'nt had time to apply it to mina so far.
Emmanuel
btw, +1 for JCC, not that my opinion is really important, but as a lot of
mina committers want to switch to it, I think that having the larger
approval is the best.
On 1/4/07, Niklas Therning <ni...@trillian.se> wrote:
>
> Trustin Lee wrote:
> >
> >
> > It seems like at least four committers including me wants the Java
> > standard
> > coding convention. Then what do you think about applying the new
> > formatting
> > in trunk from now on? We could reformat one by one when we have
> > something
> > to commit. Here are the Eclipse formatter setting files:
> >
> >
> http://mina.apache.org/developer-guide.html#DeveloperGuide-CodingConvention
> >
> >
> > Trustin
> +1!
>
> --
> Niklas Therning
> www.spamdrain.net
>
>
--
Cordialement,
Emmanuel Lécharny
www.iktek.com
Re: code formatting rules
Posted by Niklas Therning <ni...@trillian.se>.
Trustin Lee wrote:
>
>
> It seems like at least four committers including me wants the Java
> standard
> coding convention. Then what do you think about applying the new
> formatting
> in trunk from now on? We could reformat one by one when we have
> something
> to commit. Here are the Eclipse formatter setting files:
>
> http://mina.apache.org/developer-guide.html#DeveloperGuide-CodingConvention
>
>
> Trustin
+1!
--
Niklas Therning
www.spamdrain.net
Re: code formatting rules
Posted by "John E. Conlon" <jc...@verticon.com>.
+1
On Thu, 2007-01-04 at 11:38 +0900, Trustin Lee wrote:
> On 11/21/06, Niklas Therning <ni...@trillian.se> wrote:
> >
> > peter royal wrote:
> > > On Nov 16, 2006, at 7:42 AM, Julien Vermillard wrote:
> > >> I know some MINA commiter (most?) don't like the current code formating
> > >> rules inherited from ADS. It could make integration of patch and
> > >> contributors easier.
> > >>
> > >> So perhaps we can change to std java formating rules for trunk (2.0) ?
> > >
> > > I'd be happy to use something closer to the standard java rules.
> > > -
> > Me too. I think that Sun's cod conventions
> > (http://java.sun.com/docs/codeconv/) is the most widely used out there.
> > Switching to something closer to those rules would definitely make it
> > easier for MINA users to submit patches and easier for us to apply them.
> >
> > Though as long as I have Eclipse's Ctrl+Shift+F I'll get by. :)
>
>
> It seems like at least four committers including me wants the Java standard
> coding convention. Then what do you think about applying the new formatting
> in trunk from now on? We could reformat one by one when we have something
> to commit. Here are the Eclipse formatter setting files:
>
> http://mina.apache.org/developer-guide.html#DeveloperGuide-CodingConvention
>
> Trustin
Re: code formatting rules
Posted by Mike Heath <mh...@apache.org>.
> It seems like at least four committers including me wants the Java standard
> coding convention. Then what do you think about applying the new formatting
> in trunk from now on? We could reformat one by one when we have something
> to commit. Here are the Eclipse formatter setting files:
>
> http://mina.apache.org/developer-guide.html#DeveloperGuide-CodingConvention
+1