You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by HyukjinKwon <gi...@git.apache.org> on 2017/05/05 13:53:52 UTC

[GitHub] spark pull request #17861: [SPARK-20613] Remove excess quotes in Windows exe...

Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17861#discussion_r115001274
  
    --- Diff: bin/spark-class2.cmd ---
    @@ -64,7 +64,7 @@ if not "x%JAVA_HOME%"=="x" (
     rem The launcher library prints the command to be executed in a single line suitable for being
     rem executed by the batch interpreter. So read all the output of the launcher into a variable.
     set LAUNCHER_OUTPUT=%temp%\spark-class-launcher-output-%RANDOM%.txt
    -"%RUNNER%" -Xmx128m -cp "%LAUNCH_CLASSPATH%" org.apache.spark.launcher.Main %* > %LAUNCHER_OUTPUT%
    --- End diff --
    
    FWIW, it looks has been fine in AppVeyor as below:
    
    ```cmd
    echo %JAVA_HOME%
    C:\Progra~1\Java\jdk1.8.0
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org