You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/08/04 00:17:52 UTC

[GitHub] [cordova-android] leofernandesmo opened a new pull request #1038: Removed duplicate code in test

leofernandesmo opened a new pull request #1038:
URL: https://github.com/apache/cordova-android/pull/1038


   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   All
   
   ### Motivation and Context
   <!-- Why is this change required? What problem does it solve? -->
   <!-- If it fixes an open issue, please link to the issue here. -->
   Test code may contain undesirable duplication. Solutions are similar to those for normal code duplication as described by Fowler. 
   Removing duplication helps maintainability of the test.
   
   between tests. A special case of code duplication is test implication: test A and B cover the same production code, and A fails if and only if B fails. A typical example occurs when the production code gets refactored: before this refactoring, A and B covered different code, but afterwards they deal with the same code and it is not necessary anymore to maintain both
   tests. [VANDEURSEN2001]
   
   
   
   ### Description
   <!-- Describe your changes in detail -->
   I applied extract method and defined constants for duplicate strings.
   
   
   ### Testing
   <!-- Please describe in detail how you tested your changes. -->
   
   
   ### Checklist
   
   - [ ] I've run the tests to see all new and existing tests pass
   - [ ] I added automated test coverage as appropriate for this change
   - [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
   - [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   - [ ] I've updated the documentation if necessary
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-android] breautek commented on pull request #1038: test(java): remove duplicate code in BackButtonMultipageTest

Posted by GitBox <gi...@apache.org>.
breautek commented on pull request #1038:
URL: https://github.com/apache/cordova-android/pull/1038#issuecomment-731494936


   PR forcefully closed when I rebased the PR branch with apache's master. Supposedly because there are no new commits however I still have the original change commit... looks like I'm going to have to open a new PR for it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-android] raphinesse commented on a change in pull request #1038: Removed duplicate code in test

Posted by GitBox <gi...@apache.org>.
raphinesse commented on a change in pull request #1038:
URL: https://github.com/apache/cordova-android/pull/1038#discussion_r500122135



##########
File path: test/android/app/src/androidTest/java/org/apache/cordova/unittests/BackButtonMultipageTest.java
##########
@@ -140,19 +142,28 @@ public void testViaBackButtonOnView() throws Throwable {
 
         mActivityRule.runOnUiThread(new Runnable() {
             public void run() {
-                webInterface.loadUrl("file:///android_asset/www/backbuttonmultipage/sample2.html");
+                webInterface.loadUrl(SAMPLE2_URL);
             }
         });
-        assertEquals("file:///android_asset/www/backbuttonmultipage/sample2.html", mActivity.onPageFinishedUrl.take());
+        assertPageSample2();
         mActivityRule.runOnUiThread(new Runnable() {
             public void run() {
-                webInterface.loadUrl("file:///android_asset/www/backbuttonmultipage/sample3.html");
+                webInterface.loadUrl(SAMPLE3_URL);
             }
         });
-        assertEquals("file:///android_asset/www/backbuttonmultipage/sample3.html", mActivity.onPageFinishedUrl.take());
+        assertPageSample3();
         onView(withId(WEBVIEW_ID)).perform(pressBack());
-        assertEquals("file:///android_asset/www/backbuttonmultipage/sample2.html", mActivity.onPageFinishedUrl.take());
+        assertPageSample2();
         onView(withId(WEBVIEW_ID)).perform(pressBack());
         assertEquals(START_URL, mActivity.onPageFinishedUrl.take());
     }
+
+    private void assertPageSample3() {

Review comment:
       I would prefer having a single helper `assertOnPage(String url)` and then calling it with `SAMPLE2_URL` and `SAMPLE3_URL`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-android] breautek edited a comment on pull request #1038: test(java): remove duplicate code in BackButtonMultipageTest

Posted by GitBox <gi...@apache.org>.
breautek edited a comment on pull request #1038:
URL: https://github.com/apache/cordova-android/pull/1038#issuecomment-731494936


   PR forcefully closed when I rebased the PR branch with apache's master. Supposedly because there are no new commits however I still have the original change commit... looks like I'm going to have to open a new PR for it.
   
   I think this was caused because this original PR was linked to their master branch.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-android] breautek closed pull request #1038: test(java): remove duplicate code in BackButtonMultipageTest

Posted by GitBox <gi...@apache.org>.
breautek closed pull request #1038:
URL: https://github.com/apache/cordova-android/pull/1038


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org