You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Max Bowsher <ma...@ukf.net> on 2004/09/17 20:04:20 UTC
Java bindings question - pmayweg?
I merged r9883, r9905 to 1.0.x, but whilst doing so, noticed this:
+ jclass clazz = env->FindClass("java/lang/NullPointerException");
+ if(isJavaExceptionThrown())
+ {
+ return;
+ }
+ env->ThrowNew(clazz, message);
+ setExceptionThrown();
+ env->DeleteLocalRef(clazz);
I know nothing about JNI, but just wanted to comment that it seemed odd to
initialize clazz and then maybe not use it.
Is a reference to clazz being leaked here in the isJavaExceptionThrown ==
true case?
Max.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org