You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2021/04/23 11:38:44 UTC

[GitHub] [couchdb] iilyak opened a new pull request #3525: Export parse_pos_int/1, parse_pos_int/1 and parse_boolean/1

iilyak opened a new pull request #3525:
URL: https://github.com/apache/couchdb/pull/3525


   ## Overview
   
   We used to have public `parse_pos/1`, `parse_pos_int/1` and `parse_boolean/1` and they were used by one of the EPI plugins.
   This PR exports these functions again.
   
   ## Testing recommendations
   
   Compilation without new warnings is enough to test it.
   
   ## Related Issues or Pull Requests
   
   - This was changed in https://github.com/apache/couchdb/pull/3503
   
   ## Checklist
   
   - [x] Code is written and works correctly
   - [ ] Changes are covered by tests
   - [ ] Any new configurable parameters are documented in `rel/overlay/etc/default.ini`
   - [ ] A PR for documentation changes has been made in https://github.com/apache/couchdb-documentation
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb] iilyak commented on pull request #3525: Export parse_int/1, parse_pos_int/1 and parse_boolean/1

Posted by GitBox <gi...@apache.org>.
iilyak commented on pull request #3525:
URL: https://github.com/apache/couchdb/pull/3525#issuecomment-825622497


   > These functions seem like they belong somewhere else entirely, though.
   
   Maybe new application where we would be having only utility functions. 
   
   - parsing
   - json
   
   The rationale for a new application is to avoid circular dependencies. The new application shouldn't depend on anything else from couchDB.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb] rnewson commented on pull request #3525: Export parse_int/1, parse_pos_int/1 and parse_boolean/1

Posted by GitBox <gi...@apache.org>.
rnewson commented on pull request #3525:
URL: https://github.com/apache/couchdb/pull/3525#issuecomment-825600343


   we prefer to expose functions via the "top" module, in this case that would be couch_views.erl, so that we aren't coupling applications so delicately. These functions seem like they belong somewhere else entirely, though.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb] iilyak commented on pull request #3525: Export parse_int/1, parse_pos_int/1 and parse_boolean/1

Posted by GitBox <gi...@apache.org>.
iilyak commented on pull request #3525:
URL: https://github.com/apache/couchdb/pull/3525#issuecomment-827031314


   Closing in favor of https://github.com/apache/couchdb/pull/3529


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb] iilyak closed pull request #3525: Export parse_int/1, parse_pos_int/1 and parse_boolean/1

Posted by GitBox <gi...@apache.org>.
iilyak closed pull request #3525:
URL: https://github.com/apache/couchdb/pull/3525


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb] rnewson commented on pull request #3525: Export parse_int/1, parse_pos_int/1 and parse_boolean/1

Posted by GitBox <gi...@apache.org>.
rnewson commented on pull request #3525:
URL: https://github.com/apache/couchdb/pull/3525#issuecomment-825649295


   a new library application sounds right.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org