You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/09/08 10:03:01 UTC

[GitHub] [arrow] xhochy commented on a change in pull request #8114: ARROW-9588: [C++] Partially support building with clang in an MSVC setting

xhochy commented on a change in pull request #8114:
URL: https://github.com/apache/arrow/pull/8114#discussion_r484801005



##########
File path: cpp/src/arrow/python/type_traits.h
##########
@@ -105,7 +105,7 @@ struct npy_traits<NPY_FLOAT32> {
   using TypeClass = FloatType;
   using BuilderClass = FloatBuilder;
 
-  static constexpr float na_sentinel = NAN;
+  static constexpr float na_sentinel = std::numeric_limits<float>::quiet_NaN();

Review comment:
       Added a comment, the issue is that the Windows implementation of the macro is not fully compatible with clang's stictness.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org