[jira] [Commented] (TS-863) I want to be able to set proxy.config.http.keep_alive_no_activity_timeout_out per-transaction

["Leif Hedstrom (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TS-863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13060017#comment-13060017 ] 

Leif Hedstrom commented on TS-863:
----------------------------------

William: Looking at this code, the second sets of disabled code seems fine (the old comment even says so). But the first one I'm a little more worried about. Specially with the Debug saying


reseting timeout to maintain minimum number of connections


I didn't even know we had such a setting (minimum number of origin connections), and it seems disabled by default. Have you verified that these code changes does not affect that behaviour/feature?

Cheers,

-- leif


> I want to be able to set proxy.config.http.keep_alive_no_activity_timeout_out per-transaction
> ---------------------------------------------------------------------------------------------
>
>                 Key: TS-863
>                 URL: https://issues.apache.org/jira/browse/TS-863
>             Project: Traffic Server
>          Issue Type: New Feature
>          Components: HTTP
>    Affects Versions: 3.0.0
>            Reporter: William Bardwell
>            Priority: Minor
>             Fix For: 3.1.0
>
>         Attachments: keep_alive_out.diff
>
>
> I want to be able to set this the same as you can set proxy.config.http.keep_alive_no_activity_timeout_in.
> I have a patch, but it just turns off a couple of calls, which seems wrong because I suspect that those calls are supposed to re-set the 'active'-ness of the connections, but it works reasonably for me even so.  (The calls are disabled because they are being made after the code doesn't have a transaction to check the config in.)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira