You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/12/25 18:43:21 UTC
[GitHub] [flink] Myasuka opened a new pull request #10692: [FLINK-15387]
Expose missing RocksDB properties out via RocksDBNativeMetricOptions
Myasuka opened a new pull request #10692: [FLINK-15387] Expose missing RocksDB properties out via RocksDBNativeMetricOptions
URL: https://github.com/apache/flink/pull/10692
## What is the purpose of the change
Expose missing RocksDB properties out via `RocksDBNativeMetricOptions`, e.g block cache related properties.
## Brief change log
Add `is-write-stopped`, `block-cache-capacity`, `block-cache-usage` and `block-cache-pinned-usage`.
Other string format rocksdb property is not added.
## Verifying this change
This change is already covered by existing tests, such as `RocksDBPropertyTest`.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] carp84 commented on issue #10692: [FLINK-15387] Expose
missing RocksDB properties out via RocksDBNativeMetricOptions
Posted by GitBox <gi...@apache.org>.
carp84 commented on issue #10692: [FLINK-15387] Expose missing RocksDB properties out via RocksDBNativeMetricOptions
URL: https://github.com/apache/flink/pull/10692#issuecomment-572907230
I'm planning to merge this and please let me know if still any concerns @zentol , thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] Myasuka commented on a change in pull request #10692:
[FLINK-15387] Expose missing RocksDB properties out via
RocksDBNativeMetricOptions
Posted by GitBox <gi...@apache.org>.
Myasuka commented on a change in pull request #10692: [FLINK-15387] Expose missing RocksDB properties out via RocksDBNativeMetricOptions
URL: https://github.com/apache/flink/pull/10692#discussion_r361404301
##########
File path: flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBNativeMetricOptions.java
##########
@@ -153,6 +153,30 @@
.defaultValue(false)
.withDescription("Monitor the current actual delayed write rate. 0 means no delay.");
+ public static final ConfigOption<Boolean> IS_WRITE_STOPPED = ConfigOptions
+ .key(RocksDBProperty.IsWriteStopped.getConfigKey())
+ .booleanType()
+ .defaultValue(false)
+ .withDescription("Monitor whether write has been stopped. 1 means that has been stopped.");
Review comment:
This would return a numeric value, `1` means write has been stopped. I would explain this in detail to not mislead users.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10692: [FLINK-15387]
Expose missing RocksDB properties out via RocksDBNativeMetricOptions
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10692: [FLINK-15387] Expose missing RocksDB properties out via RocksDBNativeMetricOptions
URL: https://github.com/apache/flink/pull/10692#issuecomment-568924184
<!--
Meta data
Hash:cf3539fdec7d4ff9ad218545f3544b6cea3a2e24 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3917 TriggerType:PUSH TriggerID:cf3539fdec7d4ff9ad218545f3544b6cea3a2e24
Hash:cf3539fdec7d4ff9ad218545f3544b6cea3a2e24 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142331359 TriggerType:PUSH TriggerID:cf3539fdec7d4ff9ad218545f3544b6cea3a2e24
Hash:c81d7ac0c294a6e05056ea11c15d645541f87f86 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/142967001 TriggerType:PUSH TriggerID:c81d7ac0c294a6e05056ea11c15d645541f87f86
Hash:c81d7ac0c294a6e05056ea11c15d645541f87f86 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4066 TriggerType:PUSH TriggerID:c81d7ac0c294a6e05056ea11c15d645541f87f86
-->
## CI report:
* cf3539fdec7d4ff9ad218545f3544b6cea3a2e24 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142331359) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3917)
* c81d7ac0c294a6e05056ea11c15d645541f87f86 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/142967001) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4066)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10692: [FLINK-15387] Expose
missing RocksDB properties out via RocksDBNativeMetricOptions
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10692: [FLINK-15387] Expose missing RocksDB properties out via RocksDBNativeMetricOptions
URL: https://github.com/apache/flink/pull/10692#issuecomment-568924184
<!--
Meta data
Hash:cf3539fdec7d4ff9ad218545f3544b6cea3a2e24 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:cf3539fdec7d4ff9ad218545f3544b6cea3a2e24
-->
## CI report:
* cf3539fdec7d4ff9ad218545f3544b6cea3a2e24 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10692: [FLINK-15387]
Expose missing RocksDB properties out via RocksDBNativeMetricOptions
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10692: [FLINK-15387] Expose missing RocksDB properties out via RocksDBNativeMetricOptions
URL: https://github.com/apache/flink/pull/10692#issuecomment-568924184
<!--
Meta data
Hash:cf3539fdec7d4ff9ad218545f3544b6cea3a2e24 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3917 TriggerType:PUSH TriggerID:cf3539fdec7d4ff9ad218545f3544b6cea3a2e24
Hash:cf3539fdec7d4ff9ad218545f3544b6cea3a2e24 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142331359 TriggerType:PUSH TriggerID:cf3539fdec7d4ff9ad218545f3544b6cea3a2e24
Hash:c81d7ac0c294a6e05056ea11c15d645541f87f86 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142967001 TriggerType:PUSH TriggerID:c81d7ac0c294a6e05056ea11c15d645541f87f86
Hash:c81d7ac0c294a6e05056ea11c15d645541f87f86 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4066 TriggerType:PUSH TriggerID:c81d7ac0c294a6e05056ea11c15d645541f87f86
-->
## CI report:
* cf3539fdec7d4ff9ad218545f3544b6cea3a2e24 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142331359) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3917)
* c81d7ac0c294a6e05056ea11c15d645541f87f86 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142967001) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4066)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] Myasuka commented on a change in pull request #10692:
[FLINK-15387] Expose missing RocksDB properties out via
RocksDBNativeMetricOptions
Posted by GitBox <gi...@apache.org>.
Myasuka commented on a change in pull request #10692: [FLINK-15387] Expose missing RocksDB properties out via RocksDBNativeMetricOptions
URL: https://github.com/apache/flink/pull/10692#discussion_r362882872
##########
File path: flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBNativeMetricOptions.java
##########
@@ -153,6 +153,30 @@
.defaultValue(false)
.withDescription("Monitor the current actual delayed write rate. 0 means no delay.");
+ public static final ConfigOption<Boolean> IS_WRITE_STOPPED = ConfigOptions
+ .key(RocksDBProperty.IsWriteStopped.getConfigKey())
+ .booleanType()
+ .defaultValue(false)
+ .withDescription("Track whether write has been stopped in RocksDB. Returns 1 if write has been stopped, 0 otherwise.");
Review comment:
I think a brief explanation would be helpful for users.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10692: [FLINK-15387]
Expose missing RocksDB properties out via RocksDBNativeMetricOptions
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10692: [FLINK-15387] Expose missing RocksDB properties out via RocksDBNativeMetricOptions
URL: https://github.com/apache/flink/pull/10692#issuecomment-568924184
<!--
Meta data
Hash:cf3539fdec7d4ff9ad218545f3544b6cea3a2e24 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3917 TriggerType:PUSH TriggerID:cf3539fdec7d4ff9ad218545f3544b6cea3a2e24
Hash:cf3539fdec7d4ff9ad218545f3544b6cea3a2e24 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142331359 TriggerType:PUSH TriggerID:cf3539fdec7d4ff9ad218545f3544b6cea3a2e24
-->
## CI report:
* cf3539fdec7d4ff9ad218545f3544b6cea3a2e24 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142331359) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3917)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] Myasuka commented on a change in pull request #10692:
[FLINK-15387] Expose missing RocksDB properties out via
RocksDBNativeMetricOptions
Posted by GitBox <gi...@apache.org>.
Myasuka commented on a change in pull request #10692: [FLINK-15387] Expose missing RocksDB properties out via RocksDBNativeMetricOptions
URL: https://github.com/apache/flink/pull/10692#discussion_r361406934
##########
File path: flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBNativeMetricOptions.java
##########
@@ -153,6 +153,30 @@
.defaultValue(false)
.withDescription("Monitor the current actual delayed write rate. 0 means no delay.");
+ public static final ConfigOption<Boolean> IS_WRITE_STOPPED = ConfigOptions
+ .key(RocksDBProperty.IsWriteStopped.getConfigKey())
+ .booleanType()
+ .defaultValue(false)
+ .withDescription("Monitor whether write has been stopped. 1 means that has been stopped.");
Review comment:
You could refer to above `MONITOR_ACTUAL_DELAYED_WRITE_RATE` , `0` means no delay. Similarity, `MONITOR_ACTUAL_DELAYED_WRITE_RATE`, `1` means write has been stopped.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] Myasuka commented on a change in pull request #10692:
[FLINK-15387] Expose missing RocksDB properties out via
RocksDBNativeMetricOptions
Posted by GitBox <gi...@apache.org>.
Myasuka commented on a change in pull request #10692: [FLINK-15387] Expose missing RocksDB properties out via RocksDBNativeMetricOptions
URL: https://github.com/apache/flink/pull/10692#discussion_r364313066
##########
File path: flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBNativeMetricOptions.java
##########
@@ -153,6 +153,30 @@
.defaultValue(false)
.withDescription("Monitor the current actual delayed write rate. 0 means no delay.");
+ public static final ConfigOption<Boolean> IS_WRITE_STOPPED = ConfigOptions
+ .key(RocksDBProperty.IsWriteStopped.getConfigKey())
+ .booleanType()
+ .defaultValue(false)
+ .withDescription("Track whether write has been stopped in RocksDB. Returns 1 if write has been stopped, 0 otherwise.");
Review comment:
@zentol What's your thought of my reply and consider to take a look at this PR again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10692: [FLINK-15387]
Expose missing RocksDB properties out via RocksDBNativeMetricOptions
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10692: [FLINK-15387] Expose missing RocksDB properties out via RocksDBNativeMetricOptions
URL: https://github.com/apache/flink/pull/10692#issuecomment-568924184
<!--
Meta data
Hash:cf3539fdec7d4ff9ad218545f3544b6cea3a2e24 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3917 TriggerType:PUSH TriggerID:cf3539fdec7d4ff9ad218545f3544b6cea3a2e24
Hash:cf3539fdec7d4ff9ad218545f3544b6cea3a2e24 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/142331359 TriggerType:PUSH TriggerID:cf3539fdec7d4ff9ad218545f3544b6cea3a2e24
-->
## CI report:
* cf3539fdec7d4ff9ad218545f3544b6cea3a2e24 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/142331359) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3917)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10692: [FLINK-15387]
Expose missing RocksDB properties out via RocksDBNativeMetricOptions
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10692: [FLINK-15387] Expose missing RocksDB properties out via RocksDBNativeMetricOptions
URL: https://github.com/apache/flink/pull/10692#issuecomment-568924184
<!--
Meta data
Hash:cf3539fdec7d4ff9ad218545f3544b6cea3a2e24 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3917 TriggerType:PUSH TriggerID:cf3539fdec7d4ff9ad218545f3544b6cea3a2e24
Hash:cf3539fdec7d4ff9ad218545f3544b6cea3a2e24 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142331359 TriggerType:PUSH TriggerID:cf3539fdec7d4ff9ad218545f3544b6cea3a2e24
Hash:c81d7ac0c294a6e05056ea11c15d645541f87f86 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142967001 TriggerType:PUSH TriggerID:c81d7ac0c294a6e05056ea11c15d645541f87f86
Hash:c81d7ac0c294a6e05056ea11c15d645541f87f86 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4066 TriggerType:PUSH TriggerID:c81d7ac0c294a6e05056ea11c15d645541f87f86
Hash:032c103cc3737323789f835c3b78244dba2e3561 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4086 TriggerType:PUSH TriggerID:032c103cc3737323789f835c3b78244dba2e3561
Hash:032c103cc3737323789f835c3b78244dba2e3561 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143027591 TriggerType:PUSH TriggerID:032c103cc3737323789f835c3b78244dba2e3561
-->
## CI report:
* cf3539fdec7d4ff9ad218545f3544b6cea3a2e24 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142331359) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3917)
* c81d7ac0c294a6e05056ea11c15d645541f87f86 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142967001) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4066)
* 032c103cc3737323789f835c3b78244dba2e3561 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143027591) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4086)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10692: [FLINK-15387]
Expose missing RocksDB properties out via RocksDBNativeMetricOptions
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10692: [FLINK-15387] Expose missing RocksDB properties out via RocksDBNativeMetricOptions
URL: https://github.com/apache/flink/pull/10692#issuecomment-568924184
<!--
Meta data
Hash:cf3539fdec7d4ff9ad218545f3544b6cea3a2e24 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3917 TriggerType:PUSH TriggerID:cf3539fdec7d4ff9ad218545f3544b6cea3a2e24
Hash:cf3539fdec7d4ff9ad218545f3544b6cea3a2e24 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142331359 TriggerType:PUSH TriggerID:cf3539fdec7d4ff9ad218545f3544b6cea3a2e24
Hash:c81d7ac0c294a6e05056ea11c15d645541f87f86 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/142967001 TriggerType:PUSH TriggerID:c81d7ac0c294a6e05056ea11c15d645541f87f86
Hash:c81d7ac0c294a6e05056ea11c15d645541f87f86 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4066 TriggerType:PUSH TriggerID:c81d7ac0c294a6e05056ea11c15d645541f87f86
-->
## CI report:
* cf3539fdec7d4ff9ad218545f3544b6cea3a2e24 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142331359) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3917)
* c81d7ac0c294a6e05056ea11c15d645541f87f86 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/142967001) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4066)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] Myasuka commented on issue #10692: [FLINK-15387] Expose
missing RocksDB properties out via RocksDBNativeMetricOptions
Posted by GitBox <gi...@apache.org>.
Myasuka commented on issue #10692: [FLINK-15387] Expose missing RocksDB properties out via RocksDBNativeMetricOptions
URL: https://github.com/apache/flink/pull/10692#issuecomment-572901410
My [travis CI](https://travis-ci.org/Myasuka/flink/builds/632364243) on local branch passed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] carp84 merged pull request #10692: [FLINK-15387] Expose
missing RocksDB properties out via RocksDBNativeMetricOptions
Posted by GitBox <gi...@apache.org>.
carp84 merged pull request #10692: [FLINK-15387] Expose missing RocksDB properties out via RocksDBNativeMetricOptions
URL: https://github.com/apache/flink/pull/10692
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10692: [FLINK-15387]
Expose missing RocksDB properties out via RocksDBNativeMetricOptions
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10692: [FLINK-15387] Expose missing RocksDB properties out via RocksDBNativeMetricOptions
URL: https://github.com/apache/flink/pull/10692#issuecomment-568924184
<!--
Meta data
Hash:cf3539fdec7d4ff9ad218545f3544b6cea3a2e24 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3917 TriggerType:PUSH TriggerID:cf3539fdec7d4ff9ad218545f3544b6cea3a2e24
Hash:cf3539fdec7d4ff9ad218545f3544b6cea3a2e24 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142331359 TriggerType:PUSH TriggerID:cf3539fdec7d4ff9ad218545f3544b6cea3a2e24
Hash:c81d7ac0c294a6e05056ea11c15d645541f87f86 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142967001 TriggerType:PUSH TriggerID:c81d7ac0c294a6e05056ea11c15d645541f87f86
Hash:c81d7ac0c294a6e05056ea11c15d645541f87f86 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4066 TriggerType:PUSH TriggerID:c81d7ac0c294a6e05056ea11c15d645541f87f86
Hash:032c103cc3737323789f835c3b78244dba2e3561 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4086 TriggerType:PUSH TriggerID:032c103cc3737323789f835c3b78244dba2e3561
Hash:032c103cc3737323789f835c3b78244dba2e3561 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143027591 TriggerType:PUSH TriggerID:032c103cc3737323789f835c3b78244dba2e3561
-->
## CI report:
* cf3539fdec7d4ff9ad218545f3544b6cea3a2e24 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142331359) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3917)
* c81d7ac0c294a6e05056ea11c15d645541f87f86 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142967001) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4066)
* 032c103cc3737323789f835c3b78244dba2e3561 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143027591) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4086)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] Myasuka commented on a change in pull request #10692:
[FLINK-15387] Expose missing RocksDB properties out via
RocksDBNativeMetricOptions
Posted by GitBox <gi...@apache.org>.
Myasuka commented on a change in pull request #10692: [FLINK-15387] Expose missing RocksDB properties out via RocksDBNativeMetricOptions
URL: https://github.com/apache/flink/pull/10692#discussion_r361404301
##########
File path: flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBNativeMetricOptions.java
##########
@@ -153,6 +153,30 @@
.defaultValue(false)
.withDescription("Monitor the current actual delayed write rate. 0 means no delay.");
+ public static final ConfigOption<Boolean> IS_WRITE_STOPPED = ConfigOptions
+ .key(RocksDBProperty.IsWriteStopped.getConfigKey())
+ .booleanType()
+ .defaultValue(false)
+ .withDescription("Monitor whether write has been stopped. 1 means that has been stopped.");
Review comment:
This would return a numeric value, `1` means write has been stopped. I would explain this in detail to not mislead users.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] klion26 commented on a change in pull request #10692:
[FLINK-15387] Expose missing RocksDB properties out via
RocksDBNativeMetricOptions
Posted by GitBox <gi...@apache.org>.
klion26 commented on a change in pull request #10692: [FLINK-15387] Expose missing RocksDB properties out via RocksDBNativeMetricOptions
URL: https://github.com/apache/flink/pull/10692#discussion_r361387931
##########
File path: flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBNativeMetricOptions.java
##########
@@ -153,6 +153,30 @@
.defaultValue(false)
.withDescription("Monitor the current actual delayed write rate. 0 means no delay.");
+ public static final ConfigOption<Boolean> IS_WRITE_STOPPED = ConfigOptions
+ .key(RocksDBProperty.IsWriteStopped.getConfigKey())
+ .booleanType()
+ .defaultValue(false)
+ .withDescription("Monitor whether write has been stopped. 1 means that has been stopped.");
Review comment:
`true` means that has been stopped.?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10692: [FLINK-15387]
Expose missing RocksDB properties out via RocksDBNativeMetricOptions
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10692: [FLINK-15387] Expose missing RocksDB properties out via RocksDBNativeMetricOptions
URL: https://github.com/apache/flink/pull/10692#issuecomment-568924184
<!--
Meta data
Hash:cf3539fdec7d4ff9ad218545f3544b6cea3a2e24 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3917 TriggerType:PUSH TriggerID:cf3539fdec7d4ff9ad218545f3544b6cea3a2e24
Hash:cf3539fdec7d4ff9ad218545f3544b6cea3a2e24 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142331359 TriggerType:PUSH TriggerID:cf3539fdec7d4ff9ad218545f3544b6cea3a2e24
Hash:c81d7ac0c294a6e05056ea11c15d645541f87f86 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:c81d7ac0c294a6e05056ea11c15d645541f87f86
-->
## CI report:
* cf3539fdec7d4ff9ad218545f3544b6cea3a2e24 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142331359) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3917)
* c81d7ac0c294a6e05056ea11c15d645541f87f86 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] carp84 commented on issue #10692: [FLINK-15387] Expose
missing RocksDB properties out via RocksDBNativeMetricOptions
Posted by GitBox <gi...@apache.org>.
carp84 commented on issue #10692: [FLINK-15387] Expose missing RocksDB properties out via RocksDBNativeMetricOptions
URL: https://github.com/apache/flink/pull/10692#issuecomment-570576087
Please regenerate the document and include the update in the commit @Myasuka , now the travis build fails due to doc outdated: https://api.travis-ci.com/v3/job/272040846/log.txt
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] carp84 commented on a change in pull request #10692:
[FLINK-15387] Expose missing RocksDB properties out via
RocksDBNativeMetricOptions
Posted by GitBox <gi...@apache.org>.
carp84 commented on a change in pull request #10692: [FLINK-15387] Expose missing RocksDB properties out via RocksDBNativeMetricOptions
URL: https://github.com/apache/flink/pull/10692#discussion_r362699520
##########
File path: flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBNativeMetricOptions.java
##########
@@ -153,6 +153,30 @@
.defaultValue(false)
.withDescription("Monitor the current actual delayed write rate. 0 means no delay.");
+ public static final ConfigOption<Boolean> IS_WRITE_STOPPED = ConfigOptions
+ .key(RocksDBProperty.IsWriteStopped.getConfigKey())
+ .booleanType()
+ .defaultValue(false)
+ .withDescription("Monitor whether write has been stopped. 1 means that has been stopped.");
Review comment:
Suggest to follow the same description pattern as `CompactionPending`:
"Track whether write has been stopped in RocksDB. Returns 1 if write has been stopped, 0 otherwise."
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10692: [FLINK-15387] Expose
missing RocksDB properties out via RocksDBNativeMetricOptions
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10692: [FLINK-15387] Expose missing RocksDB properties out via RocksDBNativeMetricOptions
URL: https://github.com/apache/flink/pull/10692#issuecomment-568921824
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit cf3539fdec7d4ff9ad218545f3544b6cea3a2e24 (Wed Dec 25 18:45:20 UTC 2019)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-15387).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] carp84 commented on issue #10692: [FLINK-15387] Expose
missing RocksDB properties out via RocksDBNativeMetricOptions
Posted by GitBox <gi...@apache.org>.
carp84 commented on issue #10692: [FLINK-15387] Expose missing RocksDB properties out via RocksDBNativeMetricOptions
URL: https://github.com/apache/flink/pull/10692#issuecomment-572901502
Checked and confirmed the travis failure is due to FLINK-15247 and irrelative to the changes here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] carp84 edited a comment on issue #10692: [FLINK-15387]
Expose missing RocksDB properties out via RocksDBNativeMetricOptions
Posted by GitBox <gi...@apache.org>.
carp84 edited a comment on issue #10692: [FLINK-15387] Expose missing RocksDB properties out via RocksDBNativeMetricOptions
URL: https://github.com/apache/flink/pull/10692#issuecomment-570576087
> 10:23:18.074 [ERROR] Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.325 s <<< FAILURE! - in org.apache.flink.docs.configuration.ConfigOptionsDocsCompletenessITCase
> 10:23:18.074 [ERROR] testFullReferenceCompleteness(org.apache.flink.docs.configuration.ConfigOptionsDocsCompletenessITCase) Time elapsed: 0.265 s <<< FAILURE!
> java.lang.AssertionError:
> Documentation is outdated, please regenerate it according to the instructions in flink-docs/README.md.
> Problems:
> Documented description of state.backend.rocksdb.metrics.is-write-stopped in class org.apache.flink.contrib.streaming.state.RocksDBNativeMetricOptions is outdated.
> at org.apache.flink.docs.configuration.ConfigOptionsDocsCompletenessITCase.compareDocumentedAndExistingOptions(ConfigOptionsDocsCompletenessITCase.java:120)
> at org.apache.flink.docs.configuration.ConfigOptionsDocsCompletenessITCase.testFullReferenceCompleteness(ConfigOptionsDocsCompletenessITCase.java:78)
Please regenerate the document and include the update in the commit @Myasuka , now the travis build fails due to doc outdated: https://api.travis-ci.com/v3/job/272040846/log.txt
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10692: [FLINK-15387]
Expose missing RocksDB properties out via RocksDBNativeMetricOptions
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10692: [FLINK-15387] Expose missing RocksDB properties out via RocksDBNativeMetricOptions
URL: https://github.com/apache/flink/pull/10692#issuecomment-568924184
<!--
Meta data
Hash:cf3539fdec7d4ff9ad218545f3544b6cea3a2e24 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3917 TriggerType:PUSH TriggerID:cf3539fdec7d4ff9ad218545f3544b6cea3a2e24
Hash:cf3539fdec7d4ff9ad218545f3544b6cea3a2e24 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142331359 TriggerType:PUSH TriggerID:cf3539fdec7d4ff9ad218545f3544b6cea3a2e24
-->
## CI report:
* cf3539fdec7d4ff9ad218545f3544b6cea3a2e24 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142331359) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3917)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] Myasuka commented on a change in pull request #10692:
[FLINK-15387] Expose missing RocksDB properties out via
RocksDBNativeMetricOptions
Posted by GitBox <gi...@apache.org>.
Myasuka commented on a change in pull request #10692: [FLINK-15387] Expose missing RocksDB properties out via RocksDBNativeMetricOptions
URL: https://github.com/apache/flink/pull/10692#discussion_r364313066
##########
File path: flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBNativeMetricOptions.java
##########
@@ -153,6 +153,30 @@
.defaultValue(false)
.withDescription("Monitor the current actual delayed write rate. 0 means no delay.");
+ public static final ConfigOption<Boolean> IS_WRITE_STOPPED = ConfigOptions
+ .key(RocksDBProperty.IsWriteStopped.getConfigKey())
+ .booleanType()
+ .defaultValue(false)
+ .withDescription("Track whether write has been stopped in RocksDB. Returns 1 if write has been stopped, 0 otherwise.");
Review comment:
@zentol What's your thought of my reply and hope you could take a look at this PR again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10692: [FLINK-15387]
Expose missing RocksDB properties out via RocksDBNativeMetricOptions
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10692: [FLINK-15387] Expose missing RocksDB properties out via RocksDBNativeMetricOptions
URL: https://github.com/apache/flink/pull/10692#issuecomment-568924184
<!--
Meta data
Hash:cf3539fdec7d4ff9ad218545f3544b6cea3a2e24 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3917 TriggerType:PUSH TriggerID:cf3539fdec7d4ff9ad218545f3544b6cea3a2e24
Hash:cf3539fdec7d4ff9ad218545f3544b6cea3a2e24 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142331359 TriggerType:PUSH TriggerID:cf3539fdec7d4ff9ad218545f3544b6cea3a2e24
Hash:c81d7ac0c294a6e05056ea11c15d645541f87f86 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142967001 TriggerType:PUSH TriggerID:c81d7ac0c294a6e05056ea11c15d645541f87f86
Hash:c81d7ac0c294a6e05056ea11c15d645541f87f86 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4066 TriggerType:PUSH TriggerID:c81d7ac0c294a6e05056ea11c15d645541f87f86
Hash:032c103cc3737323789f835c3b78244dba2e3561 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4086 TriggerType:PUSH TriggerID:032c103cc3737323789f835c3b78244dba2e3561
Hash:032c103cc3737323789f835c3b78244dba2e3561 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/143027591 TriggerType:PUSH TriggerID:032c103cc3737323789f835c3b78244dba2e3561
-->
## CI report:
* cf3539fdec7d4ff9ad218545f3544b6cea3a2e24 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142331359) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3917)
* c81d7ac0c294a6e05056ea11c15d645541f87f86 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142967001) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4066)
* 032c103cc3737323789f835c3b78244dba2e3561 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/143027591) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4086)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] carp84 commented on a change in pull request #10692:
[FLINK-15387] Expose missing RocksDB properties out via
RocksDBNativeMetricOptions
Posted by GitBox <gi...@apache.org>.
carp84 commented on a change in pull request #10692: [FLINK-15387] Expose missing RocksDB properties out via RocksDBNativeMetricOptions
URL: https://github.com/apache/flink/pull/10692#discussion_r362846562
##########
File path: flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBNativeMetricOptions.java
##########
@@ -153,6 +153,30 @@
.defaultValue(false)
.withDescription("Monitor the current actual delayed write rate. 0 means no delay.");
+ public static final ConfigOption<Boolean> IS_WRITE_STOPPED = ConfigOptions
+ .key(RocksDBProperty.IsWriteStopped.getConfigKey())
+ .booleanType()
+ .defaultValue(false)
+ .withDescription("Track whether write has been stopped in RocksDB. Returns 1 if write has been stopped, 0 otherwise.");
Review comment:
IMO it could help understand the data of this metrics and how to monitor/read it, following the same pattern as [RocksDBProperty.CompactionPending](https://github.com/apache/flink/blob/65853b375abd1e6b3d2b9c7734d7f93aa5d529a0/flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBNativeMetricOptions.java#L57)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10692: [FLINK-15387]
Expose missing RocksDB properties out via RocksDBNativeMetricOptions
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10692: [FLINK-15387] Expose missing RocksDB properties out via RocksDBNativeMetricOptions
URL: https://github.com/apache/flink/pull/10692#issuecomment-568924184
<!--
Meta data
Hash:cf3539fdec7d4ff9ad218545f3544b6cea3a2e24 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3917 TriggerType:PUSH TriggerID:cf3539fdec7d4ff9ad218545f3544b6cea3a2e24
Hash:cf3539fdec7d4ff9ad218545f3544b6cea3a2e24 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142331359 TriggerType:PUSH TriggerID:cf3539fdec7d4ff9ad218545f3544b6cea3a2e24
Hash:c81d7ac0c294a6e05056ea11c15d645541f87f86 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142967001 TriggerType:PUSH TriggerID:c81d7ac0c294a6e05056ea11c15d645541f87f86
Hash:c81d7ac0c294a6e05056ea11c15d645541f87f86 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4066 TriggerType:PUSH TriggerID:c81d7ac0c294a6e05056ea11c15d645541f87f86
Hash:032c103cc3737323789f835c3b78244dba2e3561 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:032c103cc3737323789f835c3b78244dba2e3561
-->
## CI report:
* cf3539fdec7d4ff9ad218545f3544b6cea3a2e24 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142331359) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3917)
* c81d7ac0c294a6e05056ea11c15d645541f87f86 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142967001) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4066)
* 032c103cc3737323789f835c3b78244dba2e3561 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol commented on a change in pull request #10692:
[FLINK-15387] Expose missing RocksDB properties out via
RocksDBNativeMetricOptions
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #10692: [FLINK-15387] Expose missing RocksDB properties out via RocksDBNativeMetricOptions
URL: https://github.com/apache/flink/pull/10692#discussion_r362818445
##########
File path: flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBNativeMetricOptions.java
##########
@@ -153,6 +153,30 @@
.defaultValue(false)
.withDescription("Monitor the current actual delayed write rate. 0 means no delay.");
+ public static final ConfigOption<Boolean> IS_WRITE_STOPPED = ConfigOptions
+ .key(RocksDBProperty.IsWriteStopped.getConfigKey())
+ .booleanType()
+ .defaultValue(false)
+ .withDescription("Track whether write has been stopped in RocksDB. Returns 1 if write has been stopped, 0 otherwise.");
Review comment:
Isn't the return value a RocksDB detail? Why are we documenting that?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services