[GitHub] [cassandra] Maxwell-Guo commented on a diff in pull request #2123: Add cache type information for maximum memory usage warning message

["Maxwell-Guo (via GitHub)" <gi...@apache.org>]

Maxwell-Guo commented on code in PR #2123:
URL: https://github.com/apache/cassandra/pull/2123#discussion_r1092985329


##########
src/java/org/apache/cassandra/utils/memory/BufferPool.java:
##########
@@ -441,8 +441,8 @@ private Chunk allocateMoreChunks()
                 {
                     if (memoryUsageThreshold > 0)
                     {
-                        noSpamLogger.info("Maximum memory usage reached ({}), cannot allocate chunk of {}",
-                                          readableMemoryUsageThreshold, READABLE_MACRO_CHUNK_SIZE);
+                        noSpamLogger.info("Maximum memory usage reached ({}) for {}, cannot allocate chunk of {}",

Review Comment:
   see line 461 , may be " for {} buffer pool " is better and consistent with line 461‘s log message.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org