[jira] [Commented] (GEODE-4153) Examples place their packages under org.apache.geode

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-4153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16349415#comment-16349415 ] 

ASF subversion and git services commented on GEODE-4153:
--------------------------------------------------------

Commit 4bdf0c9733ccb9cdd41bb6a0c5a0c2d2c2618709 in geode-examples's branch refs/heads/master from [~PivotalSarge]
[ https://gitbox.apache.org/repos/asf?p=geode-examples.git;h=4bdf0c9 ]

GEODE-4153: Rename org.apache.geode.examples to org.apache.geode_examples.


> Examples place their packages under org.apache.geode
> ----------------------------------------------------
>
>                 Key: GEODE-4153
>                 URL: https://issues.apache.org/jira/browse/GEODE-4153
>             Project: Geode
>          Issue Type: Bug
>          Components: examples
>            Reporter: Michael Dodge
>            Assignee: Michael Dodge
>            Priority: Major
>             Fix For: 1.4.0
>
>
> By dint of following the convention from the ur-example, the various and sundry examples put their classes in packages that nest underneath org.apache.geode. Alas, not only does this imply that the classes are part of the geode repo instead of the geode-examples repo, this founders on the shoals of the Geode code which performs substring analysis of an object's class' package name when making decisions about whether that object is an internal piece of Geode.
> Hence, the packages for all of the Geode examples need to be modified. As per https://docs.oracle.com/javase/tutorial/java/package/namingpkgs.html the convention is to use the inverted domain name whilst replacing illegal characters (e.g., hyphens) with underscores. Thus, org.apache.geode should be replaced with org.apache.geode_examples.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)