You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/09/29 21:32:56 UTC

[GitHub] [cloudstack-primate] GabrielBrascher opened a new pull request #770: Add rootdisk size oncompute offering

GabrielBrascher opened a new pull request #770:
URL: https://github.com/apache/cloudstack-primate/pull/770


   ## Description
   
   This PR allows configuring a Service Offering with root disk size.
   PR [Allow to configure root disk size via Service Offering (disk offering of type Service). #4341](https://github.com/apache/cloudstack/pull/4341) allows enforcing VM Root disk size accordingly to its Service Offering.
   
   Once that PR gets merged, the code of this PR would then work.
   
   ## How Has This Been Tested?
   
   - Create Service offering via UI with rootdisk (CloudStack from commit https://github.com/apache/cloudstack/pull/4341/commits/4f501f0624a44fe2414835f17f210bf977f08846)
   - Assert that the offering has indeed the root disk size configured (same test as in https://github.com/apache/cloudstack/pull/4341)
   
   ## Screenshots:
   ![image](https://user-images.githubusercontent.com/5025148/94618083-f9814480-0280-11eb-97e9-216144df60b2.png)
   
   
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] rhtyd merged pull request #770: Add rootdisk size on compute offering

Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #770:
URL: https://github.com/apache/cloudstack-primate/pull/770


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] GabrielBrascher commented on a change in pull request #770: Add rootdisk size on compute offering

Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on a change in pull request #770:
URL: https://github.com/apache/cloudstack-primate/pull/770#discussion_r497385163



##########
File path: src/views/offering/AddComputeOffering.vue
##########
@@ -333,6 +333,28 @@
             }]"
             :placeholder="this.$t('label.networkrate')"/>
         </a-form-item>
+          <a-form-item>

Review comment:
       Thanks :-)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] GabrielBrascher commented on a change in pull request #770: Add rootdisk size on compute offering

Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on a change in pull request #770:
URL: https://github.com/apache/cloudstack-primate/pull/770#discussion_r497384753



##########
File path: src/views/offering/AddComputeOffering.vue
##########
@@ -333,6 +333,28 @@
             }]"
             :placeholder="this.$t('label.networkrate')"/>
         </a-form-item>
+          <a-form-item>
+            <span slot="label">
+              {{ $t('label.root.disk.size') }}
+              <a-tooltip :title="apiParams.provisioningtype.description">

Review comment:
       Thanks for the review @davidjumani, fixed.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] GabrielBrascher commented on pull request #770: Add rootdisk size oncompute offering

Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #770:
URL: https://github.com/apache/cloudstack-primate/pull/770#issuecomment-701017419


    @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #770: Add rootdisk size on compute offering

Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #770:
URL: https://github.com/apache/cloudstack-primate/pull/770#discussion_r497249468



##########
File path: src/views/offering/AddComputeOffering.vue
##########
@@ -333,6 +333,28 @@
             }]"
             :placeholder="this.$t('label.networkrate')"/>
         </a-form-item>
+          <a-form-item>

Review comment:
       ```suggestion
             <a-form-item v-if="apiParams.rootdisksize">
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #770: Add rootdisk size on compute offering

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #770:
URL: https://github.com/apache/cloudstack-primate/pull/770#issuecomment-701021557


   Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
   QA: http://primate-qa.cloudstack.cloud:8080/client/pr/770 (JID-3542)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] davidjumani commented on pull request #770: Add rootdisk size on compute offering

Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #770:
URL: https://github.com/apache/cloudstack-primate/pull/770#issuecomment-701287270


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #770: Add rootdisk size on compute offering

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #770:
URL: https://github.com/apache/cloudstack-primate/pull/770#issuecomment-701314539


   @rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #770: Add rootdisk size on compute offering

Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #770:
URL: https://github.com/apache/cloudstack-primate/pull/770#discussion_r497249468



##########
File path: src/views/offering/AddComputeOffering.vue
##########
@@ -333,6 +333,28 @@
             }]"
             :placeholder="this.$t('label.networkrate')"/>
         </a-form-item>
+          <a-form-item>

Review comment:
       ```suggestion
             <a-form-item v-if="apiParams.rootdisksize">
   ```
   For backward compatibility




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] rhtyd commented on pull request #770: Add rootdisk size on compute offering

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #770:
URL: https://github.com/apache/cloudstack-primate/pull/770#issuecomment-701314157


   @blueorangutan package
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #770: Add rootdisk size on compute offering

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #770:
URL: https://github.com/apache/cloudstack-primate/pull/770#issuecomment-701318272


   Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
   QA: http://primate-qa.cloudstack.cloud:8080/client/pr/770 (JID-3547)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #770: Add rootdisk size on compute offering

Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #770:
URL: https://github.com/apache/cloudstack-primate/pull/770#discussion_r497249590



##########
File path: src/views/offering/AddComputeOffering.vue
##########
@@ -333,6 +333,28 @@
             }]"
             :placeholder="this.$t('label.networkrate')"/>
         </a-form-item>
+          <a-form-item>
+            <span slot="label">
+              {{ $t('label.root.disk.size') }}
+              <a-tooltip :title="apiParams.provisioningtype.description">

Review comment:
       ```suggestion
                 <a-tooltip :title="apiParams.rootdisksize.description">
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #770: Add rootdisk size oncompute offering

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #770:
URL: https://github.com/apache/cloudstack-primate/pull/770#issuecomment-701017890


   @GabrielBrascher a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org