You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "rob@audenaerde.org (JIRA)" <ji...@apache.org> on 2010/08/27 16:18:59 UTC

[jira] Created: (WICKET-3018) CheckGroupSelector ignores disabled-state in Check

CheckGroupSelector ignores disabled-state in Check
--------------------------------------------------

                 Key: WICKET-3018
                 URL: https://issues.apache.org/jira/browse/WICKET-3018
             Project: Wicket
          Issue Type: Bug
          Components: wicket
    Affects Versions: 1.4.9
            Reporter: rob@audenaerde.org


I have a list with Checks, in a CheckGroup. Some of the Checks are disabled (gray in html). I also have a CheckGroupSelector. When clicking the CheckGroupSelector, the disabled Checks are also modified. I expect them to be left alone. 

The javascript in the CheckGroupSelector is IMHO incorrect:

it contains:

		for(var i=0;i<cb.length;i++) 
		{ 
			cb[i].checked=this.checked; 
		} 

and should be:

		for(var i=0;i<cb.length;i++) 
		{ 
			if (!cb[i].disabled)
			{
				cb[i].checked=this.checked; 
			}
		} 



-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (WICKET-3018) CheckGroupSelector ignores disabled-state in Check

Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-3018?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Igor Vaynberg resolved WICKET-3018.
-----------------------------------

         Assignee: Igor Vaynberg
    Fix Version/s: 1.4.11
                   1.5-M2
       Resolution: Fixed

> CheckGroupSelector ignores disabled-state in Check
> --------------------------------------------------
>
>                 Key: WICKET-3018
>                 URL: https://issues.apache.org/jira/browse/WICKET-3018
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.4.9
>            Reporter: rob@audenaerde.org
>            Assignee: Igor Vaynberg
>             Fix For: 1.4.11, 1.5-M2
>
>
> I have a list with Checks, in a CheckGroup. Some of the Checks are disabled (gray in html). I also have a CheckGroupSelector. When clicking the CheckGroupSelector, the disabled Checks are also modified. I expect them to be left alone. 
> The javascript in the CheckGroupSelector is IMHO incorrect:
> it contains:
> 		for(var i=0;i<cb.length;i++) 
> 		{ 
> 			cb[i].checked=this.checked; 
> 		} 
> and should be:
> 		for(var i=0;i<cb.length;i++) 
> 		{ 
> 			if (!cb[i].disabled)
> 			{
> 				cb[i].checked=this.checked; 
> 			}
> 		} 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-3018) CheckGroupSelector ignores disabled-state in Check

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-3018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12903861#action_12903861 ] 

Hudson commented on WICKET-3018:
--------------------------------

Integrated in Apache Wicket 1.4.x #129 (See [https://hudson.apache.org/hudson/job/Apache%20Wicket%201.4.x/129/])
    

> CheckGroupSelector ignores disabled-state in Check
> --------------------------------------------------
>
>                 Key: WICKET-3018
>                 URL: https://issues.apache.org/jira/browse/WICKET-3018
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.4.9
>            Reporter: rob@audenaerde.org
>            Assignee: Igor Vaynberg
>             Fix For: 1.4.11, 1.5-M2
>
>
> I have a list with Checks, in a CheckGroup. Some of the Checks are disabled (gray in html). I also have a CheckGroupSelector. When clicking the CheckGroupSelector, the disabled Checks are also modified. I expect them to be left alone. 
> The javascript in the CheckGroupSelector is IMHO incorrect:
> it contains:
> 		for(var i=0;i<cb.length;i++) 
> 		{ 
> 			cb[i].checked=this.checked; 
> 		} 
> and should be:
> 		for(var i=0;i<cb.length;i++) 
> 		{ 
> 			if (!cb[i].disabled)
> 			{
> 				cb[i].checked=this.checked; 
> 			}
> 		} 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.