You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@parquet.apache.org by GitBox <gi...@apache.org> on 2020/10/22 13:09:40 UTC

[GitHub] [parquet-mr] gszadovszky commented on a change in pull request #825: PARQUET-1922: Deprecate IOExceptionUtils

gszadovszky commented on a change in pull request #825:
URL: https://github.com/apache/parquet-mr/pull/825#discussion_r510146819



##########
File path: parquet-column/src/main/java/org/apache/parquet/column/values/plain/PlainValuesWriter.java
##########
@@ -127,7 +127,6 @@ public void reset() {
   @Override
   public void close() {
     arrayOut.close();
-    out.close();

Review comment:
       I would either close only `arrayOut` but with comments about what you have written here or close only `out` and catching the `IOException` that would never occur and comment in the catch block similarly. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org