You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@devlake.apache.org by "Adisorn-Watt (via GitHub)" <gi...@apache.org> on 2025/03/17 08:43:49 UTC
[I] [Bug][github_graphql] enableGraphql resets to false despite no value sent in GitHub connection update [incubator-devlake]
Adisorn-Watt opened a new issue, #8339:
URL: https://github.com/apache/incubator-devlake/issues/8339
### Search before asking
- [x] I had searched in the [issues](https://github.com/apache/incubator-devlake/issues?q=is%3Aissue) and found no similar issues.
### What happened
When editing a GitHub connection that `enableGraphql = true` via the config UI, and saving the changes (such as updating the token). Even though the config UI does not send any of `enableGraphql` value via the payload, the PATCH API response returns `enableGraphql` as `false`. Resulting in the inability to sync GitHub workflow/deployments data which is only available via GitHub Graphql plugin.
### What do you expect to happen
The `enableGraphql` value should remain its original value (`true`) after editing and saving the connection. It should not automatically change to `false`.
### How to reproduce
1. Select any GitHub connection with `enableGraphql = true` (verify via inspect GET connections API).
2. Edit the connection (e.g., change the token).
3. Save the changes.
4. Observe that the PATCH API response returns `enableGraphq`l as `false`.
### Anything else
No additional information
### Version
v1.0.1
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [x] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@devlake.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Bug][github_graphql] enableGraphql resets to false despite no value sent in GitHub connection update [incubator-devlake]
Posted by "klesh (via GitHub)" <gi...@apache.org>.
klesh commented on issue #8339:
URL: https://github.com/apache/incubator-devlake/issues/8339#issuecomment-2818037896
@kostas-petrakis Nice, looking forward to your PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Bug][github_graphql] enableGraphql resets to false despite no value sent in GitHub connection update [incubator-devlake]
Posted by "klesh (via GitHub)" <gi...@apache.org>.
klesh closed issue #8339: [Bug][github_graphql] enableGraphql resets to false despite no value sent in GitHub connection update
URL: https://github.com/apache/incubator-devlake/issues/8339
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Bug][github_graphql] enableGraphql resets to false despite no value sent in GitHub connection update [incubator-devlake]
Posted by "dosubot[bot] (via GitHub)" <gi...@apache.org>.
dosubot[bot] commented on issue #8339:
URL: https://github.com/apache/incubator-devlake/issues/8339#issuecomment-2728666477
<!-- Answer -->
The behavior you're experiencing with the `enableGraphql` field resetting to `false` despite using Classic personal access tokens is not directly addressed in the available documentation. It's possible that there might be a logic in the codebase that defaults the `enableGraphql` field to `false` under certain conditions, even when using Classic tokens. Unfortunately, I couldn't find specific details about this logic or any related issues in the repository. You might want to check the code handling the PATCH API request to see if there are any conditions or defaults affecting the `enableGraphql` field.
<!-- Dosu Comment Footer -->
*To continue talking to [Dosu](https://dosu.dev), mention @dosu.*
---
<sup>Help Dosu learn! Give it feedback: [Great Response](https://app.dosu.dev/response-feedback/d01a8d34-ac6c-4a97-95d8-f771ec13ca90?feedback_type=great_response) | [Irrelevant Answer](https://app.dosu.dev/response-feedback/d01a8d34-ac6c-4a97-95d8-f771ec13ca90?feedback_type=irrelevant_answer) | [Incorrect Sources](https://app.dosu.dev/response-feedback/d01a8d34-ac6c-4a97-95d8-f771ec13ca90?feedback_type=incorrect_sources) | [Too Verbose](https://app.dosu.dev/response-feedback/d01a8d34-ac6c-4a97-95d8-f771ec13ca90?feedback_type=too_verbose) | [Hallucination](https://app.dosu.dev/response-feedback/d01a8d34-ac6c-4a97-95d8-f771ec13ca90?feedback_type=hallucination) | [Bug Report](https://app.dosu.dev/response-feedback/d01a8d34-ac6c-4a97-95d8-f771ec13ca90?feedback_type=bug_report) | [Other](https://app.dosu.dev/response-feedback/d01a8d34-ac6c-4a97-95d8-f771ec13ca90?feedback_type=other)</sup>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Bug][github_graphql] enableGraphql resets to false despite no value sent in GitHub connection update [incubator-devlake]
Posted by "klesh (via GitHub)" <gi...@apache.org>.
klesh commented on issue #8339:
URL: https://github.com/apache/incubator-devlake/issues/8339#issuecomment-2811396261
> [@klesh](https://github.com/klesh) shouldn't then be enabled within the DB by default? `enable_graphql` is set to `0` in our DB
Good point, I agree.
Maybe one step further? Like getting rid of the option altogether.
Would you like to work on it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Bug][github_graphql] enableGraphql resets to false despite no value sent in GitHub connection update [incubator-devlake]
Posted by "Adisorn-Watt (via GitHub)" <gi...@apache.org>.
Adisorn-Watt commented on issue #8339:
URL: https://github.com/apache/incubator-devlake/issues/8339#issuecomment-2728655297
Hey @dosu, thanks for the answer. However, we are using Classic personal access tokens, therefore I don't think your answer can be applied to our situation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Bug][github_graphql] enableGraphql resets to false despite no value sent in GitHub connection update [incubator-devlake]
Posted by "kostas-petrakis (via GitHub)" <gi...@apache.org>.
kostas-petrakis commented on issue #8339:
URL: https://github.com/apache/incubator-devlake/issues/8339#issuecomment-2811941305
@klesh I will try to pick this up, will create a separate issue. 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Bug][github_graphql] enableGraphql resets to false despite no value sent in GitHub connection update [incubator-devlake]
Posted by "kostas-petrakis (via GitHub)" <gi...@apache.org>.
kostas-petrakis commented on issue #8339:
URL: https://github.com/apache/incubator-devlake/issues/8339#issuecomment-2809110743
@klesh shouldn't then be enabled within the DB by default? `enable_graphql` is set to `0` in our DB
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Bug][github_graphql] enableGraphql resets to false despite no value sent in GitHub connection update [incubator-devlake]
Posted by "dosubot[bot] (via GitHub)" <gi...@apache.org>.
dosubot[bot] commented on issue #8339:
URL: https://github.com/apache/incubator-devlake/issues/8339#issuecomment-2728608343
<!-- Greeting -->
Hey @Adisorn-Watt! I'm here to help you with any bugs, questions, or contributions you have in mind. Let's tackle this together!
<!-- Answer -->
The `enableGraphql` field resets to `false` in the PATCH API response because fine-grained personal access tokens do not support GraphQL APIs. The documentation specifies that you must disable `Use GraphQL APIs` on the connection page if you are using a fine-grained personal access token. This requirement likely causes the system to automatically reset `enableGraphql` to `false` when such a token is detected, even if no value for `enableGraphql` is sent in the request. Additionally, using fine-grained PATs without GraphQL will significantly increase the data collection time, which is an important consideration when configuring your connection <sup>[[1]](https://github.com/apache/incubator-devlake-website/blob/main/versioned_docs/version-v0.15/UserManuals/ConfigUI/GitHub.md)</sup><sup>[[2]](https://github.com/apache/incubator-devlake-website/blob/main/docs/Configuration/GitHub.md)</sup>.
<!-- Dosu Comment Footer -->
*To continue talking to [Dosu](https://dosu.dev), mention @dosu.*
---
<sup>Help Dosu learn! Give it feedback: [Great Response](https://app.dosu.dev/response-feedback/faf85f02-3201-47ae-b542-13f942a44811?feedback_type=great_response) | [Irrelevant Answer](https://app.dosu.dev/response-feedback/faf85f02-3201-47ae-b542-13f942a44811?feedback_type=irrelevant_answer) | [Incorrect Sources](https://app.dosu.dev/response-feedback/faf85f02-3201-47ae-b542-13f942a44811?feedback_type=incorrect_sources) | [Too Verbose](https://app.dosu.dev/response-feedback/faf85f02-3201-47ae-b542-13f942a44811?feedback_type=too_verbose) | [Hallucination](https://app.dosu.dev/response-feedback/faf85f02-3201-47ae-b542-13f942a44811?feedback_type=hallucination) | [Bug Report](https://app.dosu.dev/response-feedback/faf85f02-3201-47ae-b542-13f942a44811?feedback_type=bug_report) | [Other](https://app.dosu.dev/response-feedback/faf85f02-3201-47ae-b542-13f942a44811?feedback_type=other)</sup>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Bug][github_graphql] enableGraphql resets to false despite no value sent in GitHub connection update [incubator-devlake]
Posted by "kostas-petrakis (via GitHub)" <gi...@apache.org>.
kostas-petrakis commented on issue #8339:
URL: https://github.com/apache/incubator-devlake/issues/8339#issuecomment-2789019719
Coming here as it seems on the `1.0.2-beta4` the GraphQL option is completely gone from the UI, I can see the `enable_graphql` column in the DB set to `0`
Screenshot from the popup adding a new GitHub connection (same applies for my existing connection)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Bug][github_graphql] enableGraphql resets to false despite no value sent in GitHub connection update [incubator-devlake]
Posted by "klesh (via GitHub)" <gi...@apache.org>.
klesh commented on issue #8339:
URL: https://github.com/apache/incubator-devlake/issues/8339#issuecomment-2804040420
> Coming here as it seems on the `1.0.2-beta4` the GraphQL option is completely gone from the UI, I can see the `enable_graphql` column in the DB set to `0`
>
> Screenshot from the popup adding a new GitHub connection (same applies for my existing connection)
>
> 
Yes, it is intended. GraphQL option can not be disabled since then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Bug][github_graphql] enableGraphql resets to false despite no value sent in GitHub connection update [incubator-devlake]
Posted by "klesh (via GitHub)" <gi...@apache.org>.
klesh commented on issue #8339:
URL: https://github.com/apache/incubator-devlake/issues/8339#issuecomment-2735110574
Thanks for reporting the issue, will look into it soon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org