You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by dkuppitz <gi...@git.apache.org> on 2016/09/16 16:24:49 UTC
[GitHub] tinkerpop pull request #425: Fixed behavior of has() methods
GitHub user dkuppitz opened a pull request:
https://github.com/apache/tinkerpop/pull/425
Fixed behavior of has() methods
Made `has[Id|Label|Key|Value]` compatible with the old varargs method signature and added tests to ensure the compatibility.
VOTE: +1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop hasVarargs
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/425.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #425
----
commit 5cd2bcaff3892a06673f7b0b6db2d45649793700
Author: Daniel Kuppitz <da...@hotmail.com>
Date: 2016-09-16T16:06:08Z
Made `has[Id|Label|Key|Value]` compatible with the old varargs method signature and added tests to ensure the compatibility.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #425: Fixed behavior of has() methods
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/425
good: "all `has()` method overloads behave like before"
All tests pass with `docker/build.sh -t -n -i`
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop pull request #425: Fixed behavior of has() methods
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tinkerpop/pull/425
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #425: Fixed behavior of has() methods
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/425
Please adapt your "INFO" email to dev into the Upgrade Docs. I think it's important to explain the history of what happened here for 3.2.3 as we missed the change for the Upgrade Docs in 3.2.2.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #425: Fixed behavior of has() methods
Posted by PommeVerte <gi...@git.apache.org>.
Github user PommeVerte commented on the issue:
https://github.com/apache/tinkerpop/pull/425
Docs were clear, change is straightforward and tested this manually:
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---