You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Pallavi Rao <pa...@inmobi.com> on 2015/12/04 10:38:01 UTC

Review Request 40960: FALCON-1568 Process Instances are not getting scheduled in Falcon Native Scheduler

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40960/
-----------------------------------------------------------

Review request for Falcon.


Bugs: FALCON-1568
    https://issues.apache.org/jira/browse/FALCON-1568


Repository: falcon-git


Description
-------

Converted the listeners list to set and added a synchronized block.


Diffs
-----

  scheduler/src/main/java/org/apache/falcon/execution/ProcessExecutionInstance.java cff4a73 
  scheduler/src/main/java/org/apache/falcon/notification/service/impl/JobCompletionService.java 501c6aa 

Diff: https://reviews.apache.org/r/40960/diff/


Testing
-------

Ensured existing UTs passed. Manual testing done.


Thanks,

Pallavi Rao


Re: Review Request 40960: FALCON-1568 Process Instances are not getting scheduled in Falcon Native Scheduler

Posted by pavan kumar kolamuri <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40960/#review108962
-----------------------------------------------------------

Ship it!


Ship It!

- pavan kumar kolamuri


On Dec. 4, 2015, 10:22 a.m., Pallavi Rao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40960/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2015, 10:22 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1568
>     https://issues.apache.org/jira/browse/FALCON-1568
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Converted the listeners list to set and added a synchronized block.
> 
> 
> Diffs
> -----
> 
>   scheduler/src/main/java/org/apache/falcon/execution/ProcessExecutionInstance.java cff4a73 
>   scheduler/src/main/java/org/apache/falcon/notification/service/impl/JobCompletionService.java 501c6aa 
> 
> Diff: https://reviews.apache.org/r/40960/diff/
> 
> 
> Testing
> -------
> 
> Ensured existing UTs passed. Manual testing done.
> 
> 
> Thanks,
> 
> Pallavi Rao
> 
>


Re: Review Request 40960: FALCON-1568 Process Instances are not getting scheduled in Falcon Native Scheduler

Posted by Pallavi Rao <pa...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40960/
-----------------------------------------------------------

(Updated Dec. 4, 2015, 10:22 a.m.)


Review request for Falcon.


Changes
-------

Removed the commented code.


Bugs: FALCON-1568
    https://issues.apache.org/jira/browse/FALCON-1568


Repository: falcon-git


Description
-------

Converted the listeners list to set and added a synchronized block.


Diffs (updated)
-----

  scheduler/src/main/java/org/apache/falcon/execution/ProcessExecutionInstance.java cff4a73 
  scheduler/src/main/java/org/apache/falcon/notification/service/impl/JobCompletionService.java 501c6aa 

Diff: https://reviews.apache.org/r/40960/diff/


Testing
-------

Ensured existing UTs passed. Manual testing done.


Thanks,

Pallavi Rao